feat: Enhance YouTube API integration with improved configuration checks and documentation

README.md

@@ -136,8 +136,9 @@ Response:
 | `CROWNCODE_API_TIMEOUT_SEC` | `30` | External service timeout |
 | `SES_ANALIZI_THRESHOLD` | `0.5` | Authenticity score threshold |
 | `LOG_LEVEL` | `INFO` | Logging level |
-| `COMMEND_GEMINI_API_KEY` | - | Gemini API key for Crown Commend |
-| `COMMEND_TOKEN_JSON` | - | YouTube OAuth token JSON for posting |
+| `COMMEND_GEMINI_API_KEY` | - | Gemini API key for Crown Commend (also used as YouTube API Key fallback) |
+| `COMMEND_YOUTUBE_API_KEY` | - | YouTube Data API key for read operations (optional if Gemini key is set) |
+| `COMMEND_TOKEN_JSON` | - | YouTube OAuth token JSON for posting comments (optional) |
 
 ---
 

app/routes/commend/router.py

@@ -18,7 +18,9 @@ from .youtube_service import (
     get_channel_details,
     get_video_comments,
     get_video_transcript,
-    post_youtube_comment
+    post_youtube_comment,
+    is_youtube_configured,
+    is_oauth_configured
 )
 from .gemini_service import generate_comment, summarize_transcript
 from ...services.logging_config import get_logger
@@ -109,13 +111,17 @@ class CommendHealthResponse(BaseModel):
 async def commend_health_check():
     """Check Commend service health and configuration."""
     gemini_key = os.getenv('COMMEND_GEMINI_API_KEY')
-    youtube_token = os.getenv('COMMEND_TOKEN_JSON')
+    youtube_configured = is_youtube_configured()
+    oauth_configured = is_oauth_configured()
+
+    # Service is OK if we can at least generate comments (Gemini + YouTube read)
+    is_ok = bool(gemini_key) and youtube_configured
 
     return CommendHealthResponse(
-        status="ok" if gemini_key and youtube_token else "degraded",
+        status="ok" if is_ok else "degraded",
         geminiConfigured=bool(gemini_key),
-        youtubeConfigured=bool(youtube_token),
-        message="Crown Commend service is running"
+        youtubeConfigured=youtube_configured,
+        message=f"Crown Commend service is running. OAuth (posting): {'enabled' if oauth_configured else 'disabled'}"
     )
 
 

app/routes/commend/youtube_service.py

@@ -1,6 +1,10 @@
 """
 YouTube API Service for Crown Commend
 Handles video details, comments, and posting functionality.
+
+Authentication Strategy:
+- Read operations (video details, comments): Uses API Key (COMMEND_YOUTUBE_API_KEY)
+- Write operations (post comment): Uses OAuth 2.0 (COMMEND_TOKEN_JSON)
 """
 
 from __future__ import annotations
@@ -8,7 +12,6 @@ from __future__ import annotations
 import os
 import re
 import json
-import tempfile
 from typing import Optional, Tuple, List, Dict, Any
 
 from google.oauth2.credentials import Credentials
@@ -20,31 +23,73 @@ from ...services.logging_config import get_logger
 
 logger = get_logger(__name__)
 
+# Cached service instances
+_api_key_service = None
+_oauth_service = None
+
 
-def _get_authenticated_service():
+def _get_api_key_service():
     """
-    OAuth 2.0 ile YouTube API kimlik doğrulaması yapar.
-    Environment variables üzerinden credentials okur.
+    API Key ile YouTube API servisi oluşturur.
+    Read-only işlemler için kullanılır (video detayları, yorumları okuma).
     """
-    SCOPES = ['https://www.googleapis.com/auth/youtube.force-ssl']
+    global _api_key_service
 
-    # Production: TOKEN_JSON environment variable
-    token_json = os.getenv('COMMEND_TOKEN_JSON')
-    if token_json:
-        try:
-            token_data = json.loads(token_json)
-            creds = Credentials.from_authorized_user_info(token_data, SCOPES)
+    if _api_key_service is not None:
+        return _api_key_service
 
-            # Token expire olmuşsa refresh et
-            if creds.expired and creds.refresh_token:
-                creds.refresh(Request())
+    api_key = os.getenv('COMMEND_YOUTUBE_API_KEY')
+    if not api_key:
+        # Fallback: Gemini API key'i YouTube için de kullanılabilir
+        api_key = os.getenv('COMMEND_GEMINI_API_KEY')
+
+    if not api_key:
+        raise ValueError("COMMEND_YOUTUBE_API_KEY environment variable is required")
+
+    try:
+        _api_key_service = build('youtube', 'v3', developerKey=api_key)
+        logger.info("YouTube API Key service initialized")
+        return _api_key_service
+    except Exception as e:
+        logger.error(f"YouTube API Key service initialization failed: {e}")
+        raise ValueError(f"YouTube API initialization failed: {e}")
+
+
+def _get_oauth_service():
+    """
+    OAuth 2.0 ile YouTube API servisi oluşturur.
+    Write işlemleri için kullanılır (yorum gönderme).
+    """
+    global _oauth_service
+
+    if _oauth_service is not None:
+        # Check if credentials are still valid
+        return _oauth_service
+
+    SCOPES = ['https://www.googleapis.com/auth/youtube.force-ssl']
 
-            return build('youtube', 'v3', credentials=creds)
-        except Exception as e:
-            logger.error(f"TOKEN_JSON parse error: {e}")
-            raise ValueError("YouTube API authentication failed")
+    token_json = os.getenv('COMMEND_TOKEN_JSON')
+    if not token_json:
+        raise ValueError("COMMEND_TOKEN_JSON environment variable is required for posting comments")
 
-    raise ValueError("COMMEND_TOKEN_JSON environment variable is required")
+    try:
+        token_data = json.loads(token_json)
+        creds = Credentials.from_authorized_user_info(token_data, SCOPES)
+
+        # Token expire olmuşsa refresh et
+        if creds.expired and creds.refresh_token:
+            logger.info("Refreshing expired OAuth token")
+            creds.refresh(Request())
+
+        _oauth_service = build('youtube', 'v3', credentials=creds)
+        logger.info("YouTube OAuth service initialized")
+        return _oauth_service
+    except json.JSONDecodeError as e:
+        logger.error(f"TOKEN_JSON is not valid JSON: {e}")
+        raise ValueError("YouTube OAuth token is malformed")
+    except Exception as e:
+        logger.error(f"OAuth service initialization failed: {e}")
+        raise ValueError(f"YouTube OAuth authentication failed: {e}")
 
 
 def extract_video_id(video_url: str) -> Optional[str]:
@@ -67,6 +112,7 @@ def extract_video_id(video_url: str) -> Optional[str]:
 def get_video_details(video_url: str) -> Tuple[Optional[Dict[str, Any]], Optional[str]]:
     """
     YouTube video detaylarını çeker.
+    API Key kullanır (OAuth gerektirmez).
     Returns: (details_dict, error_message)
     """
     try:
@@ -74,7 +120,7 @@ def get_video_details(video_url: str) -> Tuple[Optional[Dict[str, Any]], Optiona
         if not video_id:
             return None, "Invalid YouTube URL"
 
-        youtube = _get_authenticated_service()
+        youtube = _get_api_key_service()
 
         request = youtube.videos().list(
             part="snippet,statistics,contentDetails",
@@ -114,13 +160,16 @@ def get_video_details(video_url: str) -> Tuple[Optional[Dict[str, Any]], Optiona
         return None, str(e)
     except Exception as e:
         logger.error(f"Error fetching video details: {e}")
-        return None, "Failed to fetch video details"
+        return None, f"Failed to fetch video details: {str(e)}"
 
 
 def get_channel_details(channel_id: str) -> Tuple[Optional[Dict[str, Any]], Optional[str]]:
-    """Kanal istatistiklerini çeker."""
+    """
+    Kanal istatistiklerini çeker.
+    API Key kullanır.
+    """
     try:
-        youtube = _get_authenticated_service()
+        youtube = _get_api_key_service()
 
         request = youtube.channels().list(
             part="statistics,snippet",
@@ -147,9 +196,12 @@ def get_channel_details(channel_id: str) -> Tuple[Optional[Dict[str, Any]], Opti
 
 
 def get_video_comments(video_id: str, max_results: int = 10) -> Tuple[List[Dict[str, str]], Optional[str]]:
-    """Video yorumlarını çeker."""
+    """
+    Video yorumlarını çeker.
+    API Key kullanır.
+    """
     try:
-        youtube = _get_authenticated_service()
+        youtube = _get_api_key_service()
 
         request = youtube.commentThreads().list(
             part="snippet",
@@ -172,7 +224,8 @@ def get_video_comments(video_id: str, max_results: int = 10) -> Tuple[List[Dict[
 
     except Exception as e:
         logger.error(f"Error fetching comments: {e}")
-        return [], "Failed to fetch comments"
+        # Yorumlar kapalı olabilir, boş liste dön
+        return [], None
 
 
 def get_video_transcript(video_id: str) -> Tuple[Optional[str], Optional[str]]:
@@ -210,9 +263,12 @@ def get_video_transcript(video_id: str) -> Tuple[Optional[str], Optional[str]]:
 
 
 def post_youtube_comment(video_id: str, comment_text: str) -> Tuple[Optional[Dict[str, Any]], Optional[str]]:
-    """YouTube'a yorum gönderir."""
+    """
+    YouTube'a yorum gönderir.
+    OAuth 2.0 gerektirir.
+    """
     try:
-        youtube = _get_authenticated_service()
+        youtube = _get_oauth_service()
 
         request_body = {
             "snippet": {
@@ -235,6 +291,9 @@ def post_youtube_comment(video_id: str, comment_text: str) -> Tuple[Optional[Dic
             'postedAt': response.get('snippet', {}).get('topLevelComment', {}).get('snippet', {}).get('publishedAt')
         }, None
 
+    except ValueError as e:
+        # OAuth not configured
+        return None, str(e)
     except Exception as e:
         logger.error(f"Error posting comment: {e}")
         error_str = str(e).lower()
@@ -243,5 +302,17 @@ def post_youtube_comment(video_id: str, comment_text: str) -> Tuple[Optional[Dic
             return None, "Comment posting is disabled for this video"
         elif "quota" in error_str:
             return None, "API quota exceeded, please try again later"
+        elif "invalid" in error_str and "token" in error_str:
+            return None, "OAuth token expired or invalid"
         else:
-            return None, "Failed to post comment"
+            return None, f"Failed to post comment: {str(e)}"
+
+
+def is_youtube_configured() -> bool:
+    """YouTube API Key yapılandırılmış mı kontrol eder."""
+    return bool(os.getenv('COMMEND_YOUTUBE_API_KEY') or os.getenv('COMMEND_GEMINI_API_KEY'))
+
+
+def is_oauth_configured() -> bool:
+    """OAuth (yorum gönderme) yapılandırılmış mı kontrol eder."""
+    return bool(os.getenv('COMMEND_TOKEN_JSON'))