instance_id stringlengths 17 41 | org stringclasses 19
values | repo stringclasses 19
values | number int64 29 21.7k | state stringclasses 1
value | title stringlengths 9 118 | body stringlengths 10 5.5k | base unknown | resolved_issues unknown | lang stringclasses 4
values | problem_statement stringlengths 51 34.5k | hints stringlengths 1 65.8k ⌀ | pull_url stringlengths 40 64 | issue_urls unknown | test_command stringlengths 66 10.4k ⌀ | fix_patch stringlengths 365 784k | test_patch stringlengths 382 698k | n2p_tests unknown | f2p_tests unknown | p2p_tests unknown | s2p_tests unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
zulip__zulip-flutter-304 | zulip | zulip-flutter | 304 | closed | model: Add Unreads model, for tracking unread-message counts | Fixes #253.
Contains my current revision of #299.
This is still in progress, but thought I'd check in with what I have so far, and see if it's going in the right direction. 🙂 | {
"label": "zulip:main",
"ref": "main",
"sha": "f4060fd2f05aced8d844a294aa34e96a1ef23a88"
} | [
{
"number": 253,
"title": "Track unread counts",
"body": "We want to show how many unread messages the user has in each stream and conversation, how many unread @-mentions they have, and how many unreads they have total, each in various places in the UI.\r\n\r\nThe data to power this begins with the `un... | dart | Track unread counts
We want to show how many unread messages the user has in each stream and conversation, how many unread @-mentions they have, and how many unreads they have total, each in various places in the UI.
The data to power this begins with the `unread_msgs` data structure in the initial data — search for... | Tentatively milestoning this as "alpha" because it's important for daily use to know if there are unreads at a glance; feel free to change.
> Then this data should appear in the UI:
>
> * in the list of recent DM conversations [ui: Add list of recent DM conversations #119](https://github.com/zulip/zulip-flutter/issu... | https://github.com/zulip/zulip-flutter/pull/304 | [
"https://github.com/zulip/zulip-flutter/issues/253"
] | flutter test test/api/model/events_test.dart test/api/model/initial_snapshot_test.dart test/model/algorithms_test.dart test/model/unreads_test.dart --reporter expanded 2>&1 | diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
index 86ba97f27f..241aa70a41 100644
--- a/lib/api/model/events.dart
+++ b/lib/api/model/events.dart
@@ -438,8 +438,15 @@ class DeleteMessageEvent extends Event {
this.topic,
});
- factory DeleteMessageEvent.fromJson(Map<String, dynamic> json)... | diff --git a/test/api/model/events_test.dart b/test/api/model/events_test.dart
index eb05fb95b2..2fe7153065 100644
--- a/test/api/model/events_test.dart
+++ b/test/api/model/events_test.dart
@@ -43,6 +43,38 @@ void main() {
check(mkEvent([MessageFlag.read])).message.flags.deepEquals([MessageFlag.read]);
});
+... | {
"/home/zulip-flutter/test/model/algorithms_test.dart: setUnion nonempty, empty": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"/home/zulip-flutter/test/model/unreads_test.dart: handleMessageEvent unread / stream / not direct mentioned / not wildcard mentioned": {
"run": "NONE",
"test": ... | {
"/home/zulip-flutter/test/api/model/initial_snapshot_test.dart: UnreadDmSnapshot: require sorted unreadMessageIds": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"/home/zulip-flutter/test/api/model/initial_snapshot_test.dart: UnreadHuddleSnapshot: require sorted unreadMessageIds": {
"run": "... | {
"/home/zulip-flutter/test/api/model/events_test.dart: message: move flags into message object": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"/home/zulip-flutter/test/api/model/events_test.dart: user_settings: all known settings have event handling": {
"run": "PASS",
"test": "PASS",
... | {} |
AntennaPod__AntennaPod-7954 | AntennaPod | AntennaPod | 7,954 | closed | Tags above subscriptions screen | ### Description
Tags above subscriptions screen, remembers the last selected one
Closes #5318
<img width="200" alt="Screenshot_20250830-145355" src="https://github.com/user-attachments/assets/10e15860-51e7-4321-a5f1-1dc436b3790e" />
### Checklist
<!--
To help us keep the issue tracker clean and work as e... | {
"label": "AntennaPod:develop",
"ref": "develop",
"sha": "944e0690ba5a070ad02834a3c3d90946bf3ee738"
} | [
{
"number": 5318,
"title": "Display podcast tags at the top of the Subscriptions screen",
"body": "# Checklist\r\n\r\n- [x ] I have used the search function to see if someone else has already submitted the same feature request.\r\n- [x ] I will only create one feature request per issue.\r\n- [x ] I will... | java | Display podcast tags at the top of the Subscriptions screen
# Checklist
- [x ] I have used the search function to see if someone else has already submitted the same feature request.
- [x ] I will only create one feature request per issue.
- [x ] I will describe the problem with as much detail as possible.
# Sys... | Oh, as I just checked the changelog, could it be that this feature has been implemented in 2.3.0 as of
> Support for tagging (grouping) subscriptions
but I haven't seen it yet as F-Droid hasn't rolled out the latest version yet?
> but I haven't seen it yet as F-Droid hasn't rolled out the latest version yet?
Yup, ... | https://github.com/AntennaPod/AntennaPod/pull/7954 | [
"https://github.com/AntennaPod/AntennaPod/issues/5318"
] | ./gradlew :net:download:service:testFreeDebugUnitTest --tests "de.danoeh.antennapod.net.download.service.episode.autodownload.DbReaderTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/activity/SelectSubscriptionActivity.java b/app/src/main/java/de/danoeh/antennapod/activity/SelectSubscriptionActivity.java
index 2b11080565b..749799b236b 100644
--- a/app/src/main/java/de/danoeh/antennapod/activity/SelectSubscriptionActivity.java
+++ b/app/src/main/ja... | diff --git a/net/download/service/src/test/java/de/danoeh/antennapod/net/download/service/episode/autodownload/DbReaderTest.java b/net/download/service/src/test/java/de/danoeh/antennapod/net/download/service/episode/autodownload/DbReaderTest.java
index 8f54609b013..16dce9143ba 100644
--- a/net/download/service/src/test... | {
"de.danoeh.antennapod.net.download.service.episode.autodownload.DbReaderTest$SingleTests.testLoadFeedDataOfFeedItemlist": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.net.download.service.episode.autodownload.DbReaderTest$PlaybackHistoryTest.testGetPlaybackHistory[7]": {
... | {} | {} | {} |
AntennaPod__AntennaPod-7815 | AntennaPod | AntennaPod | 7,815 | closed | Feature add incompletely played episodes to playback history | ### Description
Resolves #7702
This PR adds partially played episodes to the Playlist History by repurposing the database column `KEY_PLAYBACK_COMPLETION_DATE` as `KEY_LAST_PLAYED_TIME_HISTORY`, as discussed here: https://github.com/AntennaPod/AntennaPod/issues/7702#issue-2933349528
|Before|After|
|---|---|
... | {
"label": "AntennaPod:develop",
"ref": "develop",
"sha": "49e6da67271dead9d0a574c9ecbd70c35da18d36"
} | [
{
"number": 7702,
"title": "Add episodes to playback history even when not completing them",
"body": "### Checklist\n\n- [x] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same feature request.\n- [x... | java | Add episodes to playback history even when not completing them
### Checklist
- [x] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same feature request.
- [x] I have **also** used the search function for [**CLOSED**... | Hi, I would be interested to work on this. Just for clarification:
your idea is to repurpose `completion_date` to store the same value as `last_played_time`?
As of sqlite v. 3.28 its possible to rename columns, from what i could find:
https://stackoverflow.com/questions/805363/how-do-i-rename-a-column-in-an-sqlite-da... | https://github.com/AntennaPod/AntennaPod/pull/7815 | [
"https://github.com/AntennaPod/AntennaPod/issues/7702"
] | ./gradlew :net:download:service:testFreeDebugUnitTest --tests "de.danoeh.antennapod.net.download.service.episode.autodownload.DbCleanupTests" --tests "de.danoeh.antennapod.net.download.service.episode.autodownload.DbReaderTest" --tests "de.danoeh.antennapod.net.download.service.episode.autodownload.DbWriterTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/ui/swipeactions/RemoveFromHistorySwipeAction.java b/app/src/main/java/de/danoeh/antennapod/ui/swipeactions/RemoveFromHistorySwipeAction.java
index 4e89be62308..3d99a4cba84 100644
--- a/app/src/main/java/de/danoeh/antennapod/ui/swipeactions/RemoveFromHistorySwipeAction... | diff --git a/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java b/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java
index 4b93dcee9b9..8eef573d07a 100644
--- a/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java
+++ b/app/src/androidTest/java/de/test/antennapod/ui/UITestUtils.java... | {
"de.danoeh.antennapod.net.download.service.episode.autodownload.DbWriterTest.testClearQueue": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.net.download.service.episode.autodownload.DbReaderTest$SingleTests.testLoadFeedDataOfFeedItemlist": {
"run": "PASS",
"test": "... | {} | {} | {} |
AntennaPod__AntennaPod-7581 | AntennaPod | AntennaPod | 7,581 | closed | Highlight plain-text links in episode description | ### Description
closes #7578
### Checklist
- [x] I have read the contribution guidelines: https://github.com/AntennaPod/AntennaPod/blob/develop/CONTRIBUTING.md#submit-a-pull-request
- [x] I have performed a self-review of my code
- [x] I have run the automated code checks using `./gradlew checkstyle spotbugs... | {
"label": "AntennaPod:develop",
"ref": "develop",
"sha": "60f5faf394e9859e2505923a81cac6e86d21930f"
} | [
{
"number": 7578,
"title": "Highlight plain-text links in episode description",
"body": "### Checklist\n\n- [X] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same feature request.\n- [X] I have **al... | java | Highlight plain-text links in episode description
### Checklist
- [X] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same feature request.
- [X] I have **also** used the search function for [**CLOSED**](https://git... | Could you open a PR please, so we can have a look at your solution? | https://github.com/AntennaPod/AntennaPod/pull/7581 | [
"https://github.com/AntennaPod/AntennaPod/issues/7578"
] | ./gradlew :app:testFreeDebugUnitTest --tests "de.danoeh.antennapod.ui.cleaner.PlainTextLinksConverterTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/ui/cleaner/PlainTextLinksConverter.java b/app/src/main/java/de/danoeh/antennapod/ui/cleaner/PlainTextLinksConverter.java
new file mode 100644
index 00000000000..8f7d59e2d9d
--- /dev/null
+++ b/app/src/main/java/de/danoeh/antennapod/ui/cleaner/PlainTextLinksConverter.j... | diff --git a/app/src/test/java/de/danoeh/antennapod/ui/cleaner/PlainTextLinksConverterTest.java b/app/src/test/java/de/danoeh/antennapod/ui/cleaner/PlainTextLinksConverterTest.java
new file mode 100644
index 00000000000..36e55d02e3b
--- /dev/null
+++ b/app/src/test/java/de/danoeh/antennapod/ui/cleaner/PlainTextLinksCon... | {
"de.danoeh.antennapod.ui.cleaner.PlainTextLinksConverterTest.testConvertToHtmlWhenNoLinksAreDetected": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.ui.cleaner.PlainTextLinksConverterTest.testBrokenLinksAreNotCreated": {
"run": "NONE",
"test": "NONE",
"fix": "PA... | {} | {} | {} |
AntennaPod__AntennaPod-7537 | AntennaPod | AntennaPod | 7,537 | closed | Vtt support for transcripts | ### Description
This PR adds VTT support for transcripts (in addition to existing SRT and JSON).
Closes #7431
### Checklist
<!--
To help us keep the issue tracker clean and work as efficient as possible,
please make sure that you have done all of the following.
You can tick the boxes below by placi... | {
"label": "AntennaPod:develop",
"ref": "develop",
"sha": "310ce203cea26cf14dc8514ab72d028e545640ab"
} | [
{
"number": 7431,
"title": "Support WebVTT transcript format",
"body": "### Checklist\n\n- [X] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same feature request.\n- [X] I have **also** used the sea... | java | Support WebVTT transcript format
### Checklist
- [X] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same feature request.
- [X] I have **also** used the search function for [**CLOSED**](https://github.com/AntennaPo... | :)
This is a good VTT to show, in that it has the speaker identification in it.
Hello,
Thanks a lot for the work already done on transcripts!
I’d very much like to see VTT support happening, and to that end I volunteer to try and add the feature.
But I see that @tonytamsf you already assigned yourself to that... | https://github.com/AntennaPod/AntennaPod/pull/7537 | [
"https://github.com/AntennaPod/AntennaPod/issues/7431"
] | ./gradlew :parser:transcript:testDebugUnitTest --tests "de.danoeh.antennapod.parser.transcript.VttTranscriptParserTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/ui/screen/playback/TranscriptAdapter.java b/app/src/main/java/de/danoeh/antennapod/ui/screen/playback/TranscriptAdapter.java
index ffb3b7bdae5..7ce8b0964e3 100644
--- a/app/src/main/java/de/danoeh/antennapod/ui/screen/playback/TranscriptAdapter.java
+++ b/app/src/main... | diff --git a/parser/transcript/src/test/java/de/danoeh/antennapod/parser/transcript/VttTranscriptParserTest.java b/parser/transcript/src/test/java/de/danoeh/antennapod/parser/transcript/VttTranscriptParserTest.java
new file mode 100644
index 00000000000..ed9a506e330
--- /dev/null
+++ b/parser/transcript/src/test/java/d... | {
"de.danoeh.antennapod.parser.transcript.VttTranscriptParserTest.testParseVttSimple": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.parser.transcript.VttTranscriptParserTest.testParse": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.p... | {} | {} | {} |
AntennaPod__AntennaPod-7098 | AntennaPod | AntennaPod | 7,098 | closed | Add episodes without subscribing | ### Description
Adding episodes to the queue without subscribing is a long running feature request. Doing this does not really make sense on a distributed podcast app. However, to make these people happy, subscribe to the feed internally anyway and just tell them that it is not subscribed.
Closes #4710
<img wi... | {
"label": "AntennaPod:develop",
"ref": "develop",
"sha": "cb1a03cd8d55efca8a815d9c55b6a9a6448c0267"
} | [
{
"number": 4710,
"title": "Add/play single episode without subscribing to podcast",
"body": "# Checklist\r\n<!-- Place an x in the boxes to tick them: [x] -->\r\n\r\n- [x] I have used the search function to see if someone else has already submitted the same feature request.\r\n- [x] I will only create ... | java | Add/play single episode without subscribing to podcast
# Checklist
<!-- Place an x in the boxes to tick them: [x] -->
- [x] I have used the search function to see if someone else has already submitted the same feature request.
- [x] I will only create one feature request per issue.
- [x] I will describe the probl... | I suggest we don't work on this. Without subscribing to a podcast, it's difficult to manage that 'dangling' episode in the app without the data structures behind the 'parent', which is the podcast.
For example: for the episode that you download, we have to deal with the 'Open Podcast' menu because it has no wher... | https://github.com/AntennaPod/AntennaPod/pull/7098 | [
"https://github.com/AntennaPod/AntennaPod/issues/4710"
] | ./gradlew :storage:database:testFreeDebugUnitTest --tests "de.danoeh.antennapod.storage.database.NonSubscribedFeedsCleanerTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/actionbutton/ItemActionButton.java b/app/src/main/java/de/danoeh/antennapod/actionbutton/ItemActionButton.java
index 84b24616705..54714be3d17 100644
--- a/app/src/main/java/de/danoeh/antennapod/actionbutton/ItemActionButton.java
+++ b/app/src/main/java/de/danoeh/anten... | diff --git a/storage/database/src/test/java/de/danoeh/antennapod/storage/database/NonSubscribedFeedsCleanerTest.java b/storage/database/src/test/java/de/danoeh/antennapod/storage/database/NonSubscribedFeedsCleanerTest.java
new file mode 100644
index 00000000000..76bbfddc1a0
--- /dev/null
+++ b/storage/database/src/test... | {
"de.danoeh.antennapod.storage.database.NonSubscribedFeedsCleanerTest.testQueuedItem": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.storage.database.NonSubscribedFeedsCleanerTest.testSubscribed": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.a... | {} | {} | {} |
AntennaPod__AntennaPod-6808 | AntennaPod | AntennaPod | 6,808 | closed | Check if volume boost effect is supported on the device | This is an attempt to fix #6802. I have no idea if it works (I cannot reproduce the issue on my device). | {
"label": "AntennaPod:master",
"ref": "master",
"sha": "58081fe5bf7d9ad28f089cf10b2c17bfcfc8bbc7"
} | [
{
"number": 6802,
"title": "Media wont play in Version 3.2.0 (3020095)",
"body": "### Checklist\r\n\r\n- [X] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same bug report.\r\n- [X] I have **also** u... | java | Media wont play in Version 3.2.0 (3020095)
### Checklist
- [X] I have used the search function for [**OPEN**](https://github.com/AntennaPod/AntennaPod/issues) issues to see if someone else has already submitted the same bug report.
- [X] I have **also** used the search function for [**CLOSED**](https://github.com/A... | Ping @matejdro
My guess is that this device does not support the audio boost effect?
From what I can read , we can query the effects via `android.media.audiofx.AudioEffect.queryEffects` and if there is not UUID of `android.media.audiofx.AudioEffect#EFFECT_TYPE_LOUDNESS_ENHANCER` in there, disable it in ExoPlayerWrap... | https://github.com/AntennaPod/AntennaPod/pull/6808 | [
"https://github.com/AntennaPod/AntennaPod/issues/6802"
] | ./gradlew :core:testFreeDebugUnitTest --tests "de.danoeh.antennapod.core.feed.VolumeAdaptionSettingTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/preferences/VolumeAdaptationPreference.java b/app/src/main/java/de/danoeh/antennapod/preferences/VolumeAdaptationPreference.java
new file mode 100644
index 00000000000..584b7d90ec5
--- /dev/null
+++ b/app/src/main/java/de/danoeh/antennapod/preferences/VolumeAdaptation... | diff --git a/core/src/test/java/de/danoeh/antennapod/core/feed/VolumeAdaptionSettingTest.java b/core/src/test/java/de/danoeh/antennapod/core/feed/VolumeAdaptionSettingTest.java
index 30767bdc884..966351a5e45 100644
--- a/core/src/test/java/de/danoeh/antennapod/core/feed/VolumeAdaptionSettingTest.java
+++ b/core/src/tes... | {
"de.danoeh.antennapod.core.feed.VolumeAdaptionSettingTest.mapLightBoostToInteger": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.core.feed.VolumeAdaptionSettingTest.mapOffToInteger": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.cor... | {} | {} | {} |
AntennaPod__AntennaPod-6739 | AntennaPod | AntennaPod | 6,739 | closed | Parse podcast:transcript url and store in SQLite | Fix #4935
@keunes , @ByteHamster mentioned that for the big feature for transcript, we will use the `transcript` branch and target many small PR's
This PR parses the `<podcast:transcript>` tag from a feed and store the URL of most preferred format (JSON and then SRT)
It's ready for review
Validation using ... | {
"label": "AntennaPod:transcript",
"ref": "transcript",
"sha": "2c3fb5610a98d80db25b85fdf0607bfc2b6216fc"
} | [
{
"number": 4935,
"title": "Support for podcast:transcript tag",
"body": "# Checklist\r\n<!-- Place an x in the boxes to tick them: [x] -->\r\n\r\n- [x] I have used the search function to see if someone else has already submitted the same feature request.\r\n- [x] I will only create one feature request ... | java | Support for podcast:transcript tag
# Checklist
<!-- Place an x in the boxes to tick them: [x] -->
- [x] I have used the search function to see if someone else has already submitted the same feature request.
- [x] I will only create one feature request per issue.
- [x] I will describe the problem with as much deta... | @keunes or @ByteHamster please assign to me, since I have the podcastindex namespace parsing done in #4933, I could tackle `podcast:transcript`
I have a a few suggestions for transcript related features I think would be great to include in AntennaPod (originally mentioned in https://github.com/AntennaPod/AntennaPod/is... | https://github.com/AntennaPod/AntennaPod/pull/6739 | [
"https://github.com/AntennaPod/AntennaPod/issues/4935"
] | ./gradlew :parser:feed:testDebugUnitTest --tests "de.danoeh.antennapod.parser.feed.element.namespace.RssParserTest" | diff --git a/model/src/main/java/de/danoeh/antennapod/model/feed/FeedItem.java b/model/src/main/java/de/danoeh/antennapod/model/feed/FeedItem.java
index a8570ea4e6f..a6142048073 100644
--- a/model/src/main/java/de/danoeh/antennapod/model/feed/FeedItem.java
+++ b/model/src/main/java/de/danoeh/antennapod/model/feed/FeedI... | diff --git a/parser/feed/src/test/java/de/danoeh/antennapod/parser/feed/element/namespace/RssParserTest.java b/parser/feed/src/test/java/de/danoeh/antennapod/parser/feed/element/namespace/RssParserTest.java
index 88ac5c73146..4ce8911e921 100644
--- a/parser/feed/src/test/java/de/danoeh/antennapod/parser/feed/element/na... | {
"de.danoeh.antennapod.parser.feed.element.namespace.RssParserTest.testUnsupportedElements": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.parser.feed.element.namespace.RssParserTest.testRss2Basic": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh... | {} | {} | {} |
AntennaPod__AntennaPod-6659 | AntennaPod | AntennaPod | 6,659 | closed | Add sort downloads by size feature | I want to try to resolve #6642 .
Please make a review. I hope it helps. | {
"label": "AntennaPod:develop",
"ref": "develop",
"sha": "574ec1434c885429e0d9b4061dff765eb7284701"
} | [
{
"number": 6642,
"title": "Sort downloads by size",
"body": "### Checklist\n\n- [X] I have used the search function for [open](https://github.com/AntennaPod/AntennaPod/issues) **and** [closed](https://github.com/AntennaPod/AntennaPod/issues?q=is%3Aissue+is%3Aclosed) issues to see if someone else has al... | java | Sort downloads by size
### Checklist
- [X] I have used the search function for [open](https://github.com/AntennaPod/AntennaPod/issues) **and** [closed](https://github.com/AntennaPod/AntennaPod/issues?q=is%3Aissue+is%3Aclosed) issues to see if someone else has already submitted the same feature request.
- [X] I will de... | Hey @Julian . I would like to work on this issue!! Is this still open?
Yes, it is still open :)
Great!! I would like to work on it then. | https://github.com/AntennaPod/AntennaPod/pull/6659 | [
"https://github.com/AntennaPod/AntennaPod/issues/6642"
] | ./gradlew :core:testFreeDebugUnitTest --tests "de.danoeh.antennapod.core.util.FeedItemPermutorsTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/CompletedDownloadsFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/CompletedDownloadsFragment.java
index ba328adba71..730a3918988 100644
--- a/app/src/main/java/de/danoeh/antennapod/fragment/CompletedDownloadsFragment.java
+++ b/app/src/main/ja... | diff --git a/core/src/test/java/de/danoeh/antennapod/core/util/FeedItemPermutorsTest.java b/core/src/test/java/de/danoeh/antennapod/core/util/FeedItemPermutorsTest.java
index 9c48f8df7eb..be4012cb6cc 100644
--- a/core/src/test/java/de/danoeh/antennapod/core/util/FeedItemPermutorsTest.java
+++ b/core/src/test/java/de/da... | {
"de.danoeh.antennapod.core.util.FeedItemPermutorsTest.testPermutorForRule_EPISODE_TITLE_ASC": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.core.util.FeedItemPermutorsTest.testPermutorForRule_FEED_TITLE_DESC_NullTitle": {
"run": "PASS",
"test": "NONE",
"fix": "P... | {} | {} | {} |
AntennaPod__AntennaPod-6573 | AntennaPod | AntennaPod | 6,573 | closed | Add volume boost | This PR changes "Volume reduction" setting into "Volume adaptation" setting, adding three extra options for volume boost in addition to existing light and heavy reduction options-
This fixes #5286 | {
"label": "AntennaPod:develop",
"ref": "develop",
"sha": "5ae766b1a1557e2a54627e6b3c83c54c6578995d"
} | [
{
"number": 5286,
"title": "Option to allow boosting audio volume over 100%",
"body": "# Checklist\r\n\r\n- [x ] I have used the search function to see if someone else has already submitted the same feature request.\r\n- [ x] I will only create one feature request per issue.\r\n- [x ] I will describe th... | java | Option to allow boosting audio volume over 100%
# Checklist
- [x ] I have used the search function to see if someone else has already submitted the same feature request.
- [ x] I will only create one feature request per issue.
- [x ] I will describe the problem with as much detail as possible.
# System info
... | Hi and thank you for writing this issue!
It looks like you did not follow our issue template. In case you accidentally deleted the template, you can find the version for bug reports [here](https://raw.githubusercontent.com/AntennaPod/AntennaPod/develop/.github/ISSUE_TEMPLATE/bug_report.md) and the version for feature ... | https://github.com/AntennaPod/AntennaPod/pull/6573 | [
"https://github.com/AntennaPod/AntennaPod/issues/5286"
] | ./gradlew :core:testFreeDebugUnitTest --tests "de.danoeh.antennapod.core.feed.VolumeAdaptionSettingTest" | diff --git a/app/src/main/java/de/danoeh/antennapod/fragment/FeedSettingsFragment.java b/app/src/main/java/de/danoeh/antennapod/fragment/FeedSettingsFragment.java
index ae9e003d504..0e4c883cfe1 100644
--- a/app/src/main/java/de/danoeh/antennapod/fragment/FeedSettingsFragment.java
+++ b/app/src/main/java/de/danoeh/anten... | diff --git a/app/src/androidTest/java/de/test/antennapod/ui/FeedSettingsTest.java b/app/src/androidTest/java/de/test/antennapod/ui/FeedSettingsTest.java
index 861c62f1bff..187c9e16dac 100644
--- a/app/src/androidTest/java/de/test/antennapod/ui/FeedSettingsTest.java
+++ b/app/src/androidTest/java/de/test/antennapod/ui/F... | {
"de.danoeh.antennapod.core.feed.VolumeAdaptionSettingTest.mapLightBoostToInteger": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.core.feed.VolumeAdaptionSettingTest.mapOffToInteger": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"de.danoeh.antennapod.cor... | {} | {} | {} |
commons-app__apps-android-commons-6529 | commons-app | apps-android-commons | 6,529 | closed | Test/2819 add campaigns api tests | **Description (required)**
Fixes #2819
What changes did you make and why?
This PR implements the requested unit tests for the `OkHttpJsonApiClient:getCampaigns` method to ensure the API layer is working correctly.
The changes include:
1. **Model Fixes:** Updated `CampaignConfig` and `CampaignResponseDTO` ... | {
"label": "commons-app:main",
"ref": "main",
"sha": "3a55583460d3294efc7ae2000616d1cb4ec6ad68"
} | [
{
"number": 2819,
"title": "Add unit test for fetching campaigns",
"body": "**Summary:** \r\n\r\nNow that we have #2793 in place we can easily test campaigns. At least we should have unit tests to verify the API layer (using mock web server). Specifically we need to test `OkHttpJsonApiClient:getCampaign... | kotlin | Add unit test for fetching campaigns
**Summary:**
Now that we have #2793 in place we can easily test campaigns. At least we should have unit tests to verify the API layer (using mock web server). Specifically we need to test `OkHttpJsonApiClient:getCampaigns` for 2 scenarios.
- when the API returns at least 1 c... | Can i work on this @maskaravivek
Sure take this up. @JobGetabu
Hi @maskaravivek! I would like to work on this issue if no one else is looking into it.
@SaumiaSinghal Yes, sure. Assigned to you.
Hi @maskaravivek! Thanks for assigning the issue. I'm running into an error on running the tests that I wrote, I have poi... | https://github.com/commons-app/apps-android-commons/pull/6529 | [
"https://github.com/commons-app/apps-android-commons/issues/2819"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.OkHttpJsonApiClientTests" | diff --git a/app/src/main/java/fr/free/nrw/commons/campaigns/CampaignConfig.kt b/app/src/main/java/fr/free/nrw/commons/campaigns/CampaignConfig.kt
index 6bf0bc0ed6..9f94e85927 100644
--- a/app/src/main/java/fr/free/nrw/commons/campaigns/CampaignConfig.kt
+++ b/app/src/main/java/fr/free/nrw/commons/campaigns/CampaignCon... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApiClientTests.kt b/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApiClientTests.kt
index 9e78915603..1a9d1500b5 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApiClientTests.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApi... | {
"fr.free.nrw.commons.OkHttpJsonApiClientTests.testGetCampaignsWithData": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.OkHttpJsonApiClientTests.testGetNearbyPlaces": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.OkHttpJsonApiClientTes... | {} | {} | {} |
commons-app__apps-android-commons-6167 | commons-app | apps-android-commons | 6,167 | closed | Enhance filtering criteria for category search | Fixes #4901
What changes did you make and why?
This PR is an extension of #4902 PR. refer to [comment](https://github.com/commons-app/apps-android-commons/issues/4901#issuecomment-2592110652). Conflicting changes were made while this PR was open making changes introduced outdated. Also, some of the checks were re... | {
"label": "commons-app:main",
"ref": "main",
"sha": "36f844a709dc40944644723917c0b1622380edf6"
} | [
{
"number": 4901,
"title": "[Bug]: Category \"Amavenita (ship, 2014)\" not found",
"body": "### Summary\n\nI serached for a category that exists, but it doesn't show up.\n\n### Steps to reproduce\n\n1. When uploading an image, search for category: Amavenita\r\n\n\n### Expected behaviour\n\n[Category:Ama... | kotlin | [Bug]: Category "Amavenita (ship, 2014)" not found
### Summary
I serached for a category that exists, but it doesn't show up.
### Steps to reproduce
1. When uploading an image, search for category: Amavenita
### Expected behaviour
[Category:Amavenita (ship, 2014)](https://commons.wikimedia.org/wiki/Category:Amav... | @Ainali isn't this the expected behaviour? Because, Amavenita (ship, 2014) is a non-hidden category and I think we are only supposed to show the hidden category in search bar. But I could be wrong.
Oh, I didn't realize. Then this is a duplicate with #4192 (and a use case for why it is needed, this is how all ships are... | https://github.com/commons-app/apps-android-commons/pull/6167 | [
"https://github.com/commons-app/apps-android-commons/issues/4901"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.category.CategoriesModelTest" | diff --git a/app/.attach_pid781771 b/app/.attach_pid781771
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoriesModel.kt b/app/src/main/java/fr/free/nrw/commons/category/CategoriesModel.kt
index fd90be95fd..47147944c6 100644
--- a/app/src/main/java/fr/f... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/category/CategoriesModelTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/category/CategoriesModelTest.kt
index 8c336470a6..21fdba2f57 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/category/CategoriesModelTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/c... | {
"fr.free.nrw.commons.category.CategoriesModelTest.Test buildCategories when it returns non empty list": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.category.CategoriesModelTest.Test onCategoryItemClicked when media is not null and item is selected and media does not contai... | {
"fr.free.nrw.commons.category.CategoriesModelTest.test invalid category when have taken on in the input": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"fr.free.nrw.commons.category.CategoriesModelTest.Test onCategoryItemClicked when media is null and item is not selected": {
"run": "PASS",
... | {
"fr.free.nrw.commons.category.CategoriesModelTest.Test onCategoryItemClicked when media is null and item is selected": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"fr.free.nrw.commons.category.CategoriesModelTest.testSetSelectedExistingCategories": {
"run": "PASS",
"test": "PASS",
... | {} |
commons-app__apps-android-commons-6130 | commons-app | apps-android-commons | 6,130 | closed | If depicted Wikidata item has no associated Commons category property, then suggest categories from its P18 | **Description (required)**
Resolves #5936
**Tests performed (required)**
Tested ProdDebug on Samsung S20FE with API level 33.
**Screenshots (for UI changes only)**
In the screenrecord below, the item [Warnitz (Uckermark) railway station](https://www.wikidata.org/wiki/Q7969836) has no commons category, so i... | {
"label": "commons-app:main",
"ref": "main",
"sha": "62136b5b09695e50c9dd5f86dfbb7e49d7282243"
} | [
{
"number": 5936,
"title": "If depicted Wikidata item has no associated Commons category property, then suggest categories from its P18",
"body": "### What is the user problem or growth opportunity you want to see solved?\n\nRecently, the objects that already have an image are also displayed for searche... | kotlin | If depicted Wikidata item has no associated Commons category property, then suggest categories from its P18
### What is the user problem or growth opportunity you want to see solved?
Recently, the objects that already have an image are also displayed for searched images.
I would find it helpful if all categories o... | I am not sure to understand. Would you mind editing to add a real-world example, citing the real-world objects/categories? Thanks!
@nicolas-raoul
There is already a picture (“Picture A”) for a Wikidata object (Q7969836).
I would like to upload another (“Picture B”) picture related to the same Wikidata object (Q79... | https://github.com/commons-app/apps-android-commons/pull/6130 | [
"https://github.com/commons-app/apps-android-commons/issues/5936"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.category.CategoriesModelTest" --tests "fr.free.nrw.commons.upload.structure.depictions.DepictedItemTest" | diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategoriesModel.kt b/app/src/main/java/fr/free/nrw/commons/category/CategoriesModel.kt
index 7e6fee2fca..fd90be95fd 100644
--- a/app/src/main/java/fr/free/nrw/commons/category/CategoriesModel.kt
+++ b/app/src/main/java/fr/free/nrw/commons/category/CategoriesMo... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/category/CategoriesModelTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/category/CategoriesModelTest.kt
index cc5340fbb7..8c336470a6 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/category/CategoriesModelTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/c... | {
"fr.free.nrw.commons.upload.structure.depictions.DepictedItemTest.id is entityId": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.upload.structure.depictions.DepictedItemTest.hashCode returns same values for objects with same name": {
"run": "PASS",
"test": "NONE",
... | {} | {} | {} |
commons-app__apps-android-commons-6070 | commons-app | apps-android-commons | 6,070 | closed | Nearby: No longer keeps loading until timeout when map is zoomed out | **Description (required)**
Fixes #6044
Put briefly, the map now only searches in up to 300km radius centered on the screen's center.
The change wasnn't that simple, as loading the list of items even for a 50km radius can result in timeout for some locations, so I implemented an algorithm based on binary search... | {
"label": "commons-app:main",
"ref": "main",
"sha": "c963cd9ea49b1fa9dd2baf20e11d1b46e75abc62"
} | [
{
"number": 6044,
"title": "Nearby: Flawed initial loading of pins.",
"body": "Currently, in nearby, when a user scrolls (which also includes resizing) to a new position in the map), a query is made for items in the rectangular geographical area. Although the query is lightweight (made for only P625), i... | kotlin | Nearby: Flawed initial loading of pins.
Currently, in nearby, when a user scrolls (which also includes resizing) to a new position in the map), a query is made for items in the rectangular geographical area. Although the query is lightweight (made for only P625), it goes on endlessly until timeout for large enough area... | Great ideas! I totally agree with all of this.
Do you want to be assigned? (please mention it when creating issues)
> Do you want to be assigned? (please mention it when creating issues)
Yes, I'll be glad to implement this. I'll make sure to mention if I’d like to be assigned in future issues. | https://github.com/commons-app/apps-android-commons/pull/6070 | [
"https://github.com/commons-app/apps-android-commons/issues/6044"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.OkHttpJsonApiClientTests" | diff --git a/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt b/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt
index 415d316711..291c834bdc 100644
--- a/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonApiClient.kt
+++ b/app/src/main/java/fr/free/nrw/commons/mwapi/OkHttpJsonAp... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApiClientTests.kt b/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApiClientTests.kt
index 3431efd6b8..9e78915603 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApiClientTests.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/OkHttpJsonApi... | {
"fr.free.nrw.commons.OkHttpJsonApiClientTests.testGetNearbyPlacesCustomQuery": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.OkHttpJsonApiClientTests.testGetNearbyPlaces": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.OkHttpJsonApiCli... | {} | {} | {} |
commons-app__apps-android-commons-6041 | commons-app | apps-android-commons | 6,041 | closed | Add pull down to refresh in Contributions screen | Fixes #5131
What changes did you make and why?
Add pull down to refresh in the contributions screen to fetch the latest data.
**Screenshots (for UI changes only)**
https://github.com/user-attachments/assets/a49cfc77-294a-45e0-a877-01c51a81cc7a
| {
"label": "commons-app:main",
"ref": "main",
"sha": "5500b039762b63d18b794bb0bc68d2a84a495166"
} | [
{
"number": 5131,
"title": "Add pull down sync",
"body": "Install the app on two different cell phones. Take some pictures and upload them on one cell phone, then do the same on the different cell phone.\n\nNow back on the first cell phone pull down on the screen (refresh action), expecting to be able t... | kotlin | Add pull down sync
Install the app on two different cell phones. Take some pictures and upload them on one cell phone, then do the same on the different cell phone.
Now back on the first cell phone pull down on the screen (refresh action), expecting to be able to see the pictures that one took on the other cell phone.... | (Workaround: log out and then log in again. Your latest contributions from outside the app will then appear. )
@nicolas-raoul Can you please assign this issue to me?
I believe we can use SwipeRefreshLayout (Released by Android) to implement it.
@nicolas-raoul I am able to implement the swipe-to-refresh functionality... | https://github.com/commons-app/apps-android-commons/pull/6041 | [
"https://github.com/commons-app/apps-android-commons/issues/5131"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.contributions.ContributionBoundaryCallbackTest" | diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionBoundaryCallback.kt b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionBoundaryCallback.kt
index 3f7bffe91b..b5075a21e0 100644
--- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionBoundaryCallback.kt
+++ b/app/s... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt
index 19b36521df..11b5fe9a23 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackT... | {
"fr.free.nrw.commons.contributions.ContributionBoundaryCallbackTest.testFetchContributionsFailed": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.contributions.ContributionBoundaryCallbackTest.testOnZeroItemsLoaded": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
... | {
"fr.free.nrw.commons.contributions.ContributionBoundaryCallbackTest.testFetchContributions": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"fr.free.nrw.commons.contributions.ContributionBoundaryCallbackTest.testOnFrontItemLoaded": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"fr.free.nrw.commons.contributions.ContributionBoundaryCallbackTest.testOnLastItemLoaded": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
commons-app__apps-android-commons-5947 | commons-app | apps-android-commons | 5,947 | closed | Fix unit tests | **Description (required)**
Fixes #5945 #5921
What changes did you make and why?
1. Move **`createLocale()`** method to companion object in `SettingsFragment`. In Java, that method was previously defined as **static**, making it easier to access from `SettingsFragmentUnitTest`. Also, added the `Mockk` dependency... | {
"label": "commons-app:main",
"ref": "main",
"sha": "fe347c21fdede145e6a945750aa43a6de7ec24eb"
} | [
{
"number": 5945,
"title": "`Unresolved reference: mockk` when running unit tests",
"body": "```\r\n> Task :app:compileBetaDebugUnitTestKotlin FAILED\r\ne: app/src/test/kotlin/fr/free/nrw/commons/actions/ThanksClientTest.kt:7:11 Unresolved reference: mockk\r\ne: app/src/test/kotlin/fr/free/nrw/commons/a... | kotlin | `Unresolved reference: mockk` when running unit tests
```
> Task :app:compileBetaDebugUnitTestKotlin FAILED
e: app/src/test/kotlin/fr/free/nrw/commons/actions/ThanksClientTest.kt:7:11 Unresolved reference: mockk
e: app/src/test/kotlin/fr/free/nrw/commons/actions/ThanksClientTest.kt:8:11 Unresolved reference: mockk
... | Adding this dependency `testImplementation("io. mockk:mockk:1.13.5")` fixed the problem but got another import issue from SettingsFragment. This is causing a build failure. I am looking into it.
Well, I fixed it. Please assign me so that I can create a PR :) | https://github.com/commons-app/apps-android-commons/pull/5947 | [
"https://github.com/commons-app/apps-android-commons/issues/5945"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.upload.UploadMediaPresenterTest" --tests "fr.free.nrw.commons.recentlanguages.RecentLanguagesDaoUnitTest" --tests "fr.free.nrw.commons.upload.structure.depictions.DepictedItemTest" --tests "fr.free.nrw.commons.auth.LoginActivityUnitTests" --tests "fr.fre... | diff --git a/app/build.gradle b/app/build.gradle
index 9e6c56c83f..468255d38c 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -98,6 +98,7 @@ dependencies {
testImplementation 'org.mockito:mockito-core:5.6.0'
testImplementation "org.powermock:powermock-module-junit4:2.0.9"
testImplementation "org.... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/auth/LoginActivityUnitTests.kt b/app/src/test/kotlin/fr/free/nrw/commons/auth/LoginActivityUnitTests.kt
index b50c820a0d..162f505848 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/auth/LoginActivityUnitTests.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/auth... | {
"fr.free.nrw.commons.auth.SessionManagerUnitTests.testLogout": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.recentlanguages.RecentLanguagesDaoUnitTest.testAddNewLanguage": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.upload.structur... | {} | {} | {} |
commons-app__apps-android-commons-5875 | commons-app | apps-android-commons | 5,875 | closed | Use new result API | Fixes #5849
What changes did you make and why?
- Migrate Activities that are launched with expectancy of getting result back, to new result api.
#### For ease of review, these are the functionalities that are affected and have been tested.
- File picking -> Camera, Gallery, Custom; from every place one or... | {
"label": "commons-app:main",
"ref": "main",
"sha": "f1205c19be7dccefc2b65f4d4c95bfb36c06c23c"
} | [
{
"number": 5849,
"title": "[Tech Debt] Remove usage of deprecated `startActivityForResult` & `onActivityResult` APIs in favour of decoupled result APIs",
"body": "Remove usage of deprecated `startActivityForResult` & `onActivityResult` APIs in favour of decoupled result APIs. \r\n\r\n> While the unde... | kotlin | [Tech Debt] Remove usage of deprecated `startActivityForResult` & `onActivityResult` APIs in favour of decoupled result APIs
Remove usage of deprecated `startActivityForResult` & `onActivityResult` APIs in favour of decoupled result APIs.
> While the underlying [startActivityForResult()](https://developer.android... | null | https://github.com/commons-app/apps-android-commons/pull/5875 | [
"https://github.com/commons-app/apps-android-commons/issues/5849"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.upload.UploadActivityUnitTests" --tests "fr.free.nrw.commons.media.MediaDetailFragmentUnitTests" --tests "fr.free.nrw.commons.upload.mediaDetails.UploadMediaDetailFragmentUnitTest" --tests "fr.free.nrw.commons.contributions.MainActivityUnitTests" --tests... | diff --git a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
index c3dde9caa7..3aceb957ab 100644
--- a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
+++ b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
@@ -107,7... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/contributions/MainActivityUnitTests.kt b/app/src/test/kotlin/fr/free/nrw/commons/contributions/MainActivityUnitTests.kt
index a2eb41615a..780322603a 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/contributions/MainActivityUnitTests.kt
+++ b/app/src/test/kotlin/... | {
"fr.free.nrw.commons.upload.mediaDetails.UploadMediaDetailFragmentUnitTest.testRememberedZoomLevelOnNull": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.upload.UploadMediaDetailAdapterUnitTest.testRemoveDescription": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"... | {} | {} | {} |
commons-app__apps-android-commons-5851 | commons-app | apps-android-commons | 5,851 | closed | Refactor `FilePicker.java` intent result handling | Fixes #5850
What changes did you make and why?
- Removed `CAPTURE_VIDEO` request code and it's checks, while from what I can understand we do not handle video mime type. Though if I missed something and I'm wrong please let me know, happy to make changes.
- Removed Video's picker test cases.
- Only Gallery ... | {
"label": "commons-app:main",
"ref": "main",
"sha": "95e0a0d143725ebb3079222c3fbb8dca3cff129a"
} | [
{
"number": 5850,
"title": "Remove unnecessary request code checks while handling file picker results",
"body": "While working on #5849, I saw, there are some problems with handling request codes in `FilePicker.java` \r\n\r\nI chose not to include these changes in the refactor (refer #5849) because thes... | kotlin | Remove unnecessary request code checks while handling file picker results
While working on #5849, I saw, there are some problems with handling request codes in `FilePicker.java`
I chose not to include these changes in the refactor (refer #5849) because these are distinct changes which should be addressed separately... | null | https://github.com/commons-app/apps-android-commons/pull/5851 | [
"https://github.com/commons-app/apps-android-commons/issues/5850"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.filepicker.FilePickerTest" | diff --git a/app/src/main/java/fr/free/nrw/commons/filepicker/Constants.java b/app/src/main/java/fr/free/nrw/commons/filepicker/Constants.java
index 3c9299c1aa..f907f0a014 100644
--- a/app/src/main/java/fr/free/nrw/commons/filepicker/Constants.java
+++ b/app/src/main/java/fr/free/nrw/commons/filepicker/Constants.java
@... | diff --git a/app/src/test/kotlin/fr/free/nrw/commons/filepicker/FilePickerTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/filepicker/FilePickerTest.kt
index 171e04b4e0..365af27f03 100644
--- a/app/src/test/kotlin/fr/free/nrw/commons/filepicker/FilePickerTest.kt
+++ b/app/src/test/kotlin/fr/free/nrw/commons/filepicker... | {
"fr.free.nrw.commons.filepicker.FilePickerTest.testHandleActivityResultCaseOne": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.filepicker.FilePickerTest.testRestoreType": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.filepicker.FilePi... | {
"fr.free.nrw.commons.filepicker.FilePickerTest.testCreateCameraForImageIntent": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"fr.free.nrw.commons.filepicker.FilePickerTest.testIsPhoto": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
commons-app__apps-android-commons-5833 | commons-app | apps-android-commons | 5,833 | closed | Issue-5662-kotlinstyle | Fixes #5662
- Bulk automated formatting updates on the code base using ktLint --format
- Multiple manual changes to meet ktLint standard rules including:
- removal of wildcard imports (standard:no-wildcard-imports)
- successive KDOC comments (standard:no-consecutive-comments)
- unexpected indentation (standard:i... | {
"label": "commons-app:main",
"ref": "main",
"sha": "950539c55c26881bcc2f148e5ffe3f2b0be2c45e"
} | [
{
"number": 5662,
"title": "Fix 119 minor Kotlin styling error",
"body": "```\r\njava/fr/free/nrw/commons/AboutActivityTest.kt:130:26 Missing newline after \"(\"\r\njava/fr/free/nrw/commons/AboutActivityTest.kt:130:45 Argument should be on a separate line (unless all arguments can fit a single line)\r\n... | kotlin | Fix 119 minor Kotlin styling error
```
java/fr/free/nrw/commons/AboutActivityTest.kt:130:26 Missing newline after "("
java/fr/free/nrw/commons/AboutActivityTest.kt:130:45 Argument should be on a separate line (unless all arguments can fit a single line)
java/fr/free/nrw/commons/AboutActivityTest.kt:130:45 Missing ne... | @nicolas-raoul Can we fix all this in one pr? I would like to take it up.
@neeldoshii I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)
@nicolas-raoul are you looking to just fix the formatting in the files listed in th... | https://github.com/commons-app/apps-android-commons/pull/5833 | [
"https://github.com/commons-app/apps-android-commons/issues/5662"
] | ./gradlew :app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.quiz.QuizControllerTest" --tests "fr.free.nrw.commons.utils.FileUtilsTest" --tests "fr.free.nrw.commons.auth.login.UserExtendedInfoClientTest" --tests "fr.free.nrw.commons.contributions.ContributionsPresenterTest" --tests "fr.free.nrw.commons.description... | diff --git a/app/src/main/java/fr/free/nrw/commons/BaseMarker.kt b/app/src/main/java/fr/free/nrw/commons/BaseMarker.kt
index 277faea841..1daadb5a16 100644
--- a/app/src/main/java/fr/free/nrw/commons/BaseMarker.kt
+++ b/app/src/main/java/fr/free/nrw/commons/BaseMarker.kt
@@ -39,26 +39,25 @@ class BaseMarker {
const... | diff --git a/app/src/androidTest/java/fr/free/nrw/commons/AboutActivityTest.kt b/app/src/androidTest/java/fr/free/nrw/commons/AboutActivityTest.kt
index 9425a1d476..b5a752ef90 100644
--- a/app/src/androidTest/java/fr/free/nrw/commons/AboutActivityTest.kt
+++ b/app/src/androidTest/java/fr/free/nrw/commons/AboutActivityT... | {
"fr.free.nrw.commons.bookmarks.items.BookmarkItemsDaoTest.createTable": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.utils.LengthUtilsTest.testBearingRandomPoints": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"fr.free.nrw.commons.review.ReviewActivityT... | {} | {} | {} |
element-hq__element-x-android-5622 | element-hq | element-x-android | 5,622 | closed | Add ability to forward a media from the media viewer and the gallery | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add ability to forward a media from the media viewer and the gallery.
First commit extract the fo... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "1aaf363f5f5595cf77729a95a23cafb54efaefd8"
} | [
{
"number": 5454,
"title": "[Task] Add the Forward option to the info sheet in Media and Files",
"body": "Please see and discuss the details in the meta issue.\n\n[Figma](https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline--new-?node-id=1732-80010&t=6BlabuIHijm3tqKP-0)\n\nThis sheet is displaye... | kotlin | [Task] Add the Forward option to the info sheet in Media and Files
Please see and discuss the details in the meta issue.
[Figma](https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline--new-?node-id=1732-80010&t=6BlabuIHijm3tqKP-0)
This sheet is displayed in 2 places
- [x] Gallery
- [x] Media full screen
| null | https://github.com/element-hq/element-x-android/pull/5622 | [
"https://github.com/element-hq/element-x-android/issues/5454"
] | ./gradlew :libraries:mediaviewer:impl:testDebugUnitTest --tests "io.element.android.libraries.mediaviewer.impl.viewer.MediaViewerPresenterTest" --tests "io.element.android.libraries.mediaviewer.impl.DefaultMediaViewerEntryPointTest" --tests "io.element.android.libraries.mediaviewer.impl.gallery.MediaGalleryPresenterTes... | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt b/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt
index eb1df5643ef..da09add2dc5 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt
+++ b/appnav/src/main/kotlin/io/element/android/appnav... | diff --git a/appnav/src/test/kotlin/io/element/android/appnav/JoinedRoomLoadedFlowNodeTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/JoinedRoomLoadedFlowNodeTest.kt
index f8a18fa24a0..8e73165cb6c 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/JoinedRoomLoadedFlowNodeTest.kt
+++ b/appnav/src/t... | {
"io.element.android.libraries.mediaviewer.impl.viewer.MediaViewerPresenterTest.present - snackbar displayed when there is no more items forward images and videos": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.mediaviewer.impl.gallery.MediaGalleryPresenterTest.prese... | {} | {} | {} |
element-hq__element-x-android-5498 | element-hq | element-x-android | 5,498 | closed | Filter out direct room in the leave space screen. | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Filter out direct room in the leave space screen.
## Motivation and context
<!-- Provide link ... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "dbc0c42e312ed3aaafc01232c48b26f724c0d044"
} | [
{
"number": 5496,
"title": "Leave space: DMs should not be displayed in the list",
"body": "In the first iteration, we consider DMs important rooms we do not want to leave."
}
] | kotlin | Leave space: DMs should not be displayed in the list
In the first iteration, we consider DMs important rooms we do not want to leave.
| null | https://github.com/element-hq/element-x-android/pull/5498 | [
"https://github.com/element-hq/element-x-android/issues/5496"
] | ./gradlew :features:space:impl:testDebugUnitTest --tests "io.element.android.features.space.impl.leave.LeaveSpacePresenterTest" | diff --git a/features/space/impl/src/main/kotlin/io/element/android/features/space/impl/leave/LeaveSpacePresenter.kt b/features/space/impl/src/main/kotlin/io/element/android/features/space/impl/leave/LeaveSpacePresenter.kt
index 31271104a31..19e593bf7c0 100644
--- a/features/space/impl/src/main/kotlin/io/element/androi... | diff --git a/features/space/impl/src/test/kotlin/io/element/android/features/space/impl/leave/LeaveSpacePresenterTest.kt b/features/space/impl/src/test/kotlin/io/element/android/features/space/impl/leave/LeaveSpacePresenterTest.kt
index 81920dd0f22..3d123f3f41c 100644
--- a/features/space/impl/src/test/kotlin/io/elemen... | {
"io.element.android.features.space.impl.leave.LeaveSpacePresenterTest.present - initial state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.space.impl.leave.LeaveSpacePresenterTest.present - current space name and is last admin": {
"run": "PASS",
"test": "N... | {
"io.element.android.features.space.impl.leave.LeaveSpacePresenterTest.present - leave space and sub rooms": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.features.space.impl.leave.LeaveSpacePresenterTest.present - fail to load rooms": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
element-hq__element-x-android-5320 | element-hq | element-x-android | 5,320 | closed | Space list | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Allow navigation in the Space hierarchy, including ending up opening rooms.
Note: the branch `fea... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "7e0931c299774b4fdb668bc17c3fcb3c5f1ac215"
} | [
{
"number": 5125,
"title": "[Task] Create a SpaceList screen.",
"body": "This is the top-level screen shown in the Spaces tab.\n\nPlease see and discuss the details in the meta issue.\n"
}
] | kotlin | [Task] Create a SpaceList screen.
This is the top-level screen shown in the Spaces tab.
Please see and discuss the details in the meta issue.
| null | https://github.com/element-hq/element-x-android/pull/5320 | [
"https://github.com/element-hq/element-x-android/issues/5125"
] | ./gradlew :libraries:matrix:impl:testDebugUnitTest --tests "io.element.android.libraries.matrix.impl.spaces.SpaceRoomCacheTest" --tests "io.element.android.libraries.matrix.impl.fixtures.factories.SpaceRoom" --tests "io.element.android.libraries.matrix.impl.spaces.RoomSummaryListProcessorTest" --tests "io.element.andro... | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt b/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt
index 2d08d5f6f5c..97fff8ee5c2 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt
+++ b/appnav/src/main/kotlin/io/element/android/appnav... | diff --git a/features/space/impl/src/test/kotlin/io/element/android/features/space/impl/SpacePresenterTest.kt b/features/space/impl/src/test/kotlin/io/element/android/features/space/impl/SpacePresenterTest.kt
new file mode 100644
index 00000000000..0bcd1303ae9
--- /dev/null
+++ b/features/space/impl/src/test/kotlin/io/... | {
"io.element.android.libraries.matrix.impl.spaces.RoomSummaryListProcessorTest.Remove removes an entry at some index": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.matrix.impl.spaces.RoomSummaryListProcessorTest.Clear removes all the entries": {
"run": "NONE",
... | {} | {} | {} |
element-hq__element-x-android-5161 | element-hq | element-x-android | 5,161 | closed | Move push history entry point from notification settings to developer settings |
<!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Move push history entry point from notification settings to developer settings
## Motivation an... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "516c3cfda36d7158405dadbb0ff573e7e7db1618"
} | [
{
"number": 5159,
"title": "Move the Push history screen to Developer options",
"body": "The Push history is a developer focused screen. It is very technical and needs good knowledge of the Matrix protocol and push rules to use it. It is expected to have errors there like for unread pushes pushes for ex... | kotlin | Move the Push history screen to Developer options
The Push history is a developer focused screen. It is very technical and needs good knowledge of the Matrix protocol and push rules to use it. It is expected to have errors there like for unread pushes pushes for example. As developers, we cannot expect non tech people ... | null | https://github.com/element-hq/element-x-android/pull/5161 | [
"https://github.com/element-hq/element-x-android/issues/5159"
] | ./gradlew :features:preferences:impl:testDebugUnitTest --tests "io.element.android.features.preferences.impl.developer.DeveloperSettingsViewTest" --tests "io.element.android.features.preferences.impl.notifications.NotificationSettingsViewTest" | diff --git a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/PreferencesFlowNode.kt b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/PreferencesFlowNode.kt
index 234b4c683b0..b38b835f362 100644
--- a/features/preferences/impl/src/main/kotlin... | diff --git a/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/developer/DeveloperSettingsViewTest.kt b/features/preferences/impl/src/test/kotlin/io/element/android/features/preferences/impl/developer/DeveloperSettingsViewTest.kt
index 5d0030af8e0..f10fdc93c46 100644
--- a/features/... | {
"io.element.android.features.preferences.impl.developer.DeveloperSettingsViewTest.clicking on push history notification invokes the expected callback": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.preferences.impl.developer.DeveloperSettingsViewTest.clicking on log ... | {} | {} | {} |
element-hq__element-x-android-5160 | element-hq | element-x-android | 5,160 | closed | Remove old feature flags | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Remove a bunch of feature flags.
Can be reviewed commit per commit.
<del>Draft as I spot a regre... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "516c3cfda36d7158405dadbb0ff573e7e7db1618"
} | [
{
"number": 5154,
"title": "Clean up feature flags",
"body": "When we are actively developing a feature, we start by creating a feature flag so that users do not have access to the WIP. The list of feature flags has increased a lot and we have a way to make the flag not visible in the developer setting ... | kotlin | Clean up feature flags
When we are actively developing a feature, we start by creating a feature flag so that users do not have access to the WIP. The list of feature flags has increased a lot and we have a way to make the flag not visible in the developer setting screen, which is used. But now we want to go further an... | For information, here are the flags on EXI:
<img width="282" height="1141" alt="Image" src="https://github.com/user-attachments/assets/58f12155-be5c-48c3-ac54-3fc3e5125e1a" /> | https://github.com/element-hq/element-x-android/pull/5160 | [
"https://github.com/element-hq/element-x-android/issues/5154"
] | ./gradlew :appnav:testDebugUnitTest --tests "io.element.android.appnav.RootPresenterTest" :features:login:impl:testDebugUnitTest --tests "io.element.android.features.login.impl.screens.onboarding.OnBoardingPresenterTest" :features:home:impl:testDebugUnitTest --tests "io.element.android.features.home.impl.roomlist.RoomL... | diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index ef6bda9ebc2..34a8fe31f50 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -147,14 +147,6 @@
<data android:host="user" />
<data android:host="room" />
... | diff --git a/appnav/src/test/kotlin/io/element/android/appnav/RootPresenterTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/RootPresenterTest.kt
index 6d0878d812d..4c8b2a803d7 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/RootPresenterTest.kt
+++ b/appnav/src/test/kotlin/io/element/android/app... | {
"io.element.android.features.messages.impl.pinned.list.PinnedMessagesListPresenterTest.present - initial state": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.attachments.AttachmentsPreviewPresenterTest.present - dismissing the progress dialog stops med... | {} | {
"io.element.android.features.roomdetails.impl.RoomDetailsPresenterTest.present - initial state is updated with a new roomInfo": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.features.messages.impl.MessagesPresenterTest.present - room with successor room includes successor inf... | {} |
element-hq__element-x-android-4845 | element-hq | element-x-android | 4,845 | closed | Add a banner to ask the user to disable battery optimization when Event cannot be resolved from Push | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
When an Event cannot be resolved from Push, let the application render a banner in the room list to ... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "fd8fce04c44ea113e9c3ea8d306909a3e107eee0"
} | [
{
"number": 4611,
"title": "Add check/info to disable battery optimization to F-Droid-build's notification settings/troubleshooter",
"body": "### Your use case\n\n#### What would you like to do?\n\nHave a reminder or test if battery optimization is set to \"unrestricted\" in Element X F-Droid build's no... | kotlin | Add check/info to disable battery optimization to F-Droid-build's notification settings/troubleshooter
### Your use case
#### What would you like to do?
Have a reminder or test if battery optimization is set to "unrestricted" in Element X F-Droid build's notification settings/troubleshooter.
#### Why would you like ... | null | https://github.com/element-hq/element-x-android/pull/4845 | [
"https://github.com/element-hq/element-x-android/issues/4611"
] | ./gradlew :libraries:push:impl:testDebugUnitTest --tests "io.element.android.libraries.push.impl.battery.AndroidBatteryOptimizationTest" --tests "io.element.android.libraries.push.impl.push.DefaultPushHandlerTest" --tests "io.element.android.libraries.push.impl.battery.BatteryOptimizationPresenterTest" :libraries:fulls... | diff --git a/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsView.kt b/features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/notifications/NotificationSettingsView.kt
index 8f2543c161f..f73fecaf3c4 100644
--- a/fea... | diff --git a/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTest.kt b/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTest.kt
index 446a864f0b7..3184a44a1cd 100644
--- a/features/roomlist/impl/src/test/kotlin/io/element... | {
"io.element.android.libraries.push.impl.battery.AndroidBatteryOptimizationTest.in case of 1 error, requestDisablingBatteryOptimization returns true": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
}
} | {
"io.element.android.libraries.fullscreenintent.test.FullScreenIntentPermissionsPresenterTest.shouldDisplay - is false if permission is granted": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.battery.AndroidBatteryOptimizationTest.in case of 2 errors, reque... | {
"io.element.android.libraries.push.impl.push.DefaultPushHandlerTest.when ringing call PushData is received, the incoming call will be handled": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.features.roomlist.impl.RoomListPresenterTest.present - should start with no user and t... | {} |
element-hq__element-x-android-4752 | element-hq | element-x-android | 4,752 | closed | Add support for login link | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add support for login link
## Motivation and context
<!-- Provide link to the corresponding is... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "e50dfa944aae40f473a14048d86a541ff5a99bc4"
} | [
{
"number": 4705,
"title": "[Task] Deeplink to specify account provider & user",
"body": "Please see and discuss the details in the meta issue.\n"
},
{
"number": 4074,
"title": "Multiple \"instances\" open when sharing media",
"body": "### Steps to reproduce\r\n\r\nFirst I mainly use Sch... | kotlin | [Task] Deeplink to specify account provider & user
Please see and discuss the details in the meta issue.
Multiple "instances" open when sharing media
### Steps to reproduce
First I mainly use SchildiChat Next, but I also tested it with element x, and the issue there still persists.
When sharing media via other a... | https://github.com/element-hq/element-x-android/pull/4752 | [
"https://github.com/element-hq/element-x-android/issues/4705",
"https://github.com/element-hq/element-x-android/issues/4074"
] | ./gradlew :features:login:impl:testDebugUnitTest --tests "io.element.android.features.login.impl.screens.onboarding.OnBoardingPresenterTest" --tests "io.element.android.features.login.impl.DefaultLoginIntentResolverTest" --tests "io.element.android.features.login.impl.screens.confirmaccountprovider.ConfirmAccountProvid... | diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index c26c9a5a513..6619603f937 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -34,11 +34,17 @@
android:value='androidx.startup' />
</provider>
+ <!--
+ Usin... | diff --git a/appnav/src/test/kotlin/io/element/android/appnav/intent/IntentResolverTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/intent/IntentResolverTest.kt
index 46c54a98d04..3fe9a9b728e 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/intent/IntentResolverTest.kt
+++ b/appnav/src/test/kotli... | {} | {
"io.element.android.features.login.impl.screens.confirmaccountprovider.ConfirmAccountProviderPresenterTest.present - confirm account creation with oidc is successful": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.features.login.impl.screens.confirmaccountprovider.ConfirmAcco... | {
"io.element.android.appnav.intent.IntentResolverTest.test resolve invalid": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.appnav.intent.IntentResolverTest.test resolve login param": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.features... | {} | |
element-hq__element-x-android-4683 | element-hq | element-x-android | 4,683 | closed | Disable mutliple click (parallel or serial) on a room | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add minimum delay between two click handling on the room list.
Protect:
- opening the setting
- o... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "390337c426939335c4b066a5dbab88c5f1b25f93"
} | [
{
"number": 4619,
"title": "It's possible to open a room view twice by tapping it super quickly",
"body": "### Steps to reproduce\n\nFrom the room list, tap the same room name twice super quickly.\n\n### Outcome\n\n#### What did you expect?\n\nThe room view to open only once.\n\n#### What happened inste... | kotlin | It's possible to open a room view twice by tapping it super quickly
### Steps to reproduce
From the room list, tap the same room name twice super quickly.
### Outcome
#### What did you expect?
The room view to open only once.
#### What happened instead?
The room view has opened twice: if I press return/back, then... | Additionally, it's possible to open multiple rooms by tapping on several rooms at the same time. | https://github.com/element-hq/element-x-android/pull/4683 | [
"https://github.com/element-hq/element-x-android/issues/4619"
] | ./gradlew :features:roomlist:impl:testDebugUnitTest --tests "io.element.android.features.roomlist.impl.RoomListViewTest" :libraries:androidutils:testDebugUnitTest --tests "io.element.android.libraries.androidutils.throttler.FirstThrottlerTest" | diff --git a/features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListView.kt b/features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListView.kt
index 016cc4d116b..b00796c1fed 100644
--- a/features/roomlist/impl/src/main/kotlin/io/element/android/features/... | diff --git a/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListViewTest.kt b/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListViewTest.kt
index ee4cc0b5642..0242591f55b 100644
--- a/features/roomlist/impl/src/test/kotlin/io/element/android/f... | {
"io.element.android.features.roomlist.impl.RoomListViewTest.clicking on continue recovery key banner invokes the expected callback": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.roomlist.impl.RoomListViewTest.clicking on a room twice invokes the expected callback on... | {
"io.element.android.features.roomlist.impl.RoomListViewTest.long clicking on a room emits the expected Event": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.features.roomlist.impl.RoomListViewTest.clicking on close setup key banner emits the expected Event": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.features.roomlist.impl.RoomListViewTest.clicking on continue setup key banner invokes the expected callback"... | {} |
element-hq__element-x-android-4635 | element-hq | element-x-android | 4,635 | closed | Render caller avatar on Incoming call screen | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
Ensure that the image loader is set, else the IncomingCallActivity will not be able to render the avatar.
<!-- Describe shortly what has been change... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "76e1612e74051ea4c96dd305908424a67fec5e09"
} | [
{
"number": 4629,
"title": "EC 1:1 incoming call: still displayed in light color under certain conditions.",
"body": "### Steps to reproduce\n\n1. If EXA is running, kill it first;\n2. Start EXA, then remove it from the recent tasks list (make sure EXA disables battery optimization and allows running in... | kotlin | EC 1:1 incoming call: still displayed in light color under certain conditions.
### Steps to reproduce
1. If EXA is running, kill it first;
2. Start EXA, then remove it from the recent tasks list (make sure EXA disables battery optimization and allows running in the background);
3. Lock the phone (the screen needs to b... | Hello @YamatoRyou , I cannot reproduce this issue on my device, nor on my emulator, both running Android 15 OS.
Do you have more details to provide?
But I have discovered this issue, which is related to this screen: #4633
> Hello [@YamatoRyou](https://github.com/YamatoRyou) , I cannot reproduce this issue on my devic... | https://github.com/element-hq/element-x-android/pull/4635 | [
"https://github.com/element-hq/element-x-android/issues/4629",
"https://github.com/element-hq/element-x-android/issues/4633"
] | ./gradlew :features:call:impl:testDebugUnitTest --tests "io.element.android.features.call.utils.DefaultActiveCallManagerTest" | diff --git a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt
index 59e19d3fe2f..8804a91f79f 100644
--- a/features/call/impl/src/main/kotlin/io/element/android/feature... | diff --git a/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/DefaultActiveCallManagerTest.kt b/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/DefaultActiveCallManagerTest.kt
index 5f7309344a4..2059e9836e4 100644
--- a/features/call/impl/src/test/kotlin/io/element/and... | {
"io.element.android.features.call.utils.DefaultActiveCallManagerTest.observeRingingCalls - will cancel the active ringing call if the call is cancelled": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
}
} | {
"io.element.android.features.call.utils.DefaultActiveCallManagerTest.hungUpCall - removes existing call if the CallType matches": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.features.call.utils.DefaultActiveCallManagerTest.joinedCall - register an ongoing call and tries sen... | {} | {} |
element-hq__element-x-android-4553 | element-hq | element-x-android | 4,553 | closed | Update wording for push provider support test. (#4079) | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Update wording of the notification test about push provider support.
The text is quite similar, so ... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "20ac0f90e4a585393df802f2d32554c73fdad904"
} | [
{
"number": 4079,
"title": "Firebase Error on LineageOS",
"body": "### Steps to reproduce\r\n\r\n1. Install Element X on a LineageOS mobile phone\r\n2. Start it and login to your homeserver\r\n3. After logging in, an error appears that push notifications might not be available because of \"other error\"... | kotlin | Firebase Error on LineageOS
### Steps to reproduce
1. Install Element X on a LineageOS mobile phone
2. Start it and login to your homeserver
3. After logging in, an error appears that push notifications might not be available because of "other error"
4. Click on "Settings" and click on "Fix" (i translated them my... | Yes, so what is the exact problem? If you have LineageOS without google apps installed, there will be no Google push available. If you do have the whole Google shebang installed, it should be working.
It says firebase is available and a line below it says firebase not available. My assumption is that the text is mislea... | https://github.com/element-hq/element-x-android/pull/4553 | [
"https://github.com/element-hq/element-x-android/issues/4079"
] | ./gradlew :libraries:push:impl:testDebugUnitTest --tests "io.element.android.libraries.push.impl.troubleshoot.PushProvidersTestTest" | diff --git a/libraries/push/impl/src/main/res/values/localazy.xml b/libraries/push/impl/src/main/res/values/localazy.xml
index 5c6c852f145..9860c8bef7f 100644
--- a/libraries/push/impl/src/main/res/values/localazy.xml
+++ b/libraries/push/impl/src/main/res/values/localazy.xml
@@ -58,13 +58,14 @@
<string name="troubl... | diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushProvidersTest.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushProvidersTest.kt
index d75c4f4d590..5a30db6f59e 100644
--- a/libraries/push/impl/src/main/kotlin/io/elem... | {
"io.element.android.libraries.push.impl.troubleshoot.PushProvidersTestTest.test PushProvidersTest with 2 push providers": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.troubleshoot.PushProvidersTestTest.test PushProvidersTest with empty list": {
"run":... | {} | {} | {} |
element-hq__element-x-android-4301 | element-hq | element-x-android | 4,301 | closed | Preload account urls | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Preload account management URL into SDK memory cache.
## Motivation and context
<!-- Provide l... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "1a7a8a860a3911bda5afb325b0613b10e64e4764"
} | [
{
"number": 4300,
"title": "[Task] Preload account management URLs",
"body": "A memory cache has been implemented in the SDK. See https://github.com/matrix-org/matrix-rust-sdk/pull/4663\n\nWe need the application to pre-load the 2 accounts management URLs to populate the in-memory cache. That way, when ... | kotlin | [Task] Preload account management URLs
A memory cache has been implemented in the SDK. See https://github.com/matrix-org/matrix-rust-sdk/pull/4663
We need the application to pre-load the 2 accounts management URLs to populate the in-memory cache. That way, when the user open the settings, the flickering will not be ob... | null | https://github.com/element-hq/element-x-android/pull/4301 | [
"https://github.com/element-hq/element-x-android/issues/4300"
] | ./gradlew :features:preferences:impl:testDebugUnitTest --tests "io.element.android.features.preferences.impl.root.PreferencesRootPresenterTest" :appnav:testDebugUnitTest --tests "io.element.android.appnav.loggedin.LoggedInPresenterTest" | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInPresenter.kt b/appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInPresenter.kt
index 2539f9e1d54..fbecfeb60b8 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/loggedin/LoggedInPresenter.kt
+++ b/appnav/src/main/ko... | diff --git a/appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt
index bfd416eaf3a..aac40e000ce 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt
+++ b/appnav... | {
"io.element.android.appnav.loggedin.LoggedInPresenterTest.present - ensure that account urls are preloaded": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.appnav.loggedin.LoggedInPresenterTest.present - CheckSlidingSyncProxyAvailability forces the sliding sync migration under... | {
"io.element.android.appnav.loggedin.LoggedInPresenterTest.present - report crypto status analytics": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.features.preferences.impl.root.PreferencesRootPresenterTest.present - developer settings is hidden by default in release builds": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.features.preferences.impl.root.PreferencesRootPresenterTest.present - initial st... | {} |
element-hq__element-x-android-4209 | element-hq | element-x-android | 4,209 | closed | Consider that the topic of a room has been removed when it's blank. | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
## Motivation and context
<!-- Provide link to the corresponding issue if applicable or explain... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "ebfb47ed03f60c6ec828577ebb4bbf9b179f8e62"
} | [
{
"number": 4206,
"title": "[Task] Show a blank topic as removed in the state event.",
"body": "Please see and discuss the details in the meta issue (this fixes Problem 2)."
}
] | kotlin | [Task] Show a blank topic as removed in the state event.
Please see and discuss the details in the meta issue (this fixes Problem 2).
| null | https://github.com/element-hq/element-x-android/pull/4209 | [
"https://github.com/element-hq/element-x-android/issues/4206"
] | ./gradlew :libraries:eventformatter:impl:testDebugUnitTest --tests "io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest" | diff --git a/libraries/eventformatter/impl/src/main/kotlin/io/element/android/libraries/eventformatter/impl/StateContentFormatter.kt b/libraries/eventformatter/impl/src/main/kotlin/io/element/android/libraries/eventformatter/impl/StateContentFormatter.kt
index 493f5b1584e..3f0f4a1dc29 100644
--- a/libraries/eventformat... | diff --git a/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultRoomLastMessageFormatterTest.kt b/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultRoomLastMessageFormatterTest.kt
index 7090b2467b5..11b809258e9 100644... | {} | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Room state change - room topic": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Unable to decrypt content": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Membership change - knocked": {
"run": "PASS",... | {} |
element-hq__element-x-android-4205 | element-hq | element-x-android | 4,205 | closed | Add ability to swipe between media when opened from the timeline. | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add ability to swipe between media when open from the timeline. Previously it was only possible to s... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "9e5c5fa48a95940d3813c04d99c3e9720cfe61de"
} | [
{
"number": 1484,
"title": "Add capability to swipe through images in a chat.",
"body": "### Your use case\r\n\r\n#### What would you like to do?\r\nWhen viewing a image I would like to be able to swipe left/right to see the previous/next image.\r\n#### Why would you like to do it?\r\nTo be able to quic... | kotlin | Add capability to swipe through images in a chat.
### Your use case
#### What would you like to do?
When viewing a image I would like to be able to swipe left/right to see the previous/next image.
#### Why would you like to do it?
To be able to quickly watch and download multiple images.
#### How would you like ... | https://github.com/element-hq/element-x-android/pull/4205 | [
"https://github.com/element-hq/element-x-android/issues/1484",
"https://github.com/element-hq/element-x-android/issues/4174"
] | ./gradlew :libraries:mediaviewer:impl:testDebugUnitTest --tests "io.element.android.libraries.mediaviewer.impl.model.GroupedMediaItemsTest" --tests "io.element.android.libraries.mediaviewer.impl.gallery.MediaGalleryPresenterTest" --tests "io.element.android.libraries.mediaviewer.impl.viewer.SingleMediaGalleryDataSource... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesFlowNode.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesFlowNode.kt
index f9d9bbf27f0..6b84423d44f 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android/f... | diff --git a/libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/TestData.kt b/libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/TestData.kt
index 1946d2259bc..509fac833c3 100644
--- a/libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/... | {
"io.element.android.libraries.mediaviewer.impl.gallery.MediaGalleryPresenterTest.present - delete bottom sheet": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.mediaviewer.impl.gallery.MediaGalleryPresenterTest.present - change mode": {
"run": "PASS",
"test":... | {} | {
"io.element.android.tests.konsist.KonsistClassNameTest.Class implementing interface should have name not end with 'Impl' but start with 'Default'": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.tests.konsist.KonsistClassNameTest.Classes extending 'Node' should have 'Node' suf... | {} | |
element-hq__element-x-android-4195 | element-hq | element-x-android | 4,195 | closed | Fix snack bar not displayed in MediaViewer | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
The SnackBar was not displayed in the MediaViewer because it's in a Node which is displayed in Overl... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "3668e861f7535274d5ebe06b176d0b1b655bbe7f"
} | [
{
"number": 4128,
"title": "Downloading currently gives no feedback if it started or if it is finished",
"body": "### Your use case\n\n#### What would you like to do?\r\n\r\nCurrently EX is missing any indication that download has started/finished and it would suit to have some sort of information \r\n\... | kotlin | Downloading currently gives no feedback if it started or if it is finished
### Your use case
#### What would you like to do?
Currently EX is missing any indication that download has started/finished and it would suit to have some sort of information
#### Why would you like to do it?
Element had it, element x... | null | https://github.com/element-hq/element-x-android/pull/4195 | [
"https://github.com/element-hq/element-x-android/issues/4128"
] | ./gradlew :libraries:mediaviewer:impl:testDebugUnitTest --tests "io.element.android.libraries.mediaviewer.impl.viewer.MediaViewerPresenterTest" | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInEventProcessor.kt b/appnav/src/main/kotlin/io/element/android/appnav/LoggedInEventProcessor.kt
index f3ca8b92346..2759e49f70a 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInEventProcessor.kt
+++ b/appnav/src/main/kotlin/io/elem... | diff --git a/libraries/mediaviewer/impl/src/test/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenterTest.kt b/libraries/mediaviewer/impl/src/test/kotlin/io/element/android/libraries/mediaviewer/impl/viewer/MediaViewerPresenterTest.kt
index ac0acfe7193..47e48ca9e15 100644
--- a/libraries/med... | {
"io.element.android.libraries.mediaviewer.impl.viewer.MediaViewerPresenterTest.present - load media": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.mediaviewer.impl.viewer.MediaViewerPresenterTest.present - view in timeline hide the bottom sheet and invokes the navi... | {} | {} | {} |
element-hq__element-x-android-4056 | element-hq | element-x-android | 4,056 | closed | Update message action list | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Reorder some items in the message action list and add a few test.
Also create a dedicated item to e... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "270fcb90291309d23d08f68efee74881708183ff"
} | [
{
"number": 4046,
"title": "Consider swapping the \"Pin\" and \"Edit\" message options",
"body": "### Your use case\n\n#### What would you like to do?\r\n\r\nHaving easy access to message features I use most often.\r\n\r\n#### Why would you like to do it?\r\n\r\nI edit messages way more than I pin them.... | kotlin | Consider swapping the "Pin" and "Edit" message options
### Your use case
#### What would you like to do?
Having easy access to message features I use most often.
#### Why would you like to do it?
I edit messages way more than I pin them. Therefore I believe it makes more sense for the "Edit" option to be clos... | @americanrefugee what do you think about this suggestion? I tend to agree with it. Please confirm before we take any action.
Order is coming from https://www.figma.com/design/ux3tYoZV9WghC7hHT9Fhk0/Compound-iOS-Components?node-id=2946-2392 and in the code [here](https://github.com/element-hq/element-x-android/blob/d... | https://github.com/element-hq/element-x-android/pull/4056 | [
"https://github.com/element-hq/element-x-android/issues/4046"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.pinned.list.PinnedMessagesListTimelineActionPostProcessorTest" --tests "io.element.android.features.messages.impl.actionlist.model.TimelineItemActionComparatorTest" --tests "io.element.android.features.messages.impl.a... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt
index 4895390ab87..5fc68a0c618 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
index 8cb7464a9ad..1369b5af635 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {
"io.element.android.features.messages.impl.actionlist.ActionListPresenterTest.present - compute for message from others redacted": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.MessagesPresenterTest.present - handle action reply to an image media messag... | {} | {} | {} |
element-hq__element-x-android-4026 | element-hq | element-x-android | 4,026 | closed | Implement month separator for the Gallery, and improve date rendering. | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Implement month separator for the Gallery.
Improve day separator rendering in the timeline.
Use To... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "5515c938d4f65c3dab2331ab96166d75dfd5869b"
} | [
{
"number": 2238,
"title": "Iterate on date rendering",
"body": "There are (at least) two places where timestamp is only rendered as time and date could be helpful.\r\n\r\n- [ ] In the message detail screen, when long clicking on a message. It can be helpful to have the date here, since when scrolling i... | kotlin | Iterate on date rendering
There are (at least) two places where timestamp is only rendered as time and date could be helpful.
- [ ] In the message detail screen, when long clicking on a message. It can be helpful to have the date here, since when scrolling in the timeline the date can be hard to see in room with lot... | Another weirdness I've noticed is in date rendering in the read receipts list. If a user sends a message at 23:59, 2 minutes later the receipt simply says "yesterday". It would be useful in that case to display an absolute timestamp until the relative time becomes significantly long enough in the past that the loss of ... | https://github.com/element-hq/element-x-android/pull/4026 | [
"https://github.com/element-hq/element-x-android/issues/2238"
] | ./gradlew :features:roomlist:impl:testDebugUnitTest --tests "io.element.android.features.roomlist.impl.search.RoomListSearchPresenterTest" --tests "io.element.android.features.roomlist.impl.RoomListPresenterTest" --tests "io.element.android.features.roomlist.impl.datasource.RoomListDataSourceTest" --tests "io.element.a... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesFlowNode.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesFlowNode.kt
index 3b5fb675405..6754f5c683d 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android/f... | diff --git a/.maestro/tests/roomList/createAndDeleteRoom.yaml b/.maestro/tests/roomList/createAndDeleteRoom.yaml
index ae6f5772c65..7cbf455ba23 100644
--- a/.maestro/tests/roomList/createAndDeleteRoom.yaml
+++ b/.maestro/tests/roomList/createAndDeleteRoom.yaml
@@ -30,5 +30,6 @@ appId: ${MAESTRO_APP_ID}
# assert there'... | {
"io.element.android.libraries.mediaviewer.impl.gallery.MediaGalleryPresenterTest.present - change mode": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.verifysession.impl.incoming.IncomingVerificationPresenterTest.present - incoming verification is remotely canceled":... | {} | {} | {} |
element-hq__element-x-android-3953 | element-hq | element-x-android | 3,953 | closed | Add feature flag to temporary disable sending caption by default in production | Closes #3950
Android friend of https://github.com/element-hq/element-x-ios/pull/3560 | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "8d26af5b269d43bb08cd38432b8db80b09a19463"
} | [
{
"number": 3950,
"title": "Add feature flag to disable caption sending / adding",
"body": "The legacy applications cannot render captions on the timeline, so we're going to add a temporary disabled feature flag.\r\n\r\nWhen the flag is off:\r\n- [x] hide the caption form on the media preview screen\r\n... | kotlin | Add feature flag to disable caption sending / adding
The legacy applications cannot render captions on the timeline, so we're going to add a temporary disabled feature flag.
When the flag is off:
- [x] hide the caption form on the media preview screen
- [x] hide the "Add caption" from the message menu
| null | https://github.com/element-hq/element-x-android/pull/3953 | [
"https://github.com/element-hq/element-x-android/issues/3950"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.actionlist.ActionListPresenterTest" --tests "io.element.android.features.messages.impl.attachments.AttachmentsPreviewPresenterTest" | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenter.kt
index e228f3eb736..f2b97769c03 100644
--- a/features/messages/impl/src/main... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenterTest.kt
index b79468f8200..aedd0cdc14b 100644
--- a/features/messages/impl/... | {
"io.element.android.features.messages.impl.actionlist.ActionListPresenterTest.present - compute for message from others redacted": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.attachments.AttachmentsPreviewPresenterTest.present - cancel scenario": {
... | {} | {} | {} |
element-hq__element-x-android-3916 | element-hq | element-x-android | 3,916 | closed | Enable all notification actions: quick reply, accept/decline invite, mark as read from notification. | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Enable all notification actions: quick reply, accept/decline invite, mark as read from notification.... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "e8af711777c97d75a8e2de9c07f38f0c388b08fb"
} | [
{
"number": 3908,
"title": "bring \"mark as read\" button on the notification back",
"body": "### Your use case\r\n\r\nPlease bring \"mark as read\" button on the notification back.\r\n\r\n\r\n\r\n\r\n### Have you c... | kotlin | bring "mark as read" button on the notification back
### Your use case
Please bring "mark as read" button on the notification back.
### Have you considered any alternatives?
_No response_
### Additional context
... | Thanks for creating the issue. We are waiting for a product decision to restore notification actions.
I agree it would be nice to support this. It's currently disabled, waiting for a product decision.
Would be great
See also #1547 | https://github.com/element-hq/element-x-android/pull/3916 | [
"https://github.com/element-hq/element-x-android/issues/3908",
"https://github.com/element-hq/element-x-android/issues/1966"
] | ./gradlew :libraries:push:impl:testDebugUnitTest --tests "io.element.android.libraries.push.impl.notifications.factories.DefaultNotificationCreatorTest" --tests "io.element.android.libraries.push.impl.notifications.DefaultRoomGroupMessageCreatorTest" | diff --git a/appconfig/src/main/kotlin/io/element/android/appconfig/NotificationConfig.kt b/appconfig/src/main/kotlin/io/element/android/appconfig/NotificationConfig.kt
index c5f605e5fe3..83ea9e3b77d 100644
--- a/appconfig/src/main/kotlin/io/element/android/appconfig/NotificationConfig.kt
+++ b/appconfig/src/main/kotli... | diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/notifications/DefaultRoomGroupMessageCreatorTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/notifications/DefaultRoomGroupMessageCreatorTest.kt
index d0255aa4528..44846f80107 100644
--- a/librari... | {
"io.element.android.libraries.push.impl.notifications.factories.DefaultNotificationCreatorTest.test createSummaryListNotification": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.factories.DefaultNotificationCreatorTest.test createSimpleEventN... | {
"io.element.android.libraries.push.impl.notifications.factories.DefaultNotificationCreatorTest.test createDiagnosticNotification": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.factories.DefaultNotificationCreatorTest.test createRoomInvitatio... | {
"io.element.android.libraries.push.impl.notifications.factories.DefaultNotificationCreatorTest.test createMessagesListNotification should bing and thread": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.DefaultRoomGroupMessageCreatorTest.test ... | {} |
element-hq__element-x-android-3864 | element-hq | element-x-android | 3,864 | closed | Use formatted captions for images and video | ## Content
This PR has the following changes:
- Parse the `caption` and `formattedCaption` in the same way as we do for text messages.
- Allow opening links from the caption UI text component.
- Split the `onClick` action for timeline items between those whose onClick action should be triggered by the whole mes... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "a9c74e9243d4822f9894f37205df567c30025b54"
} | [
{
"number": 3850,
"title": "URLs are not clickable in media captions",
"body": "### Steps to reproduce\n\n1. Send a message with a media Captain\r\n2. Make sure the caption contains a URL (https://...) somewhere\r\n3. Observe issue\n\n### Outcome\n\n#### What did you expect?\r\n\r\nURLs should be highli... | kotlin | URLs are not clickable in media captions
### Steps to reproduce
1. Send a message with a media Captain
2. Make sure the caption contains a URL (https://...) somewhere
3. Observe issue
### Outcome
#### What did you expect?
URLs should be highlighted and clickable, as they are in normal text bodies
#### What h... | Duplicate of #3529 (although this issue is better worded)
> Duplicate of #3529 (although this issue is better worded)
oh I didn't catch that as I searched for "URL" not something like "link" :woozy_face: | https://github.com/element-hq/element-x-android/pull/3864 | [
"https://github.com/element-hq/element-x-android/issues/3850"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.timeline.factories.event.TimelineItemContentMessageFactoryTest" --tests "io.element.android.features.messages.impl.timeline.TimelineViewTest" --tests "io.element.android.features.messages.impl.MessagesViewTest" | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNode.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesNode.kt
index bf76f208e38..9fd823445f8 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android/features/... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesViewTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesViewTest.kt
index a20acaa5df0..c040ce99264 100644
--- a/features/messages/impl/src/test/kotlin/io/element/android/f... | {} | {
"io.element.android.features.messages.impl.MessagesViewTest.clicking on more reaction from action list emits the expected Event": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.features.messages.impl.MessagesViewTest.clicking on verified user send failure from action list emit... | {
"io.element.android.features.messages.impl.timeline.factories.event.TimelineItemContentMessageFactoryTest.test create TextMessageType with unknown formatted body does nothing": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.features.messages.impl.timeline.factories.event.Timel... | {} |
element-hq__element-x-android-3829 | element-hq | element-x-android | 3,829 | closed | Verification UI / UX iteration | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Iterate on a few screens of the verification flows
## Motivation and context
<!-- Provide link... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "a6fedbafbdbea7c37399fe67deb362a04097a5ad"
} | [
{
"number": 3824,
"title": "Incoming verification iteration",
"body": "- [ ] Verification cancelled: show the error screen.\r\n- [x] Add new intermediate screen:\r\n<img width=\"352\" alt=\"image\" src=\"https://github.com/user-attachments/assets/3d546b25-2e19-4065-a3df-d6890578259f\">\r\n\r\n- [ ] Chec... | kotlin | Incoming verification iteration
- [ ] Verification cancelled: show the error screen.
- [x] Add new intermediate screen:
<img width="352" alt="image" src="https://github.com/user-attachments/assets/3d546b25-2e19-4065-a3df-d6890578259f">
- [ ] Check this screen copy:
<img width="374" alt="image" src="https://github... | null | https://github.com/element-hq/element-x-android/pull/3829 | [
"https://github.com/element-hq/element-x-android/issues/3824"
] | ./gradlew :features:verifysession:impl:testDebugUnitTest --tests "io.element.android.features.verifysession.impl.outgoing.VerifySelfSessionPresenterTest" | diff --git a/features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/incoming/IncomingVerificationView.kt b/features/verifysession/impl/src/main/kotlin/io/element/android/features/verifysession/impl/incoming/IncomingVerificationView.kt
index cc2c9fbd2d0..e8f098f848e 100644
--- a/featu... | diff --git a/features/verifysession/impl/src/test/kotlin/io/element/android/features/verifysession/impl/outgoing/VerifySelfSessionPresenterTest.kt b/features/verifysession/impl/src/test/kotlin/io/element/android/features/verifysession/impl/outgoing/VerifySelfSessionPresenterTest.kt
index bfdf27ee5d2..d8fe2f671c5 100644... | {
"io.element.android.features.verifysession.impl.outgoing.VerifySelfSessionPresenterTest.present - Handles requestVerification": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.verifysession.impl.outgoing.VerifySelfSessionPresenterTest.present - Initial state is receive... | {} | {} | {} |
element-hq__element-x-android-3816 | element-hq | element-x-android | 3,816 | closed | Iteration on caption | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
This PR is following #3803 .
- Improve the last message preview in the room list for media. Either ... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "47d7eac1eac0ac6088e722c013c83a0be31a021b"
} | [
{
"number": 2602,
"title": "Notifications of images with MSC2530 captions show no text ",
"body": "Notification:\n\n\nMessage:\n
Message:
![Screenshot_20240325-162028.png](https://github.com/element-hq/element-x-android/assets/775104/ffaf24... | I haven't updated SchildiChat to ElementX v0.4.7 yet, but if anybody wants to check if our old implementation of this is applicable: https://github.com/SchildiChat/schildichat-android-next/commit/9046a0a74b3b59a70d972fdb89f6578966d97485
Maybe I'll PR this once I get Schildi updated to the upstream caption implementa... | https://github.com/element-hq/element-x-android/pull/3816 | [
"https://github.com/element-hq/element-x-android/issues/2602"
] | ./gradlew :libraries:eventformatter:impl:testDebugUnitTest --tests "io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest" --tests "io.element.android.libraries.eventformatter.impl.DefaultPinnedMessagesBannerFormatterTest" :libraries:push:impl:testDebugUnitTest --tests "io.element.android... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemVideoView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemVideoView.kt
index 675f9adfc6d..849084ea1cc 100644
---... | diff --git a/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultPinnedMessagesBannerFormatterTest.kt b/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultPinnedMessagesBannerFormatterTest.kt
index af347135fbf..80a7691a... | {
"io.element.android.libraries.push.impl.notifications.DefaultNotifiableEventResolverTest.resolve event message voice": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.DefaultNotifiableEventResolverTest.resolve event message image": {
"run":... | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Room state change - room topic": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Membership change - invitation rejected": {
... | {
"io.element.android.libraries.eventformatter.impl.DefaultPinnedMessagesBannerFormatterTest.Profile change - display name": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultPinnedMessagesBannerFormatterTest.Redacted content": {
"run": "PAS... | {} |
element-hq__element-x-android-3755 | element-hq | element-x-android | 3,755 | closed | Rotate firebase token in case of error | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add a quick fix for the troubleshoot notification test in case of PusherRejected error, which means ... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "1c020bcf2671bdb5c410aba882219733e38c0b27"
} | [
{
"number": 3752,
"title": "Push-Notification Option for recreate token if test failed",
"body": "Here a dedicated issue of this slice different Problem:\r\nhttps://github.com/element-hq/element-x-android/issues/3570#issuecomment-2423760827\r\n\r\n### Steps to reproduce\r\n\r\n1. Login to EXA\r\n2. See ... | kotlin | Push-Notification Option for recreate token if test failed
Here a dedicated issue of this slice different Problem:
https://github.com/element-hq/element-x-android/issues/3570#issuecomment-2423760827
### Steps to reproduce
1. Login to EXA
2. See in microg if EXA was correct registerd to FCM
3. test push works i... | Here a Screenshot of current broken state
| https://github.com/element-hq/element-x-android/pull/3755 | [
"https://github.com/element-hq/element-x-android/issues/3752"
] | ./gradlew :libraries:pushproviders:firebase:testDebugUnitTest --tests "io.element.android.libraries.pushproviders.firebase.troubleshoot.FirebaseTokenTestTest" --tests "io.element.android.libraries.pushproviders.firebase.FirebasePushProviderTest" :libraries:push:impl:testDebugUnitTest --tests "io.element.android.librari... | diff --git a/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/PushProvider.kt b/libraries/pushproviders/api/src/main/kotlin/io/element/android/libraries/pushproviders/api/PushProvider.kt
index 0f3cde8033b..90b4cb04658 100644
--- a/libraries/pushproviders/api/src/main/kotlin/io/... | diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushLoopbackTest.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/troubleshoot/PushLoopbackTest.kt
index e91f4351f78..57c255a4064 100644
--- a/libraries/push/impl/src/main/kotlin/io/elemen... | {
"io.element.android.libraries.pushproviders.firebase.FirebasePushProviderTest.getDistributors return the unique distributor if available": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.troubleshoot.PushLoopbackTestTest.test PushLoopbackTest timeout - push ... | {} | {} | {} |
element-hq__element-x-android-3694 | element-hq | element-x-android | 3,694 | closed | OIDC prompt | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
SDK 0.1.54 and fix all the API break.
Then last commit fixes #3635 (so this PR replaces #3635)
... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "7ece6877404e56e9bf958da2ada6e732b8a773ba"
} | [
{
"number": 3635,
"title": "When creating an account with MAS, change the `prompt` parameter to `create`",
"body": "\r\n<!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->\r\n \r\n## Content\r\n\r\n<!-- ... | kotlin | When creating an account with MAS, change the `prompt` parameter to `create`
<!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
When user is creating... | <!-- GITHUB_COMMENT_QR_CODE -->
:iphone: Scan the QR code below to install the build (arm64 only) for this PR.
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/V8Ep1n
## [![Quality Gate Passed](https://sonarsource.github.io/s... | https://github.com/element-hq/element-x-android/pull/3694 | [
"https://github.com/element-hq/element-x-android/issues/3635"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.voicemessages.timeline.DefaultVoiceMessageMediaRepoTest" --tests "io.element.android.features.messages.impl.voicemessages.timeline.RedactedVoiceMessageManagerTest" --tests "io.element.android.features.messages.impl.vo... | diff --git a/features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderPresenter.kt b/features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderPresenter.kt
index c15c84744ff..6cc4... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/fixtures/MessageEventFixtures.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/fixtures/MessageEventFixtures.kt
index 758557923f6..3a4d343203c 100644
--- a/features/messages/impl/src/test/k... | {
"io.element.android.features.messages.impl.voicemessages.timeline.DefaultVoiceMessageMediaRepoTest.cache hit - returns cached file successfully": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.voicemessages.timeline.DefaultVoiceMessagePlayerTest.seek bef... | {} | {} | {} |
element-hq__element-x-android-3592 | element-hq | element-x-android | 3,592 | closed | Add developer setting to hide images in the timeline | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add a switch to the developer settings screen to prevent preview of images, videos and sticker to be... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "98d9abecd9efcd1e303b957a446b0fa7f17802f5"
} | [
{
"number": 3386,
"title": "Add user controls for whether to display media (including thumbnails)",
"body": "### Your use case\n\nAndroid version of element-hq/element-meta#2518.\r\n\r\nUrgent req for T&S.\n\n### Have you considered any alternatives?\n\n_No response_\n\n### Additional context\n\n_No res... | kotlin | Add user controls for whether to display media (including thumbnails)
### Your use case
Android version of element-hq/element-meta#2518.
Urgent req for T&S.
### Have you considered any alternatives?
_No response_
### Additional context
_No response_
### Are you willing to provide a PR?
No
| null | https://github.com/element-hq/element-x-android/pull/3592 | [
"https://github.com/element-hq/element-x-android/issues/3386"
] | ./gradlew :tests:konsist:testDebugUnitTest --tests "io.element.android.tests.konsist.KonsistPreviewTest" :libraries:matrixui:testDebugUnitTest --tests "io.element.android.libraries.matrix.ui.messages.reply.InReplyToMetadataKtTest" :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.i... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesPresenter.kt
index b0029fe4ee6..388780d384c 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
index 79792f4db1c..209d719b82a 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {
"io.element.android.features.messages.impl.voicemessages.composer.VoiceMessageComposerPresenterTest.present - abort recording": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.DefaultNotifiableEventResolverTest.resolve event message image": {
... | {} | {
"io.element.android.tests.konsist.KonsistPreviewTest.Ensure that '@PreviewLightDark' is not used": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.tests.konsist.KonsistPreviewTest.Functions with '@PreviewsDayNight' annotation should have 'Preview' suffix": {
"run": "PASS",
... | {} |
element-hq__element-x-android-3429 | element-hq | element-x-android | 3,429 | closed | Add banner for optional migration to simplified sliding sync | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
- Add `MatrixClient.isNativeSlidingSyncSupported()` and `MatrixClient.isUsingNativeSlidingSync` to check whether the home server supports native slid... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "a2841779002c9a771c8b5bb5b1ff4f91672fd1e4"
} | [
{
"number": 3427,
"title": "Offer user to transition to SSS (Android)",
"body": "1. Follow the logic defined in the parent issue to prompt the user to log out to complete the migration to SSS.\r\n2. For prompt choose platform-native implementation (whatever is the easiest to implement)."
}
] | kotlin | Offer user to transition to SSS (Android)
1. Follow the logic defined in the parent issue to prompt the user to log out to complete the migration to SSS.
2. For prompt choose platform-native implementation (whatever is the easiest to implement).
| @amshakal Would you explicitly create the designs in Figma in such a case? I think it would be preferred to make it more specific.
Designs for Android: https://www.figma.com/design/LwZ8S0VbzKqekK1akuoh8z/Launch-%2B-Onboarding-(new)?node-id=241-4337&t=Y89GDbdGbVjhMV83-1 | https://github.com/element-hq/element-x-android/pull/3429 | [
"https://github.com/element-hq/element-x-android/issues/3427"
] | ./gradlew :features:roomlist:impl:testDebugUnitTest --tests "io.element.android.features.roomlist.impl.RoomListViewTest" --tests "io.element.android.features.roomlist.impl.RoomListPresenterTest" :libraries:preferences:api:testDebugUnitTest --tests "io.element.android.libraries.preferences.api.store.EnableNativeSlidingS... | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt b/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt
index db153314d62..5a8db185ef3 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt
+++ b/appnav/src/main/kotlin/io/element/android/appnav... | diff --git a/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTest.kt b/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTest.kt
index 1b639d2b193..8b7294b165c 100644
--- a/features/roomlist/impl/src/test/kotlin/io/element... | {
"io.element.android.features.roomlist.impl.RoomListPresenterTest.present - change in notification settings updates the summary for decorations": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.roomlist.impl.RoomListViewTest.clicking on continue recovery key banner invo... | {} | {} | {} |
element-hq__element-x-android-3413 | element-hq | element-x-android | 3,413 | closed | Delete old log files | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Add an application migration to delete the logs which use previous filename format.
Also add miss... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "4b4acfca1e6dea30b044e065c584dbb35a8ede7b"
} | [
{
"number": 3406,
"title": "old logfiles are not being cleaned up",
"body": "https://github.com/element-hq/element-x-android-rageshakes/issues/2619 contains a total of 1103 logfiles, many of which are quite old.\r\n\r\nI gather that the intention is to delete logfiles after a week, but that has not happ... | kotlin | old logfiles are not being cleaned up
https://github.com/element-hq/element-x-android-rageshakes/issues/2619 contains a total of 1103 logfiles, many of which are quite old.
I gather that the intention is to delete logfiles after a week, but that has not happened in this case.
The filenames of the old logs fall in... | null | https://github.com/element-hq/element-x-android/pull/3413 | [
"https://github.com/element-hq/element-x-android/issues/3406"
] | ./gradlew :features:rageshake:impl:testDebugUnitTest --tests "io.element.android.features.rageshake.impl.bugreport.BugReportPresenterTest" :features:migration:impl:testDebugUnitTest --tests "io.element.android.features.migration.impl.migrations.AppMigration06Test" --tests "io.element.android.features.migration.impl.mig... | diff --git a/features/migration/impl/build.gradle.kts b/features/migration/impl/build.gradle.kts
index 69789750709..69a1c2bfe92 100644
--- a/features/migration/impl/build.gradle.kts
+++ b/features/migration/impl/build.gradle.kts
@@ -40,6 +40,7 @@ dependencies {
testImplementation(libs.test.robolectric)
testIm... | diff --git a/features/migration/impl/src/test/kotlin/io/element/android/features/migration/impl/MigrationPresenterTest.kt b/features/migration/impl/src/test/kotlin/io/element/android/features/migration/impl/MigrationPresenterTest.kt
index 29be8682e34..26cb0df3c1a 100644
--- a/features/migration/impl/src/test/kotlin/io/... | {
"io.element.android.features.migration.impl.migrations.AppMigration06Test.empty cache path should be set to an expected path": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.rageshake.impl.bugreport.BugReportPresenterTest.present - can contact": {
"run": "PASS",
... | {} | {} | {} |
element-hq__element-x-android-3395 | element-hq | element-x-android | 3,395 | closed | Skip device verification screen when creating a new account using OIDC | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
It can happen that the session is automatically verified and in this case the FTUE verification step... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "2c8b0d0b95e95fa2e200c1a84cfa553bee854430"
} | [
{
"number": 3279,
"title": " Device verification success screen appears after a fresh new registration #3126 ",
"body": "### Steps to reproduce\n\n1. Select a HS with a MAS accepting registration (ask if you do not know one)\r\n2. Create an account\r\n\r\n<details>\r\n<summary>The device verification su... | kotlin | Device verification success screen appears after a fresh new registration #3126
### Steps to reproduce
1. Select a HS with a MAS accepting registration (ask if you do not know one)
2. Create an account
<details>
<summary>The device verification success screen unexpectly appears</summary>
<img src="https://gith... | It is very similar as https://github.com/element-hq/element-x-ios/issues/3126 but less impactful. It is still a bad FTUE and we need to fix it.
I cannot enter the app because of this "Device verified" screen! When is this going to be fixed? | https://github.com/element-hq/element-x-android/pull/3395 | [
"https://github.com/element-hq/element-x-android/issues/3279"
] | ./gradlew :features:verifysession:impl:testDebugUnitTest --tests "io.element.android.features.verifysession.impl.VerifySelfSessionPresenterTest" | diff --git a/features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/sessionverification/FtueSessionVerificationFlowNode.kt b/features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/sessionverification/FtueSessionVerificationFlowNode.kt
index 3e4ed218a5a..694819a2dc0 100644
--- a/featu... | diff --git a/features/verifysession/impl/src/test/kotlin/io/element/android/features/verifysession/impl/VerifySelfSessionPresenterTest.kt b/features/verifysession/impl/src/test/kotlin/io/element/android/features/verifysession/impl/VerifySelfSessionPresenterTest.kt
index c258b9df03b..ca8836ac61b 100644
--- a/features/ve... | {
"io.element.android.features.verifysession.impl.VerifySelfSessionPresenterTest.present - When verifying, if we receive another challenge we ignore it": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.verifysession.impl.VerifySelfSessionPresenterTest.present - Go back a... | {} | {} | {} |
element-hq__element-x-android-3381 | element-hq | element-x-android | 3,381 | closed | Replace OSS licenses plugin with Licensee and some manually done UI. | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Use https://github.com/cashapp/licensee to build a licenses file and parse it at runtime to generate... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "94f138840273b6a98ceb935b940c87dd9af4c13a"
} | [
{
"number": 3361,
"title": "F-Droid can't build",
"body": "### Steps to reproduce\r\n\r\nhttps://gitlab.com/fdroid/fdroiddata/-/jobs/7697782544#L6769\r\n\r\ndifflog:\r\n\r\n```\r\n│ │ │ --- app-fdroid-arm64-v8a-release-signed/res/raw/third_party_license_metadata ... | kotlin | F-Droid can't build
### Steps to reproduce
https://gitlab.com/fdroid/fdroiddata/-/jobs/7697782544#L6769
difflog:
```
│ │ │ --- app-fdroid-arm64-v8a-release-signed/res/raw/third_party_license_metadata
│ │ ├── +++ io.element.android.x_40005012/res/raw/third_party_li... | null | https://github.com/element-hq/element-x-android/pull/3381 | [
"https://github.com/element-hq/element-x-android/issues/3361"
] | ./gradlew :tests:konsist:testDebugUnitTest --tests "io.element.android.tests.konsist.KonsistClassNameTest" :features:preferences:impl:testDebugUnitTest --tests "io.element.android.features.preferences.impl.about.AboutPresenterTest" --tests "io.element.android.features.preferences.impl.about.AboutViewTest" :features:lic... | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 7778a3246e6..49641a16cdf 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -17,15 +17,19 @@
@file:Suppress("UnstableApiUsage")
import com.android.build.api.variant.FilterConfiguration.FilterType.ABI
+import com.android.build.gradle.interna... | diff --git a/features/licenses/impl/src/test/kotlin/io/element/android/features/licenses/impl/list/DependencyLicensesListPresenterTest.kt b/features/licenses/impl/src/test/kotlin/io/element/android/features/licenses/impl/list/DependencyLicensesListPresenterTest.kt
new file mode 100644
index 00000000000..55cb062ecd9
---... | {
"io.element.android.tests.konsist.KonsistClassNameTest.Fake classes must be named using Fake and the interface it fakes": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.tests.konsist.KonsistClassNameTest.Classes extending 'PreviewParameterProvider' name MUST end with 'Provider... | {} | {} | {} |
element-hq__element-x-android-3334 | element-hq | element-x-android | 3,334 | closed | Use new functions exposed by Element Call about PiP |
<!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
- Communicate with Element Call about PiP status.
- Also only use eventSink to communicate with... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "1b7c0dbe8842ef6bf53ac05e4d8eace2d1fd10dc"
} | [
{
"number": 3326,
"title": "[PiP] Use new functions expose by Element Call about PiP",
"body": "Element Call is exposing 3 new functions about PiP:\r\n\r\n- `canEnterPip`: will return a boolean to let the application if it is possible to enter the PiP mode. If the call is in error state for instance, th... | kotlin | [PiP] Use new functions expose by Element Call about PiP
Element Call is exposing 3 new functions about PiP:
- `canEnterPip`: will return a boolean to let the application if it is possible to enter the PiP mode. If the call is in error state for instance, the application should not enter PiP but rather hang up the c... | For your reference, this is where we're using the API on iOS:
https://github.com/element-hq/element-x-ios/blob/dad9618f59c7494dbc69c150f2d71856c1d97c00/ElementX/Sources/Screens/CallScreen/View/CallScreen.swift#L211-L259
And if that `requestPictureInPicture` method fails we then decide to [navigate back](https://g... | https://github.com/element-hq/element-x-android/pull/3334 | [
"https://github.com/element-hq/element-x-android/issues/3326"
] | ./gradlew :features:call:impl:testDebugUnitTest --tests "io.element.android.features.call.impl.ui.CallScreenViewTest" --tests "io.element.android.features.call.impl.pip.PictureInPicturePresenterTest" | diff --git a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/pip/PictureInPictureEvents.kt b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/pip/PictureInPictureEvents.kt
index da3c08da32a..4d29f757ea5 100644
--- a/features/call/impl/src/main/kotlin/io/element/android/f... | diff --git a/features/call/impl/src/test/kotlin/io/element/android/features/call/impl/pip/FakePipController.kt b/features/call/impl/src/test/kotlin/io/element/android/features/call/impl/pip/FakePipController.kt
new file mode 100644
index 00000000000..086feecd39f
--- /dev/null
+++ b/features/call/impl/src/test/kotlin/io... | {
"io.element.android.features.call.impl.pip.PictureInPicturePresenterTest.when pip is supported, the state value supportPip is true": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.call.impl.pip.PictureInPicturePresenterTest.with webPipApi, when entering pip is support... | {} | {} | {} |
element-hq__element-x-android-3322 | element-hq | element-x-android | 3,322 | closed | Suggestion for room alias (disabled for now) | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
- implement completion for room alias, under a disabled feature flag (mainly to wait for the featu... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "1b1062be243dcc497d2f004a2835c8d9f2de0240"
} | [
{
"number": 2907,
"title": "Room alias autocomplete not working",
"body": "### Steps to reproduce\n\n1. (Turn off wysiwyg because you can't type MD in that)\r\n2. Type #\r\n3. Optionally continue typing a known alias\n\n### Outcome\n\n#### What did you expect?\r\nAlias suggestions like @ uid suggestions... | kotlin | Room alias autocomplete not working
### Steps to reproduce
1. (Turn off wysiwyg because you can't type MD in that)
2. Type #
3. Optionally continue typing a known alias
### Outcome
#### What did you expect?
Alias suggestions like @ uid suggestions
#### What happened instead?
Nothing
### Your phone model
_No ... | null | https://github.com/element-hq/element-x-android/pull/3322 | [
"https://github.com/element-hq/element-x-android/issues/2907"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.messagecomposer.MessageComposerPresenterTest" --tests "io.element.android.features.messages.impl.timeline.TimelineControllerTest" --tests "io.element.android.features.messages.impl.MessagesPresenterTest" --tests "io.e... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/MessagesView.kt
index df6aa26778a..f1f8b844ef0 100644
--- a/features/messages/impl/src/main/kotlin/io/element/android/features/... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
index a6c123971ba..c9700a60bd6 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {
"io.element.android.libraries.push.impl.notifications.NotificationBroadcastReceiverHandlerTest.Test mark room as read without room": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.messages.impl.messagecomposer.suggestions.SuggestionsProcessorTest.processing null sugge... | {} | {} | {} |
element-hq__element-x-android-3320 | element-hq | element-x-android | 3,320 | closed | Redact message on displayed notification | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Content
<!-- Describe shortly what has been changed -->
Ensure that any message currently displayed in a notification is removed when the Event is redacted.... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "45c216c7a3ffac8f6c86ff290dc372208331eb76"
} | [
{
"number": 3310,
"title": "Redacted messages continue to show in notification previews",
"body": "### Steps to reproduce\r\n\r\n1. Send an image from another client\r\n2. Receive the notification on Element X which shows the image\r\n3. Redact the image on the other client\r\n4. Notice how the notifica... | kotlin | Redacted messages continue to show in notification previews
### Steps to reproduce
1. Send an image from another client
2. Receive the notification on Element X which shows the image
3. Redact the image on the other client
4. Notice how the notification on Element X still shows the image
Message with image red... | Waiting for https://github.com/matrix-org/matrix-rust-sdk/issues/3859 to be handled.
If this needs Rust support, it might be an issue on Element X iOS, too? I haven't tested this on iOS so far. | https://github.com/element-hq/element-x-android/pull/3320 | [
"https://github.com/element-hq/element-x-android/issues/3310"
] | ./gradlew :libraries:push:impl:testDebugUnitTest --tests "io.element.android.libraries.push.impl.notifications.DefaultNotifiableEventResolverTest" --tests "io.element.android.libraries.push.impl.notifications.DefaultActiveNotificationsProviderTest" --tests "io.element.android.libraries.push.impl.push.DefaultPushHandler... | diff --git a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/notification/NotificationData.kt b/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/notification/NotificationData.kt
index 74bd2d8e14b..b1dd0c683c4 100644
--- a/libraries/matrix/api/src/main/kotlin/io/e... | diff --git a/libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/TestData.kt b/libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/TestData.kt
index a84fe1edf63..3b395309784 100644
--- a/libraries/matrix/test/src/main/kotlin/io/element/android/libraries/matrix/test/... | {} | {
"io.element.android.libraries.push.impl.notifications.DefaultNotifiableEventResolverTest.resolve event message voice": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.DefaultNotifiableEventResolverTest.resolve RoomRedaction with null redactedEv... | {
"io.element.android.libraries.push.impl.notifications.DefaultActiveNotificationsProviderTest.getNotificationsForSession returns only notifications for that session id": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.push.DefaultPushHandlerTest.when ringing ... | {} |
element-hq__element-x-android-3295 | element-hq | element-x-android | 3,295 | closed | Big emoji-only messages | ## Content
Render emoji-only messages in a larger text
Adapted from SpiritCroc's SchildNext implementation from https://github.com/SchildiChat/schildichat-android-next/commit/7eba87f02e884b9b921aa4e74dd0a737e4da31ad
Authored-by: SpiritCroc <dev@spiritcroc.de>
Submitted-by: Joe Groocock <me@frebib.net>
##... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "1b7c0dbe8842ef6bf53ac05e4d8eace2d1fd10dc"
} | [
{
"number": 1438,
"title": "Implement large emoji",
"body": "### Your use case\n\n\r\n\r\nLeft: Element X iOS. Right: Element X Android.\r\n\r\nWe should match the implementation here (& Element W... | kotlin | Implement large emoji
### Your use case
Left: Element X iOS. Right: Element X Android.
We should match the implementation here (& Element Web) where we enlarge emoji when sent on their own.
### Have you ... | This would be a nice to have. | https://github.com/element-hq/element-x-android/pull/3295 | [
"https://github.com/element-hq/element-x-android/issues/1438"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.utils.EmojiTest" | diff --git a/features/messages/impl/build.gradle.kts b/features/messages/impl/build.gradle.kts
index c1d3067510e..7f451a54a50 100644
--- a/features/messages/impl/build.gradle.kts
+++ b/features/messages/impl/build.gradle.kts
@@ -72,6 +72,7 @@ dependencies {
implementation(libs.androidx.constraintlayout.compose)
... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/utils/EmojiTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/utils/EmojiTest.kt
new file mode 100644
index 00000000000..d8b823704f7
--- /dev/null
+++ b/features/messages/impl/src/test/k... | {
"io.element.android.features.messages.impl.utils.EmojiTest.validEmojis": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
}
} | {} | {} | {} |
element-hq__element-x-android-3127 | element-hq | element-x-android | 3,127 | closed | Let the SDK retrieve and parse Element well known content | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [x] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Configure Elemen... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "bc13c242c25219d1ab2fb2ec93a3b9b143b32b82"
} | [
{
"number": 3124,
"title": "[Task] Configure Element Call's widget URL using the new SDK API that parses the element.json wellknown",
"body": "Story: https://github.com/element-hq/element-meta/issues/2441"
}
] | kotlin | [Task] Configure Element Call's widget URL using the new SDK API that parses the element.json wellknown
Story: https://github.com/element-hq/element-meta/issues/2441
| null | https://github.com/element-hq/element-x-android/pull/3127 | [
"https://github.com/element-hq/element-x-android/issues/3124"
] | ./gradlew :features:call:impl:testDebugUnitTest --tests "io.element.android.features.call.utils.DefaultCallWidgetProviderTest" :libraries:matrix:impl:testDebugUnitTest --tests "io.element.android.libraries.matrix.impl.call.DefaultElementCallBaseUrlProviderTest" | diff --git a/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/DefaultCallWidgetProvider.kt b/features/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/DefaultCallWidgetProvider.kt
index f36269abc67..df7a0317537 100644
--- a/features/call/impl/src/main/kotlin/io/element... | diff --git a/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/DefaultCallWidgetProviderTest.kt b/features/call/impl/src/test/kotlin/io/element/android/features/call/utils/DefaultCallWidgetProviderTest.kt
index 73c8d3515eb..7eb426c35e1 100644
--- a/features/call/impl/src/test/kotlin/io/element/a... | {
"io.element.android.features.call.utils.DefaultCallWidgetProviderTest.getWidget - fails if it can't generate the URL for the widget": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.matrix.impl.call.DefaultElementCallBaseUrlProviderTest.provides returns value when get... | {} | {} | {} |
element-hq__element-x-android-3057 | element-hq | element-x-android | 3,057 | closed | Use full date format for day dividers in timeline | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [x] Other : improve UX
## Content
- Adds a new `dateWithFullFormatFormatter` that will u... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "4317b80844c6d20da5cff82f904693281af39dc6"
} | [
{
"number": 2916,
"title": "Use a sane date format for day markers",
"body": "### Your use case\n\nI would like to never have to see a MM/DD/YYYY format while using any application. Instead, the international YYYY-MM-DD format should be used.\n\n### Have you considered any alternatives?\n\nAn expanded f... | kotlin | Use a sane date format for day markers
### Your use case
I would like to never have to see a MM/DD/YYYY format while using any application. Instead, the international YYYY-MM-DD format should be used.
### Have you considered any alternatives?
An expanded format with written out day and month names, as done by Elemen... | Another possibility is to take the format from the system locale.
Unfortunately Android really sucks in this regard though as it only has a single locale setting rather than `LC_*`. There is some limited possibility to customise here as you could, for instance, use en_CA.
While I'm personally a big fan of ISO8601... | https://github.com/element-hq/element-x-android/pull/3057 | [
"https://github.com/element-hq/element-x-android/issues/2916"
] | ./gradlew :libraries:dateformatter:impl:testDebugUnitTest --tests "io.element.android.libraries.dateformatter.impl.DefaultLastMessageTimestampFormatterTest" | diff --git a/changelog.d/2916.misc b/changelog.d/2916.misc
new file mode 100644
index 00000000000..b87146dd580
--- /dev/null
+++ b/changelog.d/2916.misc
@@ -0,0 +1,1 @@
+Use a more natural date format for day dividers in the timeline. Also improve the time format for last messages in the room list.
diff --git a/librari... | diff --git a/libraries/dateformatter/impl/src/test/kotlin/io/element/android/libraries/dateformatter/impl/DefaultLastMessageTimestampFormatterTest.kt b/libraries/dateformatter/impl/src/test/kotlin/io/element/android/libraries/dateformatter/impl/DefaultLastMessageTimestampFormatterTest.kt
index dd8f75cae30..38e4fbffb35 ... | {
"io.element.android.libraries.dateformatter.impl.DefaultLastMessageTimestampFormatterTest.test one hour before": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.dateformatter.impl.DefaultLastMessageTimestampFormatterTest.test one year before same time": {
"run": "... | {} | {} | {} |
element-hq__element-x-android-2901 | element-hq | element-x-android | 2,901 | closed | Fix unregistering pusher local error | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Fixes #2895 by i... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "22bde9e4de5772e0d9253e7fe928287d9667ba86"
} | [
{
"number": 2895,
"title": "Selecting ntfy as notification provider does not work",
"body": "### Steps to reproduce\r\n\r\n1. In \"Advanced settings\", tap \"Push notification provider\"\r\n2. From the selection of \"Firebase\" and \"ntfy\", pick \"ntfy\"\r\n3. \"Push notification provider\" setting now... | kotlin | Selecting ntfy as notification provider does not work
### Steps to reproduce
1. In "Advanced settings", tap "Push notification provider"
2. From the selection of "Firebase" and "ntfy", pick "ntfy"
3. "Push notification provider" setting now shows "Error" as current value, going back and then into "Advanced setting... | OK, thanks for the issue and the log. If when you come back to the Advanced setting screen and see again "Firebase", it means that the unregistration of Firebase has failed. And indeed, I see in your log:
> java.lang.IllegalStateException: Unable to unregister pusher, Firebase token is not known.
The application ... | https://github.com/element-hq/element-x-android/pull/2901 | [
"https://github.com/element-hq/element-x-android/issues/2895"
] | ./gradlew :libraries:pushproviders:firebase:testDebugUnitTest --tests "io.element.android.libraries.pushproviders.firebase.FirebasePushProviderTest" :libraries:pushproviders:unifiedpush:testDebugUnitTest --tests "io.element.android.libraries.pushproviders.unifiedpush.DefaultUnregisterUnifiedPushUseCaseTest" | diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/DefaultPushService.kt b/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/DefaultPushService.kt
index bf2b1ed5422..47e26fb9207 100644
--- a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/pu... | diff --git a/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProviderTest.kt b/libraries/pushproviders/firebase/src/test/kotlin/io/element/android/libraries/pushproviders/firebase/FirebasePushProviderTest.kt
index 3c826827673..880be2f053f 100644
--- a/lib... | {
"io.element.android.libraries.pushproviders.firebase.FirebasePushProviderTest.test index and name": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.pushproviders.firebase.FirebasePushProviderTest.getCurrentDistributor always return the unique distributor": {
"run"... | {
"io.element.android.libraries.pushproviders.unifiedpush.DefaultUnregisterUnifiedPushUseCaseTest.test un registration error - no endpoint - will not unregister but return success": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.libraries.pushproviders.unifiedpush.DefaultUnregis... | {
"io.element.android.libraries.pushproviders.firebase.FirebasePushProviderTest.register ko no token": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.pushproviders.firebase.FirebasePushProviderTest.getCurrentUserPushConfig ok": {
"run": "PASS",
"test": "PASS",
... | {} |
element-hq__element-x-android-2748 | element-hq | element-x-android | 2,748 | closed | Remove `SessionData.needsVerification` as the source of truth for session verification status | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Remove `SessionData.needsVerification` and its DB value.
- Use... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "8637a97cacfe98c9e6074e2dd7b1b4c7e05adf33"
} | [
{
"number": 2718,
"title": "Verified Element X session became unverified",
"body": "### Steps to reproduce\n\n1. Setup Element X.\r\n2. Login.\r\n3. Verify the session with another device.\r\n4. Use your \"Recovery Key\" to restore key backup.\r\n5. wait a day :P\n\n### Outcome\n\n#### What did you expe... | kotlin | Verified Element X session became unverified
### Steps to reproduce
1. Setup Element X.
2. Login.
3. Verify the session with another device.
4. Use your "Recovery Key" to restore key backup.
5. wait a day :P
### Outcome
#### What did you expect?
Things to work normally-ish.
#### What happened instead?
Tod... | Some days ago, I also got the verification screen on my phone. I wonder whether that was just caused by a recent update that (I think) changed the verification process/screen.
So possibly, the session never really was unverified, just the verification screen shows up.
@bmarty, I think, you did that verification w... | https://github.com/element-hq/element-x-android/pull/2748 | [
"https://github.com/element-hq/element-x-android/issues/2718"
] | ./gradlew :features:ftue:impl:testDebugUnitTest --tests "io.element.android.features.ftue.impl.DefaultFtueServiceTests" :features:verifysession:impl:testDebugUnitTest --tests "io.element.android.features.verifysession.impl.VerifySelfSessionPresenterTests" | diff --git a/changelog.d/2718.bugfix b/changelog.d/2718.bugfix
new file mode 100644
index 00000000000..999d47b59ba
--- /dev/null
+++ b/changelog.d/2718.bugfix
@@ -0,0 +1,1 @@
+Fix session verification being asked again for already verified users.
diff --git a/features/ftue/impl/build.gradle.kts b/features/ftue/impl/bui... | diff --git a/features/ftue/impl/src/test/kotlin/io/element/android/features/ftue/impl/DefaultFtueServiceTests.kt b/features/ftue/impl/src/test/kotlin/io/element/android/features/ftue/impl/DefaultFtueServiceTests.kt
index d381d945a92..9cc3db8d295 100644
--- a/features/ftue/impl/src/test/kotlin/io/element/android/feature... | {
"io.element.android.features.verifysession.impl.VerifySelfSessionPresenterTests.present - Canceling the flow once it's verifying cancels it": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.ftue.impl.DefaultFtueServiceTests.if a check for a step is true, start from the... | {} | {} | {} |
element-hq__element-x-android-2687 | element-hq | element-x-android | 2,687 | closed | Mark room as fully read when user goes back to the room list. | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Send `m.fully_re... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "0953789231cb4542cb6185071eb2233ddb4a8d17"
} | [
{
"number": 2281,
"title": "Own read marker (new) does not get updated when reading the room",
"body": "### Steps to reproduce\n\n1. Open a room with unread messages\r\n2. Observe the \"New\" marker being at the correct place\r\n3. Scroll and read through the room as long as you like\r\n4. Close the roo... | kotlin | Own read marker (new) does not get updated when reading the room
### Steps to reproduce
1. Open a room with unread messages
2. Observe the "New" marker being at the correct place
3. Scroll and read through the room as long as you like
4. Close the room and open it again
5. Observe the "New" marker being at the sam... | I believe Element X simply does not update the unread marker at all, atleast the chat room was marked read in Element-Web, but the unread marker was not updated (showing unread messages farther up the room)
We need send the receipt `FULLY_READ` when the user goes back to the room list. | https://github.com/element-hq/element-x-android/pull/2687 | [
"https://github.com/element-hq/element-x-android/issues/2281"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.MessagesPresenterTest" --tests "io.element.android.features.messages.impl.timeline.TimelinePresenterTest" --tests "io.element.android.features.messages.impl.timeline.DefaultMarkAsFullyReadTest" :libraries:push:impl:te... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/MarkAsFullyRead.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/MarkAsFullyRead.kt
new file mode 100644
index 00000000000..b2962e2f5ad
--- /dev/null
+++ b/features/messag... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
index f45dbe214c1..e42941da0d8 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {} | {
"io.element.android.features.messages.impl.timeline.DefaultMarkAsFullyReadTest.When room is found, the expected method is invoked": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.features.messages.impl.timeline.DefaultMarkAsFullyReadTest.When room is not found, then no excepti... | {
"io.element.android.libraries.push.impl.notifications.NotificationBroadcastReceiverHandlerTest.Test mark room as read without room": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.features.messages.impl.MessagesPresenterTest.present - handle action reply to an image media mess... | {} |
element-hq__element-x-android-2639 | element-hq | element-x-android | 2,639 | closed | Hide call member events | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
- First commit i... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "61edf282a4ccb5b1c0341ded5f83349ba658b7be"
} | [
{
"number": 2625,
"title": "The timeline is rendering event `org.matrix.msc3401.call.member`",
"body": "### Steps to reproduce\n\n1. Start a call in a room\r\n2. End the call\r\n3. Observe the timeline\r\n\r\n<img width=\"301\" alt=\"image\" src=\"https://github.com/element-hq/element-x-android/assets/3... | kotlin | The timeline is rendering event `org.matrix.msc3401.call.member`
### Steps to reproduce
1. Start a call in a room
2. End the call
3. Observe the timeline
<img width="301" alt="image" src="https://github.com/element-hq/element-x-android/assets/3940906/b10ff2f1-8494-42d5-b619-bda71baefbeb">
The event of type `o... | null | https://github.com/element-hq/element-x-android/pull/2639 | [
"https://github.com/element-hq/element-x-android/issues/2625"
] | ./gradlew :libraries:eventformatter:impl:testDebugUnitTest --tests "io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest" :libraries:textcomposer:impl:testDebugUnitTest --tests "io.element.android.libraries.textcomposer.impl.mentions.MentionSpanProviderTest" :libraries:matrix:impl:testDe... | diff --git a/appconfig/build.gradle.kts b/appconfig/build.gradle.kts
index 853a775b451..e59799d6854 100644
--- a/appconfig/build.gradle.kts
+++ b/appconfig/build.gradle.kts
@@ -14,16 +14,13 @@
* limitations under the License.
*/
plugins {
- id("java-library")
- id("com.android.lint")
- alias(libs.plugins.... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/MessagesPresenterTest.kt
index 30413d1b9fc..6cceb6b5b54 100644
--- a/features/messages/impl/src/test/kotlin/io/element... | {
"io.element.android.libraries.matrix.impl.permalink.DefaultPermalinkParserTest.parsing a valid room id with event id url returns a room link": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Room state change - c... | {} | {} | {} |
element-hq__element-x-android-2620 | element-hq | element-x-android | 2,620 | closed | Feature/fga/room directory | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
Room directory search should disabled for release build.
Can be en... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "bd5c6ea20c25a92ed282616888be38aab2b5dfc7"
} | [
{
"number": 2578,
"title": "[Task] Join a public room from the room search directory",
"body": "From element-x-ios created by [Velin92](https://github.com/Velin92): element-hq/element-x-ios#2590 \n\nIf a room is joinable it should show a Join button (even if the whole cell should be tappable).\r\nThis ... | kotlin | [Task] Join a public room from the room search directory
From element-x-ios created by [Velin92](https://github.com/Velin92): element-hq/element-x-ios#2590
If a room is joinable it should show a Join button (even if the whole cell should be tappable).
This will show a loader, the search view will be dismissed, and ... | null | https://github.com/element-hq/element-x-android/pull/2620 | [
"https://github.com/element-hq/element-x-android/issues/2578"
] | ./gradlew :tests:testutils:testDebugUnitTest --tests "io.element.android.tests.testutils.PresenterTest" :features:roomlist:impl:testDebugUnitTest --tests "io.element.android.features.roomlist.impl.RoomListViewTest" --tests "io.element.android.features.roomlist.impl.search.RoomListSearchPresenterTests" :features:roomdir... | diff --git a/.idea/kotlinc.xml b/.idea/kotlinc.xml
index 8d81632f83e..fe63bb677dc 100644
--- a/.idea/kotlinc.xml
+++ b/.idea/kotlinc.xml
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="KotlinJpsPluginSettings">
- <option name="version" value="1.9.22" />
+ <option... | diff --git a/.maestro/tests/roomList/searchRoomList.yaml b/.maestro/tests/roomList/searchRoomList.yaml
index 8b41c4d259f..5d5e01de84d 100644
--- a/.maestro/tests/roomList/searchRoomList.yaml
+++ b/.maestro/tests/roomList/searchRoomList.yaml
@@ -7,8 +7,4 @@ appId: ${MAESTRO_APP_ID}
- tapOn: ${MAESTRO_ROOM_NAME}
# Back... | {
"io.element.android.features.roomdirectory.impl.root.RoomDirectoryViewTest.clicking on room item emits the expected Event": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.roomlist.impl.search.RoomListSearchPresenterTests.present - room directory search": {
"run": ... | {} | {} | {} |
element-hq__element-x-android-2609 | element-hq | element-x-android | 2,609 | closed | Poll trophy | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Make completed p... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "d3f8962b2bcfbea7bba6e62c6764631d9b573171"
} | [
{
"number": 2608,
"title": "Make completed poll more clearly visible",
"body": "with a 🏆 like on EW:\r\n\r\n\r\n\r\nSee the associated GH issue for context."
}
] | kotlin | Make completed poll more clearly visible
with a 🏆 like on EW:
See the associated GH issue for context.
| null | https://github.com/element-hq/element-x-android/pull/2609 | [
"https://github.com/element-hq/element-x-android/issues/2608"
] | ./gradlew :features:poll:impl:testDebugUnitTest --tests "io.element.android.features.poll.impl.pollcontent.PollContentStateFactoryTest" | diff --git a/changelog.d/2608.misc b/changelog.d/2608.misc
new file mode 100644
index 00000000000..aa2f48b5ccf
--- /dev/null
+++ b/changelog.d/2608.misc
@@ -0,0 +1,1 @@
+ Make completed poll more clearly visible
diff --git a/features/poll/api/src/main/kotlin/io/element/android/features/poll/api/pollcontent/PollAnswerIt... | diff --git a/features/poll/api/src/main/kotlin/io/element/android/features/poll/api/pollcontent/PollContentStateFixtures.kt b/features/poll/api/src/main/kotlin/io/element/android/features/poll/api/pollcontent/PollContentStateFixtures.kt
index 206ee93ce0d..9ec3ec3754d 100644
--- a/features/poll/api/src/main/kotlin/io/el... | {
"io.element.android.features.poll.impl.pollcontent.PollContentStateFactoryTest.Disclosed poll - not ended, some votes, including one from current user": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.poll.impl.pollcontent.PollContentStateFactoryTest.Undisclosed poll -... | {} | {} | {} |
element-hq__element-x-android-2595 | element-hq | element-x-android | 2,595 | closed | Categorise members by role in the ChangeRoles screen | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [x] Other : UI change.
## Content
- Categorises members in different sections by role in... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "d5a5aafcda21a8a6df39f44928dd1922ebcfae6a"
} | [
{
"number": 2593,
"title": "Categorise members by role in the `ChangeRoles` screen",
"body": "In Settings -> Roles and permissions -> Admins or Moderators we want to have a clearer distinction for which members have which roles.\r\n\r\nChanges needed:\r\n\r\n- Add different sections for the 3 main roles... | kotlin | Categorise members by role in the `ChangeRoles` screen
In Settings -> Roles and permissions -> Admins or Moderators we want to have a clearer distinction for which members have which roles.
Changes needed:
- Add different sections for the 3 main roles: Admins, Moderators, Members, in that order, and display the u... | null | https://github.com/element-hq/element-x-android/pull/2595 | [
"https://github.com/element-hq/element-x-android/issues/2593"
] | ./gradlew :features:roomdetails:impl:testDebugUnitTest --tests "io.element.android.features.roomdetails.rolesandpermissions.changeroles.ChangeRolesViewTest" --tests "io.element.android.features.roomdetails.rolesandpermissions.changeroles.ChangeRolesPresenterTests" --tests "io.element.android.features.roomdetails.rolesa... | diff --git a/changelog.d/2593.misc b/changelog.d/2593.misc
new file mode 100644
index 00000000000..e67bfc68e57
--- /dev/null
+++ b/changelog.d/2593.misc
@@ -0,0 +1,1 @@
+Categorise members by role in change roles screen.
diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl... | diff --git a/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/rolesandpermissions/changeroles/ChangeRolesPresenterTests.kt b/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/rolesandpermissions/changeroles/ChangeRolesPresenterTests.kt
index 1dbce1fc53d..... | {
"io.element.android.features.roomdetails.rolesandpermissions.changeroles.ChangeRolesViewTest.passing a 'USER' role throws an exception": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.roomdetails.rolesandpermissions.changeroles.ChangeRolesViewTest.testing removing use... | {} | {} | {} |
element-hq__element-x-android-2545 | element-hq | element-x-android | 2,545 | closed | Use `userId` on display name change state events | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Replaces the first usage of the user's display name with its us... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "70505505111689b5ffab874b4242642c976fe11d"
} | [
{
"number": 2125,
"title": "Show new name just once, not twice in display name change events",
"body": "### Your use case\n\n#### What would you like to do?\r\nSee issue title.\r\n\r\n#### Why would you like to do it?\r\nIt looks quite confusing at first glance, especially with long names that include s... | kotlin | Show new name just once, not twice in display name change events
### Your use case
#### What would you like to do?
See issue title.
#### Why would you like to do it?
It looks quite confusing at first glance, especially with long names that include sentences or `away` text:
![Screenshot_20230927-125549_Element X]... | null | https://github.com/element-hq/element-x-android/pull/2545 | [
"https://github.com/element-hq/element-x-android/issues/2125"
] | ./gradlew :libraries:eventformatter:impl:testDebugUnitTest --tests "io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest" | diff --git a/changelog.d/2125.bugfix b/changelog.d/2125.bugfix
new file mode 100644
index 00000000000..95e6fb769d0
--- /dev/null
+++ b/changelog.d/2125.bugfix
@@ -0,0 +1,1 @@
+Use the display name only once in display name change events. The user should be referenced by `userId` instead.
diff --git a/libraries/eventfor... | diff --git a/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultRoomLastMessageFormatterTest.kt b/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultRoomLastMessageFormatterTest.kt
index b127911cc06..71860937b48 100644... | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Unable to decrypt content": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Membership change - knocked": {
"run": "PASS",... | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Message contents": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Computes last message for poll in DM": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Membership change - kicked": {
"run... | {} |
element-hq__element-x-android-2543 | element-hq | element-x-android | 2,543 | closed | Improve room member list loading UX | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [x] Technical
- [ ] Other :
## Content
- Don't display the list in chunks anymore.
- Use an indetermina... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "4c14ac822ec3fe5c967610531be784516814cd6c"
} | [
{
"number": 2542,
"title": "Improve room member list loading",
"body": "### Your use case\n\n#### What would you like to do?\r\n\r\nImprove how the room member list is loaded for large rooms.\r\n\r\n#### Why would you like to do it?\r\n\r\nAfter the latest changes to improve the member list loading perf... | kotlin | Improve room member list loading
### Your use case
#### What would you like to do?
Improve how the room member list is loaded for large rooms.
#### Why would you like to do it?
After the latest changes to improve the member list loading performance we don't need to chunk the member list to process it anymore.... | null | https://github.com/element-hq/element-x-android/pull/2543 | [
"https://github.com/element-hq/element-x-android/issues/2542"
] | ./gradlew :libraries:matrix:impl:testDebugUnitTest --tests "io.element.android.libraries.matrix.impl.room.member.RoomMemberListFetcherTest" :features:roomdetails:impl:testDebugUnitTest --tests "io.element.android.features.roomdetails.members.RoomMemberListPresenterTests" | diff --git a/changelog.d/2452.misc b/changelog.d/2452.misc
new file mode 100644
index 00000000000..0f16ae8f454
--- /dev/null
+++ b/changelog.d/2452.misc
@@ -0,0 +1,1 @@
+Improve room member list loading UX.
diff --git a/features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomM... | diff --git a/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/members/RoomMemberListPresenterTests.kt b/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/members/RoomMemberListPresenterTests.kt
index e70483356ef..bc7dff92b11 100644
--- a/features/roomdeta... | {
"io.element.android.features.roomdetails.members.RoomMemberListPresenterTests.search for something which is not found": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.roomdetails.members.RoomMemberListPresenterTests.present - asynchronously sets canInvite when user do... | {} | {} | {} |
element-hq__element-x-android-2361 | element-hq | element-x-android | 2,361 | closed | Move migration screen to within the room list | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [x] Other : screen redesign.
## Content
- Moves the `migration` package contents from `:... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "fa17fdaa44ac9e96e20647d704e487e80685f3e1"
} | [
{
"number": 2310,
"title": "Move migration screen to within the room list",
"body": "The current migration screen blocks the user from accessing the rest of the app, especially bug reporting and logs. This is a problem when setting up custom backend stacks.\r\nWe have agreed with product to move it from... | kotlin | Move migration screen to within the room list
The current migration screen blocks the user from accessing the rest of the app, especially bug reporting and logs. This is a problem when setting up custom backend stacks.
We have agreed with product to move it from a modal to a state of the room list similar to what has ... | null | https://github.com/element-hq/element-x-android/pull/2361 | [
"https://github.com/element-hq/element-x-android/issues/2310"
] | ./gradlew :features:roomlist:impl:testDebugUnitTest --tests "io.element.android.features.roomlist.impl.migration.InMemoryMigrationScreenStore" --tests "io.element.android.features.roomlist.impl.RoomListPresenterTests" :features:ftue:impl:testDebugUnitTest --tests "io.element.android.features.ftue.impl.DefaultFtueStateT... | diff --git a/changelog.d/2310.misc b/changelog.d/2310.misc
new file mode 100644
index 00000000000..b5106ad9273
--- /dev/null
+++ b/changelog.d/2310.misc
@@ -0,0 +1,1 @@
+Move migration screen to within the room list
diff --git a/features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/FtueFlowNode.kt b/... | diff --git a/features/ftue/impl/src/test/kotlin/io/element/android/features/ftue/impl/DefaultFtueStateTests.kt b/features/ftue/impl/src/test/kotlin/io/element/android/features/ftue/impl/DefaultFtueStateTests.kt
index 44df35ca052..834aaa5c1f4 100644
--- a/features/ftue/impl/src/test/kotlin/io/element/android/features/ft... | {
"io.element.android.libraries.matrix.impl.auth.AuthenticationExceptionMappingTest.mapping an exception with no message returns 'Unknown error' message": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.matrix.impl.auth.AuthenticationExceptionMappingTest.mapping Oidc re... | {} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-2342 | element-hq | element-x-android | 2,342 | closed | Add an empty state to the room list | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Make `RoomListDataSource.allRooms` a `SharedFlow` so we can kno... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "9fad3f9b235ffb81a2248f869d88dfeb8b639372"
} | [
{
"number": 2330,
"title": "[Task] Add empty state for room list",
"body": "When the user has an empty account, the room list should display an empty state.\r\n\r\n## Designs\r\n\r\nSee [Figma](https://www.figma.com/file/AO7bFhGSUQt4IyBhmW26Cu/Room-List-%2B-Navigation-(new)?type=design&node-id=527%3A538... | kotlin | [Task] Add empty state for room list
When the user has an empty account, the room list should display an empty state.
## Designs
See [Figma](https://www.figma.com/file/AO7bFhGSUQt4IyBhmW26Cu/Room-List-%2B-Navigation-(new)?type=design&node-id=527%3A538&mode=design&t=zk19KUrAiozH0zrJ-1).
| null | https://github.com/element-hq/element-x-android/pull/2342 | [
"https://github.com/element-hq/element-x-android/issues/2330"
] | ./gradlew :features:roomlist:impl:testDebugUnitTest --tests "io.element.android.features.roomlist.impl.RoomListPresenterTests" | diff --git a/changelog.d/2330.feature b/changelog.d/2330.feature
new file mode 100644
index 00000000000..c501ded6465
--- /dev/null
+++ b/changelog.d/2330.feature
@@ -0,0 +1,1 @@
+Add empty state to the room list.
diff --git a/features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListPrese... | diff --git a/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTests.kt b/features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTests.kt
index 839fa04cf79..09d6f12e0c8 100644
--- a/features/roomlist/impl/src/test/kotlin/io/eleme... | {} | {
"io.element.android.libraries.push.impl.notifications.DefaultNotificationDrawerManagerTest.cover all APIs": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-2283 | element-hq | element-x-android | 2,283 | closed | View Folders and logs | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Introduce a `vie... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "6a0e038cb5164d9d3d19a975de0a4ce7b2f8d15f"
} | [
{
"number": 2276,
"title": "In app logs viewer",
"body": "Implement a way to display app logs as the application is running similar to https://github.com/element-hq/element-x-ios/pull/2369"
}
] | kotlin | In app logs viewer
Implement a way to display app logs as the application is running similar to https://github.com/element-hq/element-x-ios/pull/2369
| null | https://github.com/element-hq/element-x-android/pull/2283 | [
"https://github.com/element-hq/element-x-android/issues/2276"
] | ./gradlew :features:viewfolder:impl:testDebugUnitTest --tests "io.element.android.features.viewfolder.test.file.ViewFilePresenterTest" --tests "io.element.android.features.viewfolder.test.folder.ViewFolderPresenterTest" | diff --git a/appnav/build.gradle.kts b/appnav/build.gradle.kts
index 9407b165927..4e436ec7189 100644
--- a/appnav/build.gradle.kts
+++ b/appnav/build.gradle.kts
@@ -52,6 +52,7 @@ dependencies {
implementation(libs.coil)
implementation(projects.features.ftue.api)
+ implementation(projects.features.viewfol... | diff --git a/features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/bugreport/FakeBugReporter.kt b/features/rageshake/impl/src/test/kotlin/io/element/android/features/rageshake/impl/bugreport/FakeBugReporter.kt
index 2cd9e61398f..0a67a79f578 100644
--- a/features/rageshake/impl/src/test/kotl... | {} | {
"io.element.android.features.viewfolder.test.folder.ViewFolderPresenterTest.present - list items from root": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.features.viewfolder.test.folder.ViewFolderPresenterTest.present - list items from a folder": {
"run": "FAIL",
"te... | {} | {} |
element-hq__element-x-android-2225 | element-hq | element-x-android | 2,225 | closed | Hide verbose state events from the timeline | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
Added a filter for the timeline items that removes 'hidden' or 'n... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "f281c6c36516c35225155cea2b9ac5f5b4e8d72a"
} | [
{
"number": 2216,
"title": "Remove verbose state events from the timeline",
"body": "When creating a room, we can see at least 7 state events being added to the timeline:\r\n\r\n- Who created the room (`m.room.create`).\r\n- The same person joining the room (`m.room.member` with membership `join`).\r\n-... | kotlin | Remove verbose state events from the timeline
When creating a room, we can see at least 7 state events being added to the timeline:
- Who created the room (`m.room.create`).
- The same person joining the room (`m.room.member` with membership `join`).
- The room power levels being set (`m.room.power_levels`).
- Th... | null | https://github.com/element-hq/element-x-android/pull/2225 | [
"https://github.com/element-hq/element-x-android/issues/2216"
] | ./gradlew :libraries:matrix:impl:testDebugUnitTest --tests "io.element.android.libraries.matrix.impl.timeline.postprocessor.FilterHiddenStateEventsProcessorTest" | diff --git a/changelog.d/2216.bugfix b/changelog.d/2216.bugfix
new file mode 100644
index 00000000000..a47f2976b54
--- /dev/null
+++ b/changelog.d/2216.bugfix
@@ -0,0 +1,1 @@
+Hide verbose state events from the timeline
diff --git a/libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/timeline/i... | diff --git a/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/timeline/postprocessor/FilterHiddenStateEventsProcessorTest.kt b/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/timeline/postprocessor/FilterHiddenStateEventsProcessorTest.kt
new file mode 100644
... | {} | {
"io.element.android.libraries.matrix.impl.timeline.postprocessor.FilterHiddenStateEventsProcessorTest.test": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
element-hq__element-x-android-2197 | element-hq | element-x-android | 2,197 | closed | Make the room settings screen update automatically | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
Makes the room name, topic and avatar update with the `RoomInfo` ... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "72253c081bedc52c976e4872bf6c7873893ce724"
} | [
{
"number": 921,
"title": "Local echo for new room picture isn't there",
"body": "### Steps to reproduce\n\n1. Go to a room where you are admin\r\n2. Change the room avatar\r\n3. Save\n\n### Outcome\n\n#### What did you expect?\r\nI see a local echo of the room avatar when I land back in the room detail... | kotlin | Local echo for new room picture isn't there
### Steps to reproduce
1. Go to a room where you are admin
2. Change the room avatar
3. Save
### Outcome
#### What did you expect?
I see a local echo of the room avatar when I land back in the room detail view after saving the new photo
#### What happened instead?
I... | Should be possible now that we have https://github.com/matrix-org/matrix-rust-sdk/pull/2411
Well, not so easy. It's the same thing as sending media, we can't have a local echo before the image is uploaded. This will be fixed by the async upload MSC (Synapse PR still pending merge).
It does not need to be a "local echo"... | https://github.com/element-hq/element-x-android/pull/2197 | [
"https://github.com/element-hq/element-x-android/issues/921"
] | ./gradlew :features:roomdetails:impl:testDebugUnitTest --tests "io.element.android.features.roomdetails.RoomDetailsPresenterTests" | diff --git a/changelog.d/921.bugfix b/changelog.d/921.bugfix
new file mode 100644
index 00000000000..939455b1779
--- /dev/null
+++ b/changelog.d/921.bugfix
@@ -0,0 +1,1 @@
+Make the room settings screen update automatically when new room info (name, avatar, topic) is available.
diff --git a/features/roomdetails/impl/sr... | diff --git a/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/RoomDetailsPresenterTests.kt b/features/roomdetails/impl/src/test/kotlin/io/element/android/features/roomdetails/RoomDetailsPresenterTests.kt
index 0a25434339c..95deffad315 100644
--- a/features/roomdetails/impl/src/test/kotl... | {} | {
"io.element.android.libraries.push.impl.notifications.DefaultNotificationDrawerManagerTest.cover all APIs": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-2166 | element-hq | element-x-android | 2,166 | closed | Introduce AsyncAction with a Confirmation state and use it for logout action | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Add `AsyncAction... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "0ca9780337441ebee8a205a712ece8cfd22cdaaf"
} | [
{
"number": 2165,
"title": "Fix flaky test `present - logout then confirm`",
"body": "We have a flaky test on CI: `present - logout then confirm`, which fails from time to time in release mode, for instance here: https://github.com/element-hq/element-x-android/actions/runs/7410156372/job/20161825022?pr=... | kotlin | Fix flaky test `present - logout then confirm`
We have a flaky test on CI: `present - logout then confirm`, which fails from time to time in release mode, for instance here: https://github.com/element-hq/element-x-android/actions/runs/7410156372/job/20161825022?pr=2164
Extract of `element-x-android/features/logout/i... | null | https://github.com/element-hq/element-x-android/pull/2166 | [
"https://github.com/element-hq/element-x-android/issues/2165"
] | ./gradlew :features:createroom:impl:testDebugUnitTest --tests "io.element.android.features.createroom.impl.DefaultStartDMActionTests" --tests "io.element.android.features.createroom.impl.root.CreateRoomRootPresenterTests" :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.repor... | diff --git a/features/call/src/main/kotlin/io/element/android/features/call/ui/CallScreenPresenter.kt b/features/call/src/main/kotlin/io/element/android/features/call/ui/CallScreenPresenter.kt
index 6883ebeb61f..d43557c6b19 100644
--- a/features/call/src/main/kotlin/io/element/android/features/call/ui/CallScreenPresent... | diff --git a/features/call/src/test/kotlin/io/element/android/features/call/ui/CallScreenPresenterTest.kt b/features/call/src/test/kotlin/io/element/android/features/call/ui/CallScreenPresenterTest.kt
index 77f83de2098..2b5365118e6 100644
--- a/features/call/src/test/kotlin/io/element/android/features/call/ui/CallScree... | {} | {
"io.element.android.libraries.push.impl.notifications.DefaultNotificationDrawerManagerTest.cover all APIs": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-2040 | element-hq | element-x-android | 2,040 | closed | fix linkify | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Ensure message w... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "4c987c5b3fe1e00b82bd506b6aba9de9385456ce"
} | [
{
"number": 2038,
"title": "Messages are not linkified anymore",
"body": "- send a message containing a link\r\n- observe that the link is not rendered correctly and not clickable\r\n\r\n<img width=\"345\" alt=\"image\" src=\"https://github.com/element-hq/element-x-android/assets/3940906/20ed590a-9f25-4... | kotlin | Messages are not linkified anymore
- send a message containing a link
- observe that the link is not rendered correctly and not clickable
<img width="345" alt="image" src="https://github.com/element-hq/element-x-android/assets/3940906/20ed590a-9f25-45f9-9b26-fde10176a145">
| null | https://github.com/element-hq/element-x-android/pull/2040 | [
"https://github.com/element-hq/element-x-android/issues/2038"
] | ./gradlew :features:poll:impl:testDebugUnitTest --tests "io.element.android.features.poll.impl.history.PollHistoryPresenterTest" :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.timeline.factories.event.TimelineItemContentMessageFactoryTest" :features:preferences:impl:testDeb... | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/factories/event/TimelineItemContentMessageFactory.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/factories/event/TimelineItemContentMessageFactory.kt
index 77e514fa608..... | diff --git a/appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt
index fcfba8f7a1b..d7b951fbbc4 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/loggedin/LoggedInPresenterTest.kt
+++ b/appnav... | {} | {
"io.element.android.libraries.push.impl.notifications.NotificationFactoryTest.given a room invitation when mapping to notification then is Append": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-2035 | element-hq | element-x-android | 2,035 | closed | Scroll to bottom if the new event is from me, even if sent from another session | This fixes the issue that the timeline does not scroll when sending an attachment to the room, since there is no local echo (yet) for such event.
<!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of cha... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "7283732f3bda6fbfe58ffa2532515acf6dc3578e"
} | [
{
"number": 1877,
"title": "Scroll to end of timeline when sending a new message",
"body": "As a user that has send a message I want the timeline to scroll to that message at the end of the timeline so that I can have a look at what I just send."
}
] | kotlin | Scroll to end of timeline when sending a new message
As a user that has send a message I want the timeline to scroll to that message at the end of the timeline so that I can have a look at what I just send.
| If I may chime in, this sounds like it would make reading message backlogs and sending replies as I'm reading much more inconvenient, unless there's a reliable "back to last (un)read" feature coming too, to quickly jump back to where I was right before that automatic scroll.
> unless there's a reliable "back to last (u... | https://github.com/element-hq/element-x-android/pull/2035 | [
"https://github.com/element-hq/element-x-android/issues/1877"
] | ./gradlew :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.impl.timeline.TimelinePresenterTest" | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenter.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenter.kt
index 799f6aa1686..718c32c67c9 100644
--- a/features/messages/impl/src/main/kotlin/... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/impl/timeline/TimelinePresenterTest.kt
index 4316750a6a2..eaf61896fb1 100644
--- a/features/messages/impl/src/test... | {} | {
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given no notifications when rendering then cancels summary notification": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-2013 | element-hq | element-x-android | 2,013 | closed | Fix title of sign out screen regarding the different states | <!-- Please read [CONTRIBUTING.md](https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [X] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Fix title of sig... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "a96d5ca5a6da669c3444200900f5cc1b9e36f121"
} | [
{
"number": 2009,
"title": "On logout it's saying that backup is off but it's not",
"body": "Logout screen:\r\n\r\n<img width=\"320\" alt=\"image\" src=\"https://github.com/element-hq/element-x-android/assets/9841565/055a1fcf-a2b1-42a9-a6e7-cc4502ad1d7e\">\r\n\r\nAnd settings\r\n\r\n<img width=\"338\" a... | kotlin | On logout it's saying that backup is off but it's not
Logout screen:
<img width="320" alt="image" src="https://github.com/element-hq/element-x-android/assets/9841565/055a1fcf-a2b1-42a9-a6e7-cc4502ad1d7e">
And settings
<img width="338" alt="image" src="https://github.com/element-hq/element-x-android/assets/9841... | null | https://github.com/element-hq/element-x-android/pull/2013 | [
"https://github.com/element-hq/element-x-android/issues/2009"
] | ./gradlew :features:logout:impl:testDebugUnitTest --tests "io.element.android.features.logout.impl.LogoutPresenterTest" | diff --git a/features/logout/impl/src/main/kotlin/io/element/android/features/logout/impl/LogoutPresenter.kt b/features/logout/impl/src/main/kotlin/io/element/android/features/logout/impl/LogoutPresenter.kt
index ff76bde7764..b8d8772104d 100644
--- a/features/logout/impl/src/main/kotlin/io/element/android/features/logo... | diff --git a/features/logout/impl/src/test/kotlin/io/element/android/features/logout/impl/LogoutPresenterTest.kt b/features/logout/impl/src/test/kotlin/io/element/android/features/logout/impl/LogoutPresenterTest.kt
index 9b06e71ba35..75401c290ae 100644
--- a/features/logout/impl/src/test/kotlin/io/element/android/featu... | {} | {
"io.element.android.libraries.push.impl.notifications.DefaultNotificationDrawerManagerTest.react to applicationStateChange": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-2001 | element-hq | element-x-android | 2,001 | closed | Fix notification avatar | <!-- Please read [CONTRIBUTING.md](https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
Use ImageLoader a... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "33a2284f898b840cf0f9d59ca31a71ff250cf6a3"
} | [
{
"number": 1991,
"title": "User avatar are not always displayed in notification",
"body": "Sometimes the letter is used instead.\r\n\r\nAlso the notifications are not rendering images, as it was the case on Element Android."
}
] | kotlin | User avatar are not always displayed in notification
Sometimes the letter is used instead.
Also the notifications are not rendering images, as it was the case on Element Android.
| I'm on GHA debug build of 0a16af1d4ffc8911b949eb8c696f75dbbbe4f2c5, and it seems that if app is in recents, then the avatar images appear in notifications. If the app has been removed from recents, the images don't appear, even in subsequent notifications, and even after removing the first notification and receiving ne... | https://github.com/element-hq/element-x-android/pull/2001 | [
"https://github.com/element-hq/element-x-android/issues/1991"
] | ./gradlew :libraries:push:impl:testDebugUnitTest --tests "io.element.android.libraries.push.impl.notifications.RoomGroupMessageCreatorTest" --tests "io.element.android.libraries.push.impl.notifications.DefaultNotificationDrawerManagerTest" --tests "io.element.android.libraries.push.impl.notifications.NotificationFactor... | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInAppScopeFlowNode.kt b/appnav/src/main/kotlin/io/element/android/appnav/LoggedInAppScopeFlowNode.kt
index 7f36a7a51a5..423228c110d 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/LoggedInAppScopeFlowNode.kt
+++ b/appnav/src/main/kotlin/i... | diff --git a/libraries/permissions/impl/src/test/kotlin/io/element/android/libraries/permissions/impl/FakeComposablePermissionStateProvider.kt b/libraries/permissions/impl/src/test/kotlin/io/element/android/libraries/permissions/impl/FakeComposablePermissionStateProvider.kt
index 900d9ccc698..948cc603c33 100644
--- a/l... | {} | {
"io.element.android.libraries.push.impl.notifications.RoomGroupMessageCreatorTest.test createRoomMessage with room avatar and sender avatar android P": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.RoomGroupMessageCreatorTest.test createRoomM... | {
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given last simple notification is removed when rendering then remove the summary and then remove simple notification": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notification... | {} |
element-hq__element-x-android-1846 | element-hq | element-x-android | 1,846 | closed | Add special notifications for mentions | <!-- Please read [CONTRIBUTING.md](https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Sets a special type of notification message for received message... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "12b319647113c9e9cc80bf57600976a39508ff4b"
} | [
{
"number": 1451,
"title": "Mentions: Push notifications display user mentions differently",
"body": "From element-x-ios created by [Velin92](https://github.com/Velin92): vector-im/element-x-ios#1825 \r\n\r\nMentions should be displayed with @username in the notification (however since the username is ... | kotlin | Mentions: Push notifications display user mentions differently
From element-x-ios created by [Velin92](https://github.com/Velin92): vector-im/element-x-ios#1825
Mentions should be displayed with @username in the notification (however since the username is usually not available in the notification context, is also ... | null | https://github.com/element-hq/element-x-android/pull/1846 | [
"https://github.com/element-hq/element-x-android/issues/1451"
] | ./gradlew :libraries:push:impl:testDebugUnitTest --tests "io.element.android.libraries.push.impl.notifications.NotifiableEventResolverTest" | diff --git a/changelog.d/1451.feature b/changelog.d/1451.feature
new file mode 100644
index 00000000000..1869f0ecd50
--- /dev/null
+++ b/changelog.d/1451.feature
@@ -0,0 +1,1 @@
+Display different notifications for mentions.
diff --git a/libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notific... | diff --git a/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/notifications/NotifiableEventResolverTest.kt b/libraries/push/impl/src/test/kotlin/io/element/android/libraries/push/impl/notifications/NotifiableEventResolverTest.kt
index 819a1e94a23..6276983cc9d 100644
--- a/libraries/push/impl/s... | {
"io.element.android.libraries.push.impl.notifications.NotifiableEventResolverTest.resolve event message with mention": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotifiableEventResolverTest.resolve event failure": {
"run": "PASS",
... | {
"io.element.android.libraries.push.impl.notifications.NotifiableEventResolverTest.resolve incorrectly formatted event message text uses fallback": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-1799 | element-hq | element-x-android | 1,799 | closed | Integrate mentions in the composer | <!-- Please read [CONTRIBUTING.md](https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [x] Feature
- [ ] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Integrates a new version of the RTE library with better support ... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "4585597715f46c1dc9c4b04a501c654f494a252b"
} | [
{
"number": 1453,
"title": "Mentions: @room mention pill",
"body": "From element-x-ios created by [Velin92](https://github.com/Velin92): vector-im/element-x-ios#1829 \r\n\r\nThis is a special case, but the string @room should be interpreted as a special mention case and display a pill with probably its... | kotlin | Mentions: @room mention pill
From element-x-ios created by [Velin92](https://github.com/Velin92): vector-im/element-x-ios#1829
This is a special case, but the string @room should be interpreted as a special mention case and display a pill with probably its own different design.
Also it should display the room ava... | null | https://github.com/element-hq/element-x-android/pull/1799 | [
"https://github.com/element-hq/element-x-android/issues/1453"
] | ./gradlew :libraries:textcomposer:impl:testDebugUnitTest --tests "io.element.android.libraries.textcomposer.impl.mentions.MentionSpanProviderTest" :features:messages:impl:testDebugUnitTest --tests "io.element.android.features.messages.textcomposer.MessageComposerPresenterTest" | diff --git a/changelog.d/1453.feature b/changelog.d/1453.feature
new file mode 100644
index 00000000000..86cc90ad74f
--- /dev/null
+++ b/changelog.d/1453.feature
@@ -0,0 +1,1 @@
+Add support for typing mentions in the message composer.
diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/mess... | diff --git a/features/messages/impl/src/test/kotlin/io/element/android/features/messages/textcomposer/MessageComposerPresenterTest.kt b/features/messages/impl/src/test/kotlin/io/element/android/features/messages/textcomposer/MessageComposerPresenterTest.kt
index f05c209085f..ef587925524 100644
--- a/features/messages/i... | {
"io.element.android.libraries.textcomposer.impl.mentions.MentionSpanProviderTest.getting mention span for other user should return a MentionSpan with normal colors": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.textcomposer.impl.mentions.MentionSpanProviderTest.get... | {} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-1770 | element-hq | element-x-android | 1,770 | closed | Show full history if key backup is enabled. | <!-- Please read [CONTRIBUTING.md](https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
<!-- Describe shortly what has been changed -->
If KeyBackup is e... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "ede72b069cc8067df08b6b0cfac882a691e80815"
} | [
{
"number": 1768,
"title": "KeyBackup: do not show the \"Message history\" banner if key backup is set up.",
"body": "Show all the messages instead, even if they cannot be decrypted."
}
] | kotlin | KeyBackup: do not show the "Message history" banner if key backup is set up.
Show all the messages instead, even if they cannot be decrypted.
| null | https://github.com/element-hq/element-x-android/pull/1770 | [
"https://github.com/element-hq/element-x-android/issues/1768"
] | ./gradlew :libraries:matrix:impl:testDebugUnitTest --tests "io.element.android.libraries.matrix.impl.timeline.postprocessor.TimelineEncryptedHistoryPostProcessorTest" | diff --git a/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/RustMatrixClient.kt b/libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/RustMatrixClient.kt
index 99dd0af8fd7..035add9ab2c 100644
--- a/libraries/matrix/impl/src/main/kotlin/io/element/android/librar... | diff --git a/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/timeline/postprocessor/TimelineEncryptedHistoryPostProcessorTest.kt b/libraries/matrix/impl/src/test/kotlin/io/element/android/libraries/matrix/impl/timeline/postprocessor/TimelineEncryptedHistoryPostProcessorTest.kt
index 63920... | {
"io.element.android.libraries.matrix.impl.timeline.postprocessor.TimelineEncryptedHistoryPostProcessorTest.given a list with no items before lastLoginTimestamp, nothing is done": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.matrix.impl.auth.AuthenticationExceptionM... | {} | {
"io.element.android.libraries.push.impl.notifications.NotificationEventQueueTest.when clearing then is empty": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.push.impl.notifications.NotificationRendererTest.given a simple notification is added when rendering then sho... | {} |
element-hq__element-x-android-1767 | element-hq | element-x-android | 1,767 | closed | Feature/bma/encrypted messages | <!-- Please read [CONTRIBUTING.md](https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [ ] Bugfix
- [ ] Technical
- [x] Other : wording
## Content
<!-- Describe shortly what has been changed -->
Wording c... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "e4a8e369c1f7dd7d62d72f067c5ada9b86c3e424"
} | [
{
"number": 1754,
"title": "KeyBackup: use common_waiting_for_decryption_key for message which cannot be decrypted",
"body": null
}
] | kotlin | KeyBackup: use common_waiting_for_decryption_key for message which cannot be decrypted
| null | https://github.com/element-hq/element-x-android/pull/1767 | [
"https://github.com/element-hq/element-x-android/issues/1754"
] | ./gradlew :libraries:eventformatter:impl:testDebugUnitTest --tests "io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest" | diff --git a/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemEncryptedView.kt b/features/messages/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/components/event/TimelineItemEncryptedView.kt
index 462edb1e606..23c698cfc61 10... | diff --git a/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultRoomLastMessageFormatterTest.kt b/libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultRoomLastMessageFormatterTest.kt
index e9d91fbb8c3..f7b98626e66 100644... | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Unable to decrypt content": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Room state change - create": {
"run": "NONE",
... | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Message contents": {
"run": "FAIL",
"test": "FAIL",
"fix": "PASS"
}
} | {
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Membership change - knocked": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"io.element.android.libraries.eventformatter.impl.DefaultRoomLastMessageFormatterTest.Computes last message for poll in DM": {
"ru... | {} |
element-hq__element-x-android-1175 | element-hq | element-x-android | 1,175 | closed | Make sure Snackbars are only displayed once | <!-- Please read [CONTRIBUTING.md](https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md) before submitting your pull request -->
## Type of change
- [ ] Feature
- [x] Bugfix
- [ ] Technical
- [ ] Other :
## Content
- Made `SnackbarDispatcher.snackbarMessage` a Flow backed by a que... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "5a85459ec2e8d1d3ad2d6d68ffbb7eb6b250ec1e"
} | [
{
"number": 928,
"title": "\"Verification complete\" snackbar is shown too much",
"body": "1. Login to an account and verify the session.\r\n2. The snackbar is displayed, this is fine\r\n3. Pause and resume the app\r\n4. The Snackbar is displayed again.\r\n\r\n3 and 4 can be repeated indefinitely.\r\n\r... | kotlin | "Verification complete" snackbar is shown too much
1. Login to an account and verify the session.
2. The snackbar is displayed, this is fine
3. Pause and resume the app
4. The Snackbar is displayed again.
3 and 4 can be repeated indefinitely.
Kill the app and restarting it fixes the issue.
A tentative fix w... | null | https://github.com/element-hq/element-x-android/pull/1175 | [
"https://github.com/element-hq/element-x-android/issues/928"
] | ./gradlew :libraries:designsystem:testDebugUnitTest --tests "io.element.android.libraries.designsystem.utils.SnackbarDispatcherTests" | diff --git a/changelog.d/928.bugfix b/changelog.d/928.bugfix
new file mode 100644
index 00000000000..98a4cd34e06
--- /dev/null
+++ b/changelog.d/928.bugfix
@@ -0,0 +1,1 @@
+Make sure Snackbars are only displayed once.
diff --git a/libraries/designsystem/build.gradle.kts b/libraries/designsystem/build.gradle.kts
index 3... | diff --git a/libraries/designsystem/src/test/kotlin/io/element/android/libraries/designsystem/utils/SnackbarDispatcherTests.kt b/libraries/designsystem/src/test/kotlin/io/element/android/libraries/designsystem/utils/SnackbarDispatcherTests.kt
new file mode 100644
index 00000000000..3eb644d8008
--- /dev/null
+++ b/libra... | {
"io.element.android.libraries.designsystem.utils.SnackbarDispatcherTests.given 2 message emissions, the next message is displayed only after a call to clear": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.libraries.designsystem.utils.SnackbarDispatcherTests.given an empty que... | {} | {} | {} |
element-hq__element-x-android-1127 | element-hq | element-x-android | 1,127 | closed | Enable OIDC support | - upgrade to SDK 0.1.45
## Oidc
- enable OIDC (remove the TODO and update the code)
- add setting entry point to configure account (with Localazy English sync to get `screen_settings_oidc_account`)
- require a database migration to add `oidcData` field from the SDK.
- Open URL on signout if provided (no url is... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "7eb1f1c7bfef5612e773b66a65612bab0e4f30c1"
} | [
{
"number": 1114,
"title": "Finish OIDC integration",
"body": "OIDC has been merged into the SDK\r\n\r\nA couple of changes worth pointing out:\r\n\r\n- [x] Client.accountURL contains a URL to be presented from an Account and devices button in the Settings screen.\r\n- [x] Client.logout now returns an o... | kotlin | Finish OIDC integration
OIDC has been merged into the SDK
A couple of changes worth pointing out:
- [x] Client.accountURL contains a URL to be presented from an Account and devices button in the Settings screen.
- [x] Client.logout now returns an optional URL. When the URL is there, it should be presented to the... | null | https://github.com/element-hq/element-x-android/pull/1127 | [
"https://github.com/element-hq/element-x-android/issues/1114"
] | ./gradlew :features:preferences:impl:testDebugUnitTest --tests "io.element.android.features.preferences.impl.root.PreferencesRootPresenterTest" :features:login:impl:testDebugUnitTest --tests "io.element.android.features.login.impl.screens.confirmaccountprovider.ConfirmAccountProviderPresenterTest" | diff --git a/changelog.d/1127.feature b/changelog.d/1127.feature
new file mode 100644
index 00000000000..da2c6b3cf1b
--- /dev/null
+++ b/changelog.d/1127.feature
@@ -0,0 +1,1 @@
+Enable OIDC support.
diff --git a/docs/oidc.md b/docs/oidc.md
index 5f9e70268d4..0e4ad448529 100644
--- a/docs/oidc.md
+++ b/docs/oidc.md
@@ ... | diff --git a/features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderPresenterTest.kt b/features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/confirmaccountprovider/ConfirmAccountProviderPresenterTest.kt
index 76a3ad3d2... | {
"io.element.android.features.login.impl.screens.confirmaccountprovider.ConfirmAccountProviderPresenterTest.present - clear error": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.login.impl.screens.confirmaccountprovider.ConfirmAccountProviderPresenterTest.present - co... | {} | {} | {} |
element-hq__element-x-android-867 | element-hq | element-x-android | 867 | closed | Fix: make sure we ignore notifications for open rooms | ## Changes
To ignore notifications for the currently displayed room, we were previously checking `ProcessLifecycleOwner.get().lifecycle` in `NotifiableMessageEvent`. However, this value seems to always return the `INITIALIZED`, not ever updating.
The new changes add an observer that publishes the current app stat... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "c919618bc0152de22c2ac2b36ed911a2c59e06e8"
} | [
{
"number": 866,
"title": "Notifications are displayed for messages sent to the current room",
"body": "### Steps to reproduce\n\n1. Open a room in the app.\r\n2. From another client, send a message.\r\n\n\n### Outcome\n\n#### What did you expect?\r\n\r\nSince the room is already displayed, no notificat... | kotlin | Notifications are displayed for messages sent to the current room
### Steps to reproduce
1. Open a room in the app.
2. From another client, send a message.
### Outcome
#### What did you expect?
Since the room is already displayed, no notification should be displayed.
#### What happened instead?
The notif... | null | https://github.com/element-hq/element-x-android/pull/867 | [
"https://github.com/element-hq/element-x-android/issues/866"
] | ./gradlew :appnav:testDebugUnitTest --tests "io.element.android.appnav.RoomFlowNodeTest" :services:appnavstate:impl:testDebugUnitTest --tests "io.element.android.services.appnavstate.impl.DefaultNavigationStateServiceTest" :tests:testutils:testDebugUnitTest --tests "io.element.android.tests.testutils.RunCancellableTest... | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index dd198cd5aad..32bfd40629b 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -209,6 +209,7 @@ dependencies {
implementation(libs.androidx.core)
implementation(libs.androidx.corektx)
implementation(libs.androidx.lifecycle.runtime)
... | diff --git a/appnav/src/test/kotlin/io/element/android/appnav/RoomFlowNodeTest.kt b/appnav/src/test/kotlin/io/element/android/appnav/RoomFlowNodeTest.kt
index 0f5dcd84f6f..48efd778084 100644
--- a/appnav/src/test/kotlin/io/element/android/appnav/RoomFlowNodeTest.kt
+++ b/appnav/src/test/kotlin/io/element/android/appnav... | {
"io.element.android.services.appnavstate.impl.DefaultNavigationStateServiceTest.testFailure": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.services.appnavstate.impl.DefaultNavigationStateServiceTest.testNavigation": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
... | {} | {} | {} |
element-hq__element-x-android-781 | element-hq | element-x-android | 781 | closed | Implement waiting list screen (error IO_ELEMENT_X_WAIT_LIST) | Closes #768
Only the first screen is used, and the "You're in" screen are displayed (no "setting up your account" screen, which may be handled later, and anyway not in the `:login` module).
Dark and light are identical (so we have some hard-coded colors), only the dialog colors may change.
## Demo:
|Withou... | {
"label": "element-hq:develop",
"ref": "develop",
"sha": "fdffb8ca817940bc9e30a5f9c7b6f0b4d03fcc91"
} | [
{
"number": 768,
"title": "Waiting list screen - Implement `IO_ELEMENT_X_WAIT_LIST` error code on `/login`",
"body": "As a user, I want to understand why I cannot login and how I can be part of this allow list defined on my homeserver.\r\n\r\niOS PRs:\r\n- https://github.com/vector-im/element-x-ios/pull... | kotlin | Waiting list screen - Implement `IO_ELEMENT_X_WAIT_LIST` error code on `/login`
As a user, I want to understand why I cannot login and how I can be part of this allow list defined on my homeserver.
iOS PRs:
- https://github.com/vector-im/element-x-ios/pull/1165
- https://github.com/vector-im/element-x-ios/pull/118... | null | https://github.com/element-hq/element-x-android/pull/781 | [
"https://github.com/element-hq/element-x-android/issues/768"
] | ./gradlew :features:login:impl:testDebugUnitTest --tests "io.element.android.features.login.impl.screens.loginpassword.LoginPasswordPresenterTest" --tests "io.element.android.features.login.impl.screens.waitlistscreen.WaitListPresenterTest" | diff --git a/appnav/src/main/kotlin/io/element/android/appnav/RootFlowNode.kt b/appnav/src/main/kotlin/io/element/android/appnav/RootFlowNode.kt
index 733485fcef0..ba01d152976 100644
--- a/appnav/src/main/kotlin/io/element/android/appnav/RootFlowNode.kt
+++ b/appnav/src/main/kotlin/io/element/android/appnav/RootFlowNod... | diff --git a/features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/loginpassword/LoginPasswordPresenterTest.kt b/features/login/impl/src/test/kotlin/io/element/android/features/login/impl/screens/loginpassword/LoginPasswordPresenterTest.kt
index c4c8a971556..afd4b542e41 100644
--- a/feature... | {
"io.element.android.features.login.impl.screens.loginpassword.LoginPasswordPresenterTest.present - initial state": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"io.element.android.features.login.impl.screens.loginpassword.LoginPasswordPresenterTest.present - submit": {
"run": "PASS",
"t... | {} | {} | {} |
JackEblan__Geto-167 | JackEblan | Geto | 167 | closed | Fixed the bug where Shortcut Dialog is not displaying correctly | _Thanks for submitting a pull request. Please include the following information._
**What I have done and why**
_Include a summary of what your pull request contains, and why you have made these changes._
Fixes #161
**How I'm testing it**
_Choose at least one:_
- Unit tests
- UI tests
- Screenshot te... | {
"label": "JackEblan:master",
"ref": "master",
"sha": "7713133358d2eac6615e06d3085babec90a6056a"
} | [
{
"number": 161,
"title": "Shortcut Dialog is not displaying correctly",
"body": "https://github.com/JackEblan/Geto/blob/0a77dd35c190b830c84e0ac3c29210fdf4d00fa7/feature/app-settings/src/main/kotlin/com/android/geto/feature/appsettings/AppSettingsScreen.kt#L360\r\n\r\nIf you click the **Add Shortcut** b... | kotlin | Shortcut Dialog is not displaying correctly
https://github.com/JackEblan/Geto/blob/0a77dd35c190b830c84e0ac3c29210fdf4d00fa7/feature/app-settings/src/main/kotlin/com/android/geto/feature/appsettings/AppSettingsScreen.kt#L360
If you click the **Add Shortcut** button, a dialog will pop-up on which you can add your home... | null | https://github.com/JackEblan/Geto/pull/167 | [
"https://github.com/JackEblan/Geto/issues/161"
] | ./gradlew :feature:app-settings:testDebugUnitTest --tests "com.android.geto.feature.appsettings.AppSettingsScreenSnackbarScreenshotTest" --tests "com.android.geto.feature.appsettings.AppSettingsScreenScreenshotTest" --tests "com.android.geto.feature.appsettings.AppSettingsViewModelTest" :core:domain:testDebugUnitTest -... | diff --git a/.idea/deploymentTargetSelector.xml b/.idea/deploymentTargetSelector.xml
index f2d18c282..58348ea13 100644
--- a/.idea/deploymentTargetSelector.xml
+++ b/.idea/deploymentTargetSelector.xml
@@ -8,13 +8,13 @@
<SelectionState runConfigName="Generate Baseline Profile for app">
<option name="sele... | diff --git a/core/domain/src/test/kotlin/com/android/geto/core/domain/GetShortcutUseCaseTest.kt b/core/domain/src/test/kotlin/com/android/geto/core/domain/GetShortcutUseCaseTest.kt
new file mode 100644
index 000000000..0e325798b
--- /dev/null
+++ b/core/domain/src/test/kotlin/com/android/geto/core/domain/GetShortcutUse... | {
"com.android.geto.feature.appsettings.AppSettingsViewModelTest.revertAppSettingsResult_isEmptyAppSettings_whenRevertAppSettings": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.android.geto.feature.appsettings.AppSettingsViewModelTest.secureSettings_isNotEmpty_whenGetSecureSettingsByName_ofS... | {} | {} | {} |
LemmyNet__jerboa-1632 | LemmyNet | jerboa | 1,632 | closed | Make sup/subscript more strict | Fixes #1628 | {
"label": "LemmyNet:main",
"ref": "main",
"sha": "8d61114b2e686531892eb841e5937945be56fc4f"
} | [
{
"number": 1628,
"title": "Markdown rending subtext ",
"body": "### Jerboa Version\r\n\r\n0.0.71\r\n\r\n### Android Version + Phone\r\n\r\nN/a\r\n\r\n### Describe The Bug\r\n\r\n\r\n\r\n
This should no... | Part of that `ScriptRewriteSupportPlugin`. We need to look at how other markwon projects are adding super / subscript support.
[Here's a sample](https://github.com/noties/Markwon/blob/master/app-sample/src/main/java/io/noties/markwon/app/samples/parser/RedditSuperscriptSample.kt)
We just need a better definition. I ... | https://github.com/LemmyNet/jerboa/pull/1632 | [
"https://github.com/LemmyNet/jerboa/issues/1628"
] | ./gradlew :app:testDebugUnitTest --tests "com.jerboa.util.markwon.ScriptRewriteSupportPluginTest" | diff --git a/app/src/main/java/com/jerboa/util/markwon/ScriptRewriteSupportPlugin.kt b/app/src/main/java/com/jerboa/util/markwon/ScriptRewriteSupportPlugin.kt
index 49a00dab4..9862a46a6 100644
--- a/app/src/main/java/com/jerboa/util/markwon/ScriptRewriteSupportPlugin.kt
+++ b/app/src/main/java/com/jerboa/util/markwon/S... | diff --git a/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt b/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt
index 0164bacf4..eebd3639a 100644
--- a/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt
+++ b/app/src/test/java/com/jerboa/ut... | {
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy script to markwon script(~2~ ~2~, <sub>2</sub> <sub>2</sub>) [8]": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy scrip... | {
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy script to markwon script(^, ^) [17]": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy script to markwon script(^99 ^, ^99 ^) [23]": {
"run":... | {} | {} |
LemmyNet__jerboa-1445 | LemmyNet | jerboa | 1,445 | closed | Fix Strikethrough rendering | Fixes #1444 | {
"label": "LemmyNet:main",
"ref": "main",
"sha": "c3cf9e09aa283f87b66824928d9ba609ce1bd03f"
} | [
{
"number": 1444,
"title": "Markdown strikethrough broken since new update",
"body": "### Jerboa Version\r\n\r\n0.0.62\r\n\r\n### Android Version + Phone\r\n\r\nAndroid 13 Samsung a53\r\n\r\n### Describe The Bug\r\n\r\nHello :)\r\n\r\nSince the last commit (ac39d872a805767d7910531c7619754744b670c8) stri... | kotlin | Markdown strikethrough broken since new update
### Jerboa Version
0.0.62
### Android Version + Phone
Android 13 Samsung a53
### Describe The Bug
Hello :)
Since the last commit (ac39d872a805767d7910531c7619754744b670c8) strike through seems broken with the latest Jeboa app.
Editor screenshot:
![Scr... | null | https://github.com/LemmyNet/jerboa/pull/1445 | [
"https://github.com/LemmyNet/jerboa/issues/1444"
] | ./gradlew :app:testDebugUnitTest --tests "com.jerboa.util.markwon.ScriptRewriteSupportPluginTest" | diff --git a/app/src/main/java/com/jerboa/util/markwon/ScriptRewriteSupportPlugin.kt b/app/src/main/java/com/jerboa/util/markwon/ScriptRewriteSupportPlugin.kt
index 9d61dc02d..e931cbcae 100644
--- a/app/src/main/java/com/jerboa/util/markwon/ScriptRewriteSupportPlugin.kt
+++ b/app/src/main/java/com/jerboa/util/markwon/S... | diff --git a/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt b/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt
index 1be365921..0164bacf4 100644
--- a/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt
+++ b/app/src/test/java/com/jerboa/ut... | {
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy script to markwon script(^2^ ^2^, <sup>2</sup> <sup>2</sup>) [3]": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy scrip... | {
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy script to markwon script(~~text~, ~~text~) [12]": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy script to markwon script(^2^, <sup>2<... | {} | {} |
LemmyNet__jerboa-1410 | LemmyNet | jerboa | 1,410 | closed | Fix super and sub script not being properly rendered | 
Fix #1341
| {
"label": "LemmyNet:main",
"ref": "main",
"sha": "bf84fa814208722b0f6640c8850202a948e7c4f6"
} | [
{
"number": 1341,
"title": "Sub and super script in markdown doesn't work",
"body": "### Jerboa Version\n\n0.0.55\n\n### Android Version + Phone\n\nn/a\n\n### Describe The Bug\n\nThe sub and sup markdown actions don't work, it puts the symbols but the markdown renders them as normal.\n\n### To Reproduce... | kotlin | Sub and super script in markdown doesn't work
### Jerboa Version
0.0.55
### Android Version + Phone
n/a
### Describe The Bug
The sub and sup markdown actions don't work, it puts the symbols but the markdown renders them as normal.
### To Reproduce
press the sub/sup button, preview the changes
### In the case of... | Alright not sure why Jerboa uses ~ and ^ for those but markwon never supported that syntax
But they do support script through HTML
So this will be a simple fix | https://github.com/LemmyNet/jerboa/pull/1410 | [
"https://github.com/LemmyNet/jerboa/issues/1341"
] | ./gradlew :app:testDebugUnitTest --tests "com.jerboa.util.markwon.ScriptRewriteSupportPluginTest" | diff --git a/app/src/main/java/com/jerboa/ui/components/common/MarkdownHelper.kt b/app/src/main/java/com/jerboa/ui/components/common/MarkdownHelper.kt
index dd431924a..fb0f4d1f5 100644
--- a/app/src/main/java/com/jerboa/ui/components/common/MarkdownHelper.kt
+++ b/app/src/main/java/com/jerboa/ui/components/common/Markd... | diff --git a/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt b/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt
new file mode 100644
index 000000000..1be365921
--- /dev/null
+++ b/app/src/test/java/com/jerboa/util/markwon/ScriptRewriteSupportPluginTest.kt
@@ -0,0 +... | {
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy script to markwon script(^2^ ^2^, <sup>2</sup> <sup>2</sup>) [3]": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.jerboa.util.markwon.ScriptRewriteSupportPluginTest.should rewrite lemmy scrip... | {} | {} | {} |
LemmyNet__jerboa-802 | LemmyNet | jerboa | 802 | closed | Fix links not working when exclamation mark before it | It didnt work in some cases because it included the space, in the current link matcher.
`(?:^|\\s)!($communityPatternFragment)(?:@($instancePatternFragment))?\\b`
This pattern used a non capturing group, but this... | {
"label": "LemmyNet:main",
"ref": "main",
"sha": "b99d037a603cc5424401c08b459ddf8fd3bc593f"
} | [
{
"number": 795,
"title": "!community@instance is not clickable if has a exclamation mark before it.",
"body": "**Jerboa Version**\r\nlatest from main\r\n\r\n**Describe the bug**\r\nA community@instance is not clickable if it has a exclamation mark before it. Instead it will just collapse the comment.\r... | kotlin | !community@instance is not clickable if has a exclamation mark before it.
**Jerboa Version**
latest from main
**Describe the bug**
A community@instance is not clickable if it has a exclamation mark before it. Instead it will just collapse the comment.
**To Reproduce**
Try to click on it
go to this post http... | Huh weird i have found cases where it does work
this post https://lemmy.world/post/344160
lemmy-ui
jerboa
... | https://github.com/LemmyNet/jerboa/pull/802 | [
"https://github.com/LemmyNet/jerboa/issues/795"
] | ./gradlew :app:testDebugUnitTest --tests "com.jerboa.ui.components.common.LemmyLinkPluginTest" | diff --git a/app/src/main/java/com/jerboa/ui/components/common/MarkdownHelper.kt b/app/src/main/java/com/jerboa/ui/components/common/MarkdownHelper.kt
index ff64aafd0..e61ecb174 100644
--- a/app/src/main/java/com/jerboa/ui/components/common/MarkdownHelper.kt
+++ b/app/src/main/java/com/jerboa/ui/components/common/Markd... | diff --git a/app/src/test/java/com/jerboa/ui/components/common/LemmyLinkPluginTest.kt b/app/src/test/java/com/jerboa/ui/components/common/LemmyLinkPluginTest.kt
index 0875ede7c..09b3e89e5 100644
--- a/app/src/test/java/com/jerboa/ui/components/common/LemmyLinkPluginTest.kt
+++ b/app/src/test/java/com/jerboa/ui/componen... | {
"com.jerboa.ui.components.common.LemmyLinkPluginTest.testUserValid( @user@instance.ml, @user@instance.ml, user, instance.ml) [3]": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.jerboa.ui.components.common.LemmyLinkPluginTest.testUserInvalid(@co) [2]": {
"run": "PASS",
"test": "NONE"... | {
"com.jerboa.ui.components.common.LemmyLinkPluginTest.testCommunityValid(!community, !community, community, null) [0]": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
},
"com.jerboa.ui.components.common.LemmyLinkPluginTest.testCommunityValid(!community@instance.ml, !community@instance.ml, community, ... | {
"com.jerboa.ui.components.common.LemmyLinkPluginTest.testCommunityInvalid(!!community@instance.ml) [1]": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.jerboa.ui.components.common.LemmyLinkPluginTest.testCommunityInvalid(!co) [2]": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
... | {} |
Futsch1__medTimer-800 | Futsch1 | medTimer | 800 | closed | Fix medicine amounts in the thousands being rounded down | **Before:**
https://github.com/user-attachments/assets/71454994-d9a2-4cc7-894c-ab6aeb6f4c22
**After:**
https://github.com/user-attachments/assets/c730402d-abbf-432b-974e-f224741ef5a3
Fixes #797 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "f5ae449597115e0faca19aa8bd452da0b141d2ca"
} | [
{
"number": 797,
"title": "Medicine amounts in the thousands are rounded down",
"body": "**Describe the bug**\nWhen entering a decimal medicine amount in the thousands, the value is usually (but not always) rounded down.\n\n**To Reproduce**\n1. Go to the medicine pane\n2. Enter a name\n3. Go to the newl... | kotlin | Medicine amounts in the thousands are rounded down
**Describe the bug**
When entering a decimal medicine amount in the thousands, the value is usually (but not always) rounded down.
**To Reproduce**
1. Go to the medicine pane
2. Enter a name
3. Go to the newly created medicine
4. Go to the medicine stock page
5. Enter... | Why is a regex used here?
https://github.com/Futsch1/medTimer/blob/f5ae449597115e0faca19aa8bd452da0b141d2ca/app/src/main/java/com/futsch1/medtimer/helpers/MedicineHelper.kt#L95-L105
I don't want to require users to put only the number in the amount, but I want to give a bit more flexibility. So the amount string could... | https://github.com/Futsch1/medTimer/pull/800 | [
"https://github.com/Futsch1/medTimer/issues/797"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.MedicineHelperTest" | diff --git a/app/src/main/java/com/futsch1/medtimer/helpers/MedicineHelper.kt b/app/src/main/java/com/futsch1/medtimer/helpers/MedicineHelper.kt
index 82665be3a..5f0c53ab0 100644
--- a/app/src/main/java/com/futsch1/medtimer/helpers/MedicineHelper.kt
+++ b/app/src/main/java/com/futsch1/medtimer/helpers/MedicineHelper.kt... | diff --git a/app/src/test/java/com/futsch1/medtimer/MedicineHelperTest.kt b/app/src/test/java/com/futsch1/medtimer/MedicineHelperTest.kt
index b4bfe9317..1f3863f7c 100644
--- a/app/src/test/java/com/futsch1/medtimer/MedicineHelperTest.kt
+++ b/app/src/test/java/com/futsch1/medtimer/MedicineHelperTest.kt
@@ -26,6 +26,8 ... | {
"com.futsch1.medtimer.MedicineHelperTest.testParse()": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {
"com.futsch1.medtimer.MedicineHelperTest.testMedicineNameWithStockText()": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.futsch1.medtimer.MedicineHelperTest.testFormat()": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.futsch1.medtimer.MedicineHelperTest.testFormatParseRoundTrip()": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"com.futsch1.medtimer.MedicineHelperTest.testNormalizeMedi... | {} |
Futsch1__medTimer-584 | Futsch1 | medTimer | 584 | closed | 419 bigger button to confirm the medicine taken | Also closes #564 and closes #485 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "c0f542345ea0d1925d6b1e28ce807d4ecc6de035"
} | [
{
"number": 564,
"title": "Simplify the content of notifications",
"body": "**Is your feature request related to a problem? Please describe.**\nI liked it at first, `It is 12:33 - time to take 1x of Vitamin D` is quite informative, but with multiple notifcations it's a bit unreadable and most of the not... | kotlin | Simplify the content of notifications
**Is your feature request related to a problem? Please describe.**
I liked it at first, `It is 12:33 - time to take 1x of Vitamin D` is quite informative, but with multiple notifcations it's a bit unreadable and most of the notification text seems redundant.
**Describe the solutio... | I see your point. I still consider the reminder time important, because you might have several doses of the same medication pending (like the 12:00 dose and the 15:00 dose) and you might want to distinguish those. However, I will consider this input when redesigning the notifications as requested in #419
Sure, but for... | https://github.com/Futsch1/medTimer/pull/584 | [
"https://github.com/Futsch1/medTimer/issues/564",
"https://github.com/Futsch1/medTimer/issues/485"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.ReminderWorkUnitTest" | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 686a3363a..89718ea5f 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -23,8 +23,8 @@ android {
minSdk = 28
multiDexEnabled = true
targetSdk = 36
- versionCode = 109
- versionName = "1.16.9"
+ ve... | diff --git a/app/src/test/java/com/futsch1/medtimer/ReminderWorkUnitTest.java b/app/src/test/java/com/futsch1/medtimer/ReminderWorkUnitTest.java
index 9175ecbbd..661cdb4b0 100644
--- a/app/src/test/java/com/futsch1/medtimer/ReminderWorkUnitTest.java
+++ b/app/src/test/java/com/futsch1/medtimer/ReminderWorkUnitTest.java... | {
"com.futsch1.medtimer.ReminderWorkUnitTest.testDoWorkNotifications()": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
}
} | {
"com.futsch1.medtimer.ReminderWorkUnitTest.testDoWorkNewReminder()": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
},
"com.futsch1.medtimer.ReminderWorkUnitTest.testDoWorkNullHandling()": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
Futsch1__medTimer-133 | Futsch1 | medTimer | 133 | closed | Overview show all due | fixes #122
fixes #132 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "c7c3ed5611bc425ba469af4c5e0df9f00c9af23a"
} | [
{
"number": 122,
"title": "same day reminder",
"body": "I can not figure out how to add an reminder to start the same day. Next reminder is always set to next day."
},
{
"number": 132,
"title": "Show all medicines due in a day",
"body": "The \"next reminder\" section could be more useful... | kotlin | same day reminder
I can not figure out how to add an reminder to start the same day. Next reminder is always set to next day.
Show all medicines due in a day
The "next reminder" section could be more useful if it listed all the medications needed in a day.
As an example, I have to take pills every two days and patches... | This is how it is implemented right now: freshly created reminders will first trigger on the next day. So you'd have to wait for one day.
Is this an issue for you?
Ok then.
Well in my case I had something to take in the same day, but it is not a big deal really.
In this case, I won't do any changes.
| https://github.com/Futsch1/medTimer/pull/133 | [
"https://github.com/Futsch1/medTimer/issues/122",
"https://github.com/Futsch1/medTimer/issues/132"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.ReminderSchedulerDaysUnitTest" --tests "com.futsch1.medtimer.ReminderSchedulerUnitTest" | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 18bf35e59..296b9a2be 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -17,8 +17,8 @@ android {
applicationId = "com.futsch1.medtimer"
minSdk = 33
targetSdk = 34
- versionCode = 48
- versionName = "1.8.... | diff --git a/app/src/androidTest/java/com/futsch1/medtimer/BasicUITest.java b/app/src/androidTest/java/com/futsch1/medtimer/BasicUITest.java
index 12d62f99a..74700eb63 100644
--- a/app/src/androidTest/java/com/futsch1/medtimer/BasicUITest.java
+++ b/app/src/androidTest/java/com/futsch1/medtimer/BasicUITest.java
@@ -172... | {
"com.futsch1.medtimer.ReminderSchedulerUnitTest.test_scheduleTwoDayReminderVsOneDay": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.futsch1.medtimer.ReminderSchedulerUnitTest.test_scheduleWithEvents": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.futsch1.medtimer.Re... | {} | {} | {} |
Futsch1__medTimer-125 | Futsch1 | medTimer | 125 | closed | Taken date in export | fixes #124 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "58fb2c34bcaa3625a0e521e6c71a079f2c03639d"
} | [
{
"number": 124,
"title": "Show taken timestamp in export",
"body": "The export of dosing history currently only shows if a medicine was taken or not. Instead, the actual taken timestamp should be displayed."
}
] | kotlin | Show taken timestamp in export
The export of dosing history currently only shows if a medicine was taken or not. Instead, the actual taken timestamp should be displayed.
| null | https://github.com/Futsch1/medTimer/pull/125 | [
"https://github.com/Futsch1/medTimer/issues/124"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.CSVExportUnitTest" | diff --git a/README.md b/README.md
index 9be429fb2..c77462108 100644
--- a/README.md
+++ b/README.md
@@ -5,8 +5,7 @@
<img src="app/src/main/play/listings/en-US/graphics/feature-graphic/1.png" width="150" />
-The app is built targeting SDK 34 and requiring SDK 33 (>= Android 13) making use of an Android Room
-datab... | diff --git a/app/src/test/java/com/futsch1/medtimer/CSVExportUnitTest.java b/app/src/test/java/com/futsch1/medtimer/CSVExportUnitTest.java
index 78c647fa5..0cd2a4850 100644
--- a/app/src/test/java/com/futsch1/medtimer/CSVExportUnitTest.java
+++ b/app/src/test/java/com/futsch1/medtimer/CSVExportUnitTest.java
@@ -34,6 +3... | {} | {
"com.futsch1.medtimer.CSVExportUnitTest.test_create_csv_file_with_correct_headers_and_data": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"com.futsch1.medtimer.CSVExportUnitTest.test_handle_empty_list_of_reminder_events": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
}
} | {} |
Futsch1__medTimer-108 | Futsch1 | medTimer | 108 | closed | Event import | fixes #62 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "49ec3d1b8b20e9fbf8baa672cdfea88c3f582689"
} | [
{
"number": 62,
"title": "Restore events",
"body": "OK, it may well be that I'm getting a bit old and don't realise things so quickly. ;) Saving and restoring the medication schedule now works. Exporting the events is quite simple. But how and where can I restore previously saved events in the app, i.e.... | kotlin | Restore events
OK, it may well be that I'm getting a bit old and don't realise things so quickly. ;) Saving and restoring the medication schedule now works. Exporting the events is quite simple. But how and where can I restore previously saved events in the app, i.e. restore the events?
| This is not implemented yet, so it is indeed hard to find ;-)
I wouldn't consider this a high prio feature since events can already be exported and you usually wouldn't need them imported back into the app as a part of the backup from my opinion. But maybe I'm overlooking some use case?
So I'll keep it open and a... | https://github.com/Futsch1/medTimer/pull/108 | [
"https://github.com/Futsch1/medTimer/issues/62"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.JSONReminderEventBackupUnitTest" --tests "com.futsch1.medtimer.JSONMedicineBackupUnitTest" | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index e6526c2c3..1f82003df 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -17,8 +17,8 @@ android {
applicationId = "com.futsch1.medtimer"
minSdk = 33
targetSdk = 34
- versionCode = 41
- versionName = "1.8.... | diff --git a/app/src/androidTest/java/com/futsch1/medtimer/StatisticsTest.java b/app/src/androidTest/java/com/futsch1/medtimer/StatisticsTest.java
index 11bbc4147..3e6f98c92 100644
--- a/app/src/androidTest/java/com/futsch1/medtimer/StatisticsTest.java
+++ b/app/src/androidTest/java/com/futsch1/medtimer/StatisticsTest.... | {
"com.futsch1.medtimer.JSONMedicineBackupUnitTest.test_iterates_over_medicinesWithReminders_and_adds_to_medicines_array": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.futsch1.medtimer.JSONMedicineBackupUnitTest.test_parse_json_backup_missing_fields": {
"run": "NONE",
"test": "NONE",... | {} | {} | {} |
Futsch1__medTimer-70 | Futsch1 | medTimer | 70 | closed | Weekend mode | fixes #63 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "53f561b878fa7dd4c66f484f8c9e253b8fc7e790"
} | [
{
"number": 63,
"title": "Weekend notification delay",
"body": "It should be possible to configure an \"earliest notification time\" for weekends or configurable days. This setting will result in all earlier reminders for that day to be scheduled at that time (like a \"do not disturb\" setting)."
}
] | kotlin | Weekend notification delay
It should be possible to configure an "earliest notification time" for weekends or configurable days. This setting will result in all earlier reminders for that day to be scheduled at that time (like a "do not disturb" setting).
| null | https://github.com/Futsch1/medTimer/pull/70 | [
"https://github.com/Futsch1/medTimer/issues/63"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.WeekendModeTest" | diff --git a/app/src/main/java/com/futsch1/medtimer/PreferencesActivity.java b/app/src/main/java/com/futsch1/medtimer/PreferencesActivity.java
index 701f5cbed..584e2f9eb 100644
--- a/app/src/main/java/com/futsch1/medtimer/PreferencesActivity.java
+++ b/app/src/main/java/com/futsch1/medtimer/PreferencesActivity.java
@@ ... | diff --git a/app/src/test/java/com/futsch1/medtimer/WeekendModeTest.java b/app/src/test/java/com/futsch1/medtimer/WeekendModeTest.java
new file mode 100644
index 000000000..2e86d4147
--- /dev/null
+++ b/app/src/test/java/com/futsch1/medtimer/WeekendModeTest.java
@@ -0,0 +1,118 @@
+package com.futsch1.medtimer;
+
+impor... | {
"com.futsch1.medtimer.WeekendModeTest.test_adjustInstant_ReturnsSameInstant_WeekendDaysEmpty": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.futsch1.medtimer.WeekendModeTest.test_adjustInstant_ReturnsSameInstant_WeekendModeDisabled": {
"run": "NONE",
"test": "NONE",
"fix": "PASS... | {} | {} | {} |
Futsch1__medTimer-54 | Futsch1 | medTimer | 54 | closed | Json backup | fixes #49 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "69c1ef4a661eb2db9737f95fa2df3472e31c91ed"
} | [
{
"number": 49,
"title": "Export/import med settings/data plan",
"body": "Unfortunately the app (1.4.2) crashed at one point so bad, that all reinstalling didn't help. Not sure if it was a Xiaomi issue. First notifications stopped. Then after checking and editing some energy saving mode, the app didn't ... | kotlin | Export/import med settings/data plan
Unfortunately the app (1.4.2) crashed at one point so bad, that all reinstalling didn't help. Not sure if it was a Xiaomi issue. First notifications stopped. Then after checking and editing some energy saving mode, the app didn't start any more at all.
What helped was a simple uni... | I am sorry that the app stopped working on your device. I haven't experienced a similar behavior and have not yet received any crash reports via the Google Play dashboard.
However, I will look into your feature request to support an export and import of the settings in one of the next releases.
Was installed via f-d... | https://github.com/Futsch1/medTimer/pull/54 | [
"https://github.com/Futsch1/medTimer/issues/49"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.JSONBackupUnitTest" | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 21d0ca638..1515faa4b 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -42,6 +42,11 @@ android {
androidResources {
generateLocaleConfig = true
}
+ testOptions {
+ unitTests {
+ isIncludeAndroidResources... | diff --git a/app/src/test/java/com/futsch1/medtimer/JSONBackupUnitTest.java b/app/src/test/java/com/futsch1/medtimer/JSONBackupUnitTest.java
new file mode 100644
index 000000000..d32b450d5
--- /dev/null
+++ b/app/src/test/java/com/futsch1/medtimer/JSONBackupUnitTest.java
@@ -0,0 +1,227 @@
+package com.futsch1.medtimer;... | {
"com.futsch1.medtimer.JSONBackupUnitTest.test_parse_json_backup_missing_fields": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.futsch1.medtimer.JSONBackupUnitTest.test_creates_backup_with_version_and_medicines_array": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.fu... | {} | {} | {} |
Futsch1__medTimer-29 | Futsch1 | medTimer | 29 | closed | Reminder every n days | closes #24 | {
"label": "Futsch1:main",
"ref": "main",
"sha": "43719af52d91f0e48ccdaa5a9a6554e924137649"
} | [
{
"number": 24,
"title": "Reminder: Every second day",
"body": "I would need the reminder to be set only for every second day. \n\nCould this be included in a future release?:)\n\nThe best, Michael"
}
] | kotlin | Reminder: Every second day
I would need the reminder to be set only for every second day.
Could this be included in a future release?:)
The best, Michael
| Yes, I'll work on that in the coming weeks. | https://github.com/Futsch1/medTimer/pull/29 | [
"https://github.com/Futsch1/medTimer/issues/24"
] | ./gradlew :app:testDebugUnitTest --tests "com.futsch1.medtimer.ReminderSchedulerUnitTest" | diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 32be54582..c9a17187a 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -16,8 +16,8 @@ android {
applicationId = "com.futsch1.medtimer"
minSdk = 33
targetSdk = 34
- versionCode = 19
- versionName = "1.2.... | diff --git a/app/src/main/java/com/futsch1/medtimer/GenerateTestData.java b/app/src/main/java/com/futsch1/medtimer/GenerateTestData.java
index 05ba5449b..e4160c67e 100644
--- a/app/src/main/java/com/futsch1/medtimer/GenerateTestData.java
+++ b/app/src/main/java/com/futsch1/medtimer/GenerateTestData.java
@@ -19,18 +19,1... | {
"com.futsch1.medtimer.ReminderSchedulerUnitTest.test_scheduleTwoDayReminderVsOneDay": {
"run": "NONE",
"test": "NONE",
"fix": "PASS"
},
"com.futsch1.medtimer.ReminderSchedulerUnitTest.scheduler_withEvents": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"com.futsch1.medtimer.Remin... | {} | {} | {} |
mjaakko__NeoStumbler-338 | mjaakko | NeoStumbler | 338 | closed | Fix Ichnaea compatibility by not encoding null values | Fixes #337 | {
"label": "mjaakko:master",
"ref": "master",
"sha": "e4704dd3e6c6e57d03ec3883094d6b587b8f3cec"
} | [
{
"number": 337,
"title": "Ichnaea incompatibility since 1.4.0 (null values in JSON request)",
"body": "### Description\n\nSince 1.4.0 report upload to an Ichnaea instance is broken, the following is a (redacted and shortened) JSON request:\r\n```json\r\n{\r\n \"items\":\r\n [\r\n {\r\n ... | kotlin | Ichnaea incompatibility since 1.4.0 (null values in JSON request)
### Description
Since 1.4.0 report upload to an Ichnaea instance is broken, the following is a (redacted and shortened) JSON request:
```json
{
"items":
[
{
"bluetoothBeacons": null,
"cellTowers": null,
... | null | https://github.com/mjaakko/NeoStumbler/pull/338 | [
"https://github.com/mjaakko/NeoStumbler/issues/337"
] | ./gradlew :app:testFullDebugUnitTest --tests "xyz.malkki.neostumbler.geosubmit.MLSGeosubmitTest" | diff --git a/app/src/main/java/xyz/malkki/neostumbler/geosubmit/MLSGeosubmit.kt b/app/src/main/java/xyz/malkki/neostumbler/geosubmit/MLSGeosubmit.kt
index e9d6495e..372291fc 100644
--- a/app/src/main/java/xyz/malkki/neostumbler/geosubmit/MLSGeosubmit.kt
+++ b/app/src/main/java/xyz/malkki/neostumbler/geosubmit/MLSGeosub... | diff --git a/app/src/test/java/xyz/malkki/neostumbler/geosubmit/MLSGeosubmitTest.kt b/app/src/test/java/xyz/malkki/neostumbler/geosubmit/MLSGeosubmitTest.kt
index d06002cc..50f4faf3 100644
--- a/app/src/test/java/xyz/malkki/neostumbler/geosubmit/MLSGeosubmitTest.kt
+++ b/app/src/test/java/xyz/malkki/neostumbler/geosubm... | {} | {
"xyz.malkki.neostumbler.geosubmit.MLSGeosubmitTest.Test sending a report": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {} | {} |
mjaakko__NeoStumbler-127 | mjaakko | NeoStumbler | 127 | closed | Remove consecutive slashes from the Geosubmit endpoint URL | Fixes #126 | {
"label": "mjaakko:master",
"ref": "master",
"sha": "5fad2376b2d11ff8712c970729dc286f80c5569d"
} | [
{
"number": 126,
"title": "Normalize submission URL",
"body": "I have two users who are sending data to `//v2/geosubmit`, resulting in a 404 error.\r\n\r\n```\r\n\"POST //v2/geosubmit HTTP/2.0\" 404 0 \"-\" \"NeoStumbler/9\"\r\n```"
}
] | kotlin | Normalize submission URL
I have two users who are sending data to `//v2/geosubmit`, resulting in a 404 error.
```
"POST //v2/geosubmit HTTP/2.0" 404 0 "-" "NeoStumbler/9"
```
| null | https://github.com/mjaakko/NeoStumbler/pull/127 | [
"https://github.com/mjaakko/NeoStumbler/issues/126"
] | ./gradlew :app:testFullDebugUnitTest --tests "xyz.malkki.neostumbler.geosubmit.GeosubmitParamsTest" | diff --git a/app/src/main/java/xyz/malkki/neostumbler/geosubmit/GeosubmitParams.kt b/app/src/main/java/xyz/malkki/neostumbler/geosubmit/GeosubmitParams.kt
index 3ecb2771..8104bf9a 100644
--- a/app/src/main/java/xyz/malkki/neostumbler/geosubmit/GeosubmitParams.kt
+++ b/app/src/main/java/xyz/malkki/neostumbler/geosubmit/... | diff --git a/app/src/test/java/xyz/malkki/neostumbler/geosubmit/GeosubmitParamsTest.kt b/app/src/test/java/xyz/malkki/neostumbler/geosubmit/GeosubmitParamsTest.kt
new file mode 100644
index 00000000..07108ff1
--- /dev/null
+++ b/app/src/test/java/xyz/malkki/neostumbler/geosubmit/GeosubmitParamsTest.kt
@@ -0,0 +1,20 @@
... | {} | {
"xyz.malkki.neostumbler.geosubmit.GeosubmitParamsTest.Test creating an URL when both base URL and path contain a slash": {
"run": "NONE",
"test": "FAIL",
"fix": "PASS"
}
} | {
"xyz.malkki.neostumbler.geosubmit.GeosubmitParamsTest.Test creating an URL": {
"run": "NONE",
"test": "PASS",
"fix": "PASS"
}
} | {} |
openhab__openhab-android-3836 | openhab | openhab-android | 3,836 | closed | Fix text items with newline character | Closes #3814 | {
"label": "openhab:main",
"ref": "main",
"sha": "4d97b9328c8a97d9b19ebb376ef776b4d5343e77"
} | [
{
"number": 3814,
"title": "String-Item is no more shown in any newer App-Version than 3.15.4",
"body": "The String-Item was since years shown in the app and everywhere else it works, only in the new app-verssion it's without any text\r\n\r\n\r\n*.sitemap: `Text item=KA_AF` \r\n*.items: `S... | kotlin | String-Item is no more shown in any newer App-Version than 3.15.4
The String-Item was since years shown in the app and everywhere else it works, only in the new app-verssion it's without any text
*.sitemap: `Text item=KA_AF`
*.items: `String KA_AF "[%s]" <waste> { channel="http:url:KA_AF:text"}`
*... | Is this the only String item with issues? Can you post the Sitemap definition and make a screenshot of the app?
Hello Mueller-ma,
yes only that one string item (with the issue is the one witht the brown garbage can)
version newer than 3.15.4
![WhatsApp Bild 2024-09-01 um 10 54 51_96e32272](https://github.com/... | https://github.com/openhab/openhab-android/pull/3836 | [
"https://github.com/openhab/openhab-android/issues/3814"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.model.WidgetTest" | diff --git a/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt b/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt
index 290f72b41c..d74942dc61 100644
--- a/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt
+++ b/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt
@@ -71,9 +71,15 @@ data c... | diff --git a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
index 2ff256665f..b99bdaa080 100644
--- a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
@@ -170,7... | {
"org.openhab.habdroid.model.WidgetTest.testGetIconPath": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testCountInstances": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetMappingNoMapping": {
... | {
"org.openhab.habdroid.model.WidgetTest.testGetService": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.openhab.habdroid.model.WidgetTest.testGetColors": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetHeight": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.getIconPath_iconExists_returnIconUr... | {} |
openhab__openhab-android-3770 | openhab | openhab-android | 3,770 | closed | Fix stateFromLabel when label contains square brackets in pattern | Fix #3756
The problem was:
- StringItem's state contains `[]`
- Sitemap puts the item's (display) state into the label as `Label [formattedstate]`
- So now we have nested `[]` causing parsing errors when trying to extract the formattedstate from `[mytext with [] in it]`. | {
"label": "openhab:main",
"ref": "main",
"sha": "f23ebe4491b61674b2f48e9739c9f1ee0042ab1c"
} | [
{
"number": 3756,
"title": "Sitemaps Input widget strips off `[]` characters",
"body": "### Actual behaviour\r\n\r\nItem:\r\n```\r\nString TestString1\r\n```\r\n\r\nSitemap:\r\n```\r\nsitemap test {\r\n Input item=TestString1\r\n}\r\n```\r\n\r\n- Open that sitemap on android 3.15.0\r\n- Enter `abcdefgh... | kotlin | Sitemaps Input widget strips off `[]` characters
### Actual behaviour
Item:
```
String TestString1
```
Sitemap:
```
sitemap test {
Input item=TestString1
}
```
- Open that sitemap on android 3.15.0
- Enter `abcdefgh[]` into the text field, and click the checkmark (enter) on the Android's virtual key... | In your title you wrote "BasicUI", but I guess you mean Sitemaps? Can you check the behavior in Basic UI (Sitemaps in browser)?
Yes I meant Sitemap, sorry.
BasicUI (sitemaps in browser) has its own, different bug related to this: https://github.com/openhab/openhab-webui/issues/2675 | https://github.com/openhab/openhab-android/pull/3770 | [
"https://github.com/openhab/openhab-android/issues/3756"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.model.WidgetTest" | diff --git a/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt b/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt
index 745fb941a1..290f72b41c 100644
--- a/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt
+++ b/mobile/src/main/java/org/openhab/habdroid/model/Widget.kt
@@ -73,7 +73,7 @@ data cl... | diff --git a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
index f64452caed..2ff256665f 100644
--- a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
@@ -46,7 ... | {
"org.openhab.habdroid.model.WidgetTest.testGetIconPath": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testCountInstances": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetMappingNoMapping": {
... | {
"org.openhab.habdroid.model.WidgetTest.testGetService": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.openhab.habdroid.model.WidgetTest.testGetColors": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetHeight": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.getIconPath_iconExists_returnIconUr... | {} |
openhab__openhab-android-3346 | openhab | openhab-android | 3,346 | closed | Fix icon name parsing | Closes #3342 | {
"label": "openhab:main",
"ref": "main",
"sha": "717fa03500556b5f265cc8e8f5bf189d4bbe164d"
} | [
{
"number": 3342,
"title": "Support missing for icon value like oh:humidity",
"body": "The Android app already correctly renders icons \"temperature\" and \"oh:classic:pressure\".\r\nIt would be great if \"oh:humidity\" could be also supported.\r\nIn case no icon set is provided by the user,, the app sh... | kotlin | Support missing for icon value like oh:humidity
The Android app already correctly renders icons "temperature" and "oh:classic:pressure".
It would be great if "oh:humidity" could be also supported.
In case no icon set is provided by the user,, the app should consider by default the "classic" icon set.
| I don't know how the app is requesting the icon, but for "oh:humidity", either you have to set properly the request parameter "iconset" (to "classic") or you have to not set it at all in that case and the OH server will then consider the "classic" icon set by default.
The current workaround is to not use this syntax an... | https://github.com/openhab/openhab-android/pull/3346 | [
"https://github.com/openhab/openhab-android/issues/3342"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.model.WidgetTest" | diff --git a/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt b/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt
index 17b1c89f9e..0d5c98e50c 100644
--- a/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt
+++ b/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt
@... | diff --git a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
index 4a2f275c25..ea580ea019 100644
--- a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
@@ -81,7 ... | {
"org.openhab.habdroid.model.WidgetTest.testGetIconPath": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testCountInstances": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetMappingNoMapping": {
... | {
"org.openhab.habdroid.model.WidgetTest.testGetService": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.openhab.habdroid.model.WidgetTest.testGetColors": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetHeight": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.getIconPath_iconExists_returnIconUr... | {} |
openhab__openhab-android-3297 | openhab | openhab-android | 3,297 | closed | Update parsing of icon name | Closes #3295 | {
"label": "openhab:main",
"ref": "main",
"sha": "125323a1e572247c9020b1e57f953ca37616f0c3"
} | [
{
"number": 3295,
"title": "Update parsing of icon name",
"body": "https://github.com/openhab/openhab-webui/pull/1766"
}
] | kotlin | Update parsing of icon name
https://github.com/openhab/openhab-webui/pull/1766
| null | https://github.com/openhab/openhab-android/pull/3297 | [
"https://github.com/openhab/openhab-android/issues/3295"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.model.WidgetTest" | diff --git a/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt b/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt
index 3b55f62d61..17b1c89f9e 100644
--- a/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt
+++ b/mobile/src/main/java/org/openhab/habdroid/model/IconResource.kt
@... | diff --git a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
index e7c6eb23db..4a2f275c25 100644
--- a/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/model/WidgetTest.kt
@@ -79,6 ... | {
"org.openhab.habdroid.model.WidgetTest.testGetIconPath": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testCountInstances": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetMappingNoMapping": {
... | {
"org.openhab.habdroid.model.WidgetTest.testGetService": {
"run": "PASS",
"test": "FAIL",
"fix": "PASS"
}
} | {
"org.openhab.habdroid.model.WidgetTest.testGetColors": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.testGetHeight": {
"run": "PASS",
"test": "PASS",
"fix": "PASS"
},
"org.openhab.habdroid.model.WidgetTest.getIconPath_iconExists_returnIconUr... | {} |
openhab__openhab-android-3123 | openhab | openhab-android | 3,123 | closed | Move AbstractSettingsFragment to a new file | Fixes #3121
Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com> | {
"label": "openhab:main",
"ref": "main",
"sha": "5e97de2f6e352db785af8448456b4c5e13aa92a9"
} | [
{
"number": 3121,
"title": "Preference fragments: \"This method should only be accessed from tests or within private scope\"",
"body": "There are a lot of \"This method should only be accessed from tests or within private scope\" issues in the child classes of `PreferencesActivity.AbstractSettingsFragme... | kotlin | Preference fragments: "This method should only be accessed from tests or within private scope"
There are a lot of "This method should only be accessed from tests or within private scope" issues in the child classes of `PreferencesActivity.AbstractSettingsFragment`.
| null | https://github.com/openhab/openhab-android/pull/3123 | [
"https://github.com/openhab/openhab-android/issues/3121"
] | ./gradlew :mobile:testFossBetaDebugUnitTest --tests "org.openhab.habdroid.util.PreferencesUtilTest" | diff --git a/mobile/src/main/java/org/openhab/habdroid/ui/preference/PreferencesActivity.kt b/mobile/src/main/java/org/openhab/habdroid/ui/preference/PreferencesActivity.kt
index 088b508dc9..bc43d1dee8 100644
--- a/mobile/src/main/java/org/openhab/habdroid/ui/preference/PreferencesActivity.kt
+++ b/mobile/src/main/java... | diff --git a/mobile/src/test/java/org/openhab/habdroid/util/PreferencesUtilTest.kt b/mobile/src/test/java/org/openhab/habdroid/util/PreferencesUtilTest.kt
index d23fcb4566..b48a03d9a8 100644
--- a/mobile/src/test/java/org/openhab/habdroid/util/PreferencesUtilTest.kt
+++ b/mobile/src/test/java/org/openhab/habdroid/util/... | {
"org.openhab.habdroid.util.PreferencesUtilTest.testIsWeakPassword": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.util.PreferencesUtilTest.testBeautifyHostName": {
"run": "PASS",
"test": "NONE",
"fix": "PASS"
},
"org.openhab.habdroid.util.PreferencesUtilTest... | {} | {} | {} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.